From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 938CDC6FD19 for ; Mon, 13 Mar 2023 00:07:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229742AbjCMAH0 (ORCPT ); Sun, 12 Mar 2023 20:07:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbjCMAHY (ORCPT ); Sun, 12 Mar 2023 20:07:24 -0400 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 470EA3526B for ; Sun, 12 Mar 2023 17:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1678666041; x=1710202041; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=r9VZpfYxoyk1rMUrZi/rwjzuzmC5Z2gPyDhCfbA35qk=; b=KAmrQv11/b/rzaK+o7/Xjf+h7MncocQqZf3ezMOUZBQS6Tfi3vahBkiE Sl3AeFbSnzzAvmoxGrNEVTN+WhnEtg5pUKV4jPY92RyoUazu8AcU+Xy6H OIhAEv0gBRhkk/esOig+Xrl/aMRwohtbrzY/s4bso8CD4xRJCIQCCbi5d sUZp1LRA1Wv0j8KEtdOCJvaLtEHK1LseL2xbDS0++M5CMaSmCSRyloaNG VMEwakNeGJkfRYHKtfrTnOnqUC48W5Ymmd+Sq8AxB5wD4YqtVESFW5pc2 wWUZv1VBTMmM5msVOxPPXOBLSAOIU+pbh2MT4ydHYGcEEcAzCgsjxxJlX w==; X-IronPort-AV: E=Sophos;i="5.98,254,1673884800"; d="scan'208";a="225238754" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 13 Mar 2023 08:07:20 +0800 IronPort-SDR: YF28CcLfvH4h5kRYakOttUpxylR0WEwgyUfpvzU8jFV6Jq5I9oNW3osmpCgVJuMA/dPZDj8J+v l3mwAC0yatUsDHBu2ZUAg6YUGcpfmw8WpA5/DQtSME39zgwgC7D40gmmgjMvfPEDiiENSJAo3b FgKYsUjmIot64v7ztUad9VgpDE2ULvt8wyaj+0iOH9nHz76RA7FLB3X1oaEdEk/UIcNHgvQMaQ /nOcwAudDo/cG7wis+VfJprc7P/OmvVF2nzYTTvjymNlDwleyy2SMgsyrDvenOp0Rzub3m+bUx wII= Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Mar 2023 16:23:50 -0700 IronPort-SDR: ig7OkhQP2o5NLMtIeF30GMoa4nnBj9vIg/OPaWHkljoNvhWu+nmOuD4yBwRoW2M8Yb6Mftf0hC Z3jHV7xeZKhZPa1fMisnM3fNylMYgojMoMmeTRa1Fm5wneFS3ryKd7vbiUGCuolmDx8O7aSMkk FoK1xuYj6Yb0EDt88W+3x+K9CcNU42Kt8hKZzaDY/aQc2IOKxVBR/bg0/WkIclQtSYXPdw7I9d 38tfkxoJuA71xNnjsZ5WbcIdmEghNr3JjljoQhovrX/R/0j8iG0V+XvOQMqTZ/3xcYUXzAq1PS xks= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Mar 2023 17:07:20 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4PZcRD2z78z1Rwrq for ; Sun, 12 Mar 2023 17:07:20 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1678666039; x=1681258040; bh=r9VZpfYxoyk1rMUrZi/rwjzuzmC5Z2gPyDh CfbA35qk=; b=FGgbAWvs/JxXYPnGwZKSEjkEaMjOhp+Rgja6vDvhHMuOrEDrahZ dGDtzAFpO1Lqa1Hh3PQuxLsKQ8M6muTr0Dc2d0f8Z8VzDbj+neIL3MOVF2oUoSLo mEFyxpGSfqW5SVMxq8BSinuxnB/ldCyUvAeNVDwYQLAbd/xgrxH5ysMpqHLCT4vs w4mskBHSQx7PE2lGEhtkGLJjXw+5NKkt53w3igmuhqePV2CkozbSONVxj0erDsQ+ PMN6d29gr8jRj2CIt4Z3r+Ua9ynndZd0o/UUcR1slzUi6ZZ00VMSncjRdKdzYYg7 ZSiGkh/fiQRxhbDLlePdDSSSTsruprT3/Uw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id kZW2eqermEeH for ; Sun, 12 Mar 2023 17:07:19 -0700 (PDT) Received: from [10.225.163.79] (unknown [10.225.163.79]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4PZcRB3ZGRz1RvLy; Sun, 12 Mar 2023 17:07:18 -0700 (PDT) Message-ID: Date: Mon, 13 Mar 2023 09:07:16 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2] UML: pata_cs5536: fix build for X86_32 UML with TRACEPOINTS Content-Language: en-US To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Richard Weinberger , Anton Ivanov , Johannes Berg , linux-ide@vger.kernel.org, linux-um@lists.infradead.org, Geert Uytterhoeven References: <20230312235553.26298-1-rdunlap@infradead.org> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230312235553.26298-1-rdunlap@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/13/23 08:55, Randy Dunlap wrote: > Current build of pata_cs5536 for i386 UML fails with: > > ERROR: modpost: "__tracepoint_write_msr" [drivers/ata/pata_cs5536.ko] undefined! > ERROR: modpost: "do_trace_write_msr" [drivers/ata/pata_cs5536.ko] undefined! > ERROR: modpost: "__tracepoint_read_msr" [drivers/ata/pata_cs5536.ko] undefined! > ERROR: modpost: "do_trace_read_msr" [drivers/ata/pata_cs5536.ko] undefined! > > Add the arch/x86/lib/msr.o binary to resolve these undefined symbols. > > Signed-off-by: Randy Dunlap > Cc: Richard Weinberger > Cc: Anton Ivanov > Cc: Johannes Berg > Cc: Damien Le Moal > Cc: linux-ide@vger.kernel.org > Cc: linux-um@lists.infradead.org > Cc: Geert Uytterhoeven > --- > arch/x86/um/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -- a/arch/x86/um/Makefile b/arch/x86/um/Makefile > --- a/arch/x86/um/Makefile > +++ b/arch/x86/um/Makefile > @@ -21,7 +21,7 @@ obj-y += checksum_32.o syscalls_32.o > obj-$(CONFIG_ELF_CORE) += elfcore.o > > subarch-y = ../lib/string_32.o ../lib/atomic64_32.o ../lib/atomic64_cx8_32.o > -subarch-y += ../lib/cmpxchg8b_emu.o ../lib/atomic64_386_32.o > +subarch-y += ../lib/cmpxchg8b_emu.o ../lib/atomic64_386_32.o ../lib/msr.o > subarch-y += ../kernel/sys_ia32.o > > else Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research