From: Paolo Bonzini <pbonzini@redhat.com>
To: Erwan Velu <e.velu@criteo.com>,
Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Erwan Velu <erwanaliasr1@gmail.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm: x86: Print "disabled by bios" only once per host
Date: Wed, 19 Feb 2020 18:51:00 +0100 [thread overview]
Message-ID: <ea2800cf-4c23-9cb5-5904-08a709f6d594@redhat.com> (raw)
In-Reply-To: <646147a6-730b-0366-10db-ed74489ad11e@criteo.com>
On 19/02/20 17:53, Erwan Velu wrote:
>
>
> I've been testing the ratelimited which is far better but still prints
> 12 messages.
12 is already much better than 256. Someone else will have an even
bigger system requiring a larger delay, so I'd go with the default.
Paolo
> I saw the ratelimit is on about 5 sec, I wonder if we can explicit a
> longer one for this one.
>
> I searched around this but it doesn't seems that hacking the delay is a
> common usage.
>
> Do you have any insights/ideas around that ?
>
>
> Switching to ratelimit could be done by replacing the actual call or add
> a macro similar to kvm_pr_unimpl() so it can be reused easily.
next prev parent reply other threads:[~2020-02-19 17:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 14:30 Erwan Velu
2020-02-14 17:05 ` Sean Christopherson
2020-02-18 16:28 ` Erwan Velu
2020-02-18 18:48 ` Sean Christopherson
2020-02-19 11:19 ` Erwan Velu
2020-02-19 11:32 ` Erwan Velu
2020-02-19 17:42 ` Erwan Velu
2020-02-19 16:18 ` Sean Christopherson
2020-02-19 16:53 ` Erwan Velu
2020-02-19 17:51 ` Paolo Bonzini [this message]
2020-02-19 21:52 ` Erwan Velu
2020-02-14 17:43 ` Jim Mattson
2020-02-27 18:00 ` [PATCH v2] kvm: x86: Limit the number of "kvm: disabled by bios" messages Erwan Velu
2020-02-28 10:37 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea2800cf-4c23-9cb5-5904-08a709f6d594@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=e.velu@criteo.com \
--cc=erwanaliasr1@gmail.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®