From: Guenter Roeck <linux@roeck-us.net>
To: Artur Kowalski <arturkow2000@gmail.com>
Cc: Daniel Lezcano <daniel.lezcano@kernel.org>,
Thomas Gleixner <tglx@kernel.org>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-doc@vger.kernel.org,
clamor95@gmail.com
Subject: Re: [PATCH 2/6] watchdog: tegra_wdt: Move SoC specific parts into match data
Date: Sat, 14 Nov 2026 09:22:43 -0800 [thread overview]
Message-ID: <ea2ab23d-d628-46a7-9cad-0bbcd8722869@roeck-us.net> (raw)
In-Reply-To: <20261110-t20-for-upstream-v1-2-5923449951fe@gmail.com>
On Tue, Nov 10, 2026 at 01:39:07PM +0100, Artur Kowalski wrote:
> The driver only supports the watchdog blocks of Tegra30 and later. Move
> the parts that differ between SoC generations, namely the watchdog
> operations, the maximum timeout and the register setup, into a per-SoC
> structure selected through the match data, so that support for Tegra20,
> which has no watchdog block, can be added.
This does not make sense. Literally every watchdog operation is different.
Tegra 20 support should be added with a separate driver.
>
> Suspend and resume call the operations through the watchdog device, so
> they work with any SoC.
>
> No functional change.
>
> Assisted-by: Claude:claude-opus-5-5
This trailer is obsolete. Please have your agent follow AGENTS.md.
Thanks,
Guenter
next prev parent reply other threads:[~2026-11-14 17:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 12:39 [PATCH 0/6] watchdog: tegra_wdt: Add Tegra20 support Artur Kowalski
2026-11-10 12:39 ` [PATCH 1/6] clocksource/drivers/timer-tegra: Keep Tegra20's watchdog timers free Artur Kowalski
2026-11-10 12:39 ` [PATCH 2/6] watchdog: tegra_wdt: Move SoC specific parts into match data Artur Kowalski
2026-11-14 17:22 ` Guenter Roeck [this message]
2026-11-10 12:39 ` [PATCH 3/6] watchdog: tegra_wdt: Support Tegra20 Artur Kowalski
2026-11-10 16:21 ` Krzysztof Kozlowski
2026-11-10 12:39 ` [PATCH 4/6] soc/tegra: pmc: Add an option to keep the VDE partition on Artur Kowalski
2026-11-10 12:39 ` [PATCH 5/6] soc/tegra: pmc: Add a partition power off notifier Artur Kowalski
2026-11-10 12:39 ` [PATCH 6/6] watchdog: tegra_wdt: Stop on Tegra20 VDE power off Artur Kowalski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea2ab23d-d628-46a7-9cad-0bbcd8722869@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arturkow2000@gmail.com \
--cc=clamor95@gmail.com \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=tglx@kernel.org \
--cc=thierry.reding@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®