From: Andrew Lunn <andrew@lunn.ch>
To: Jijie Shao <shaojijie@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
shenjian15@huawei.com, wangpeiyang1@huawei.com,
liuyonglong@huawei.com, chenhao418@huawei.com,
sudongming1@huawei.com, xujunsheng@huawei.com,
shiyongbang@huawei.com, libaihan@huawei.com,
jonathan.cameron@huawei.com,
shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 5/7] net: hibmcge: Add pauseparam supported in this module
Date: Wed, 23 Oct 2024 16:15:56 +0200 [thread overview]
Message-ID: <ea2caab1-1bf9-47b3-96a8-6c1c92fbc83b@lunn.ch> (raw)
In-Reply-To: <20241023134213.3359092-6-shaojijie@huawei.com>
> +static int hbg_ethtool_set_pauseparam(struct net_device *net_dev,
> + struct ethtool_pauseparam *param)
> +{
> + struct hbg_priv *priv = netdev_priv(net_dev);
> +
> + if (param->autoneg) {
> + netdev_err(net_dev, "autoneg unsupported\n");
> + return -EOPNOTSUPP;
> + }
Not being able to do it is not an error, so there is no need for the
netdev_err().
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2024-10-23 14:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 13:42 [PATCH net-next 0/7] Support some features for the HIBMCGE driver Jijie Shao
2024-10-23 13:42 ` [PATCH net-next 1/7] net: hibmcge: Add dump statistics supported in this module Jijie Shao
2024-10-23 13:42 ` [PATCH net-next 2/7] net: hibmcge: Add debugfs " Jijie Shao
2024-10-23 14:00 ` Andrew Lunn
2024-10-24 2:19 ` Jijie Shao
2024-10-24 12:05 ` Andrew Lunn
2024-10-24 14:06 ` Jijie Shao
2024-10-24 14:21 ` Andrew Lunn
2024-10-24 14:31 ` Jijie Shao
2024-10-23 13:42 ` [PATCH net-next 3/7] net: hibmcge: Add unicast frame filter " Jijie Shao
2024-10-23 14:05 ` Andrew Lunn
2024-10-24 3:09 ` Jijie Shao
2024-10-24 12:07 ` Andrew Lunn
2024-10-24 14:07 ` Jijie Shao
2024-10-23 13:42 ` [PATCH net-next 4/7] net: hibmcge: Add register dump " Jijie Shao
2024-10-23 14:13 ` Andrew Lunn
2024-10-24 3:43 ` Jijie Shao
2024-10-24 12:22 ` Andrew Lunn
2024-10-24 14:44 ` Jijie Shao
2024-10-24 4:02 ` Jijie Shao
2024-10-25 9:25 ` kernel test robot
2024-10-23 13:42 ` [PATCH net-next 5/7] net: hibmcge: Add pauseparam " Jijie Shao
2024-10-23 14:15 ` Andrew Lunn [this message]
2024-10-24 3:45 ` Jijie Shao
2024-10-23 13:42 ` [PATCH net-next 6/7] net: hibmcge: Add nway_reset " Jijie Shao
2024-10-23 14:19 ` Andrew Lunn
2024-10-23 13:42 ` [PATCH net-next 7/7] net: hibmcge: Add reset " Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea2caab1-1bf9-47b3-96a8-6c1c92fbc83b@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=libaihan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shiyongbang@huawei.com \
--cc=sudongming1@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=xujunsheng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®