From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A585286889 for ; Tue, 25 Nov 2025 10:46:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764067616; cv=none; b=OlLeoy0Y1LbIv4tfdAI6Z1Ig5hFCPWKcRKNrqaHeM1PEWLSeBfxz977xfWScPrUFI3Ng08Og3seLoplEkBwrudQYSX/Ra2uwus5CadooSk+/hXuqn9hHllPsZ7JGt+tic7SU/VM7f4Us2k68AAgDuzZEugm35x923RiWNvTDiHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764067616; c=relaxed/simple; bh=Ud7pIRA4Z7Jly5QQoFb0O3a9JDsvXMxAHCyvat1w0jg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K64TtZJq4qghBHW22IjPMNgy66E3mOxx/p90BBnMgk/m6wAnAmLaniFfZHLgdxInvZkSno3LpVZF38muZ2Frym1bnuTtCeat8v7UDU73FWirV+pOZR58QtqEfz/rfz0m9DzWf80lxYI3YE++Ovoz52jULxB9AB70ko/fX+ShUXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ghL6TZui; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=oHZjatak; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ghL6TZui"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="oHZjatak" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764067613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OYAYVMsEi+5ZQ8xw/QuX6lwcbwAan3VcdA5SJfLfCOE=; b=ghL6TZuivVoTNuDCLWiN+PfQCL3hHsDiZ2/hTRI9uDm5vq5+Bnej51ctDu0or2n/8R0OGf V/VuLhxiP15uAG8xI8tEN8cozt0GZ1EQCnspVQ8VQ9qVg7YUj5cPXLeRvS6Jf3jktPABGg iJj01/3u+99dm+N/mhNXzPRl0B6Uhv0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-10-qZk2LyuUNk-VZuYWPJel5w-1; Tue, 25 Nov 2025 05:46:51 -0500 X-MC-Unique: qZk2LyuUNk-VZuYWPJel5w-1 X-Mimecast-MFC-AGG-ID: qZk2LyuUNk-VZuYWPJel5w_1764067610 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4775f51ce36so51112705e9.1 for ; Tue, 25 Nov 2025 02:46:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764067610; x=1764672410; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OYAYVMsEi+5ZQ8xw/QuX6lwcbwAan3VcdA5SJfLfCOE=; b=oHZjatakuPeV9Qp6wNj7qNB1rm6l/8BHxa84ez2rXOUc2LDeUx9HDBdPNCKB4ybKIV bmBWs1Y2Y2O6+DAYYlDz/51mm9sRItFL7bXvGNWPPDci5WEu8XQVBt9LiqEzKwCkDut6 Lmc3aK8sddHkX73etYNi8db2vBj4kYbU6p8DuWjQrLu7ehtOptml6GkCIhfCzFUb+DlM IBQdsUNcQaL0Pxg0mYVMh86+8PBoT9Sp4+6ozpTKxQXtEJOtIz9u9LnUJxeFKqYpYqLQ FFumIpWl3T8rc4Izdq77rVa3pmG/DSBmLuc++VXnrcficEbfmPoOHrQs41/seCQsh/ab SGSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764067610; x=1764672410; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OYAYVMsEi+5ZQ8xw/QuX6lwcbwAan3VcdA5SJfLfCOE=; b=GUL4Uz4kILwO4ZitQUPF0xnQwUcKSAcnXUiyxABxIvei6XH9IW3ch2+t62E5JELzpg h/69RlCkzf8nzA+WpQe6aeKTkkU1C0ylOXF9AYPVUeGRjdhX82qKtn0fj65KRi3PbtmD hB/WPPzexxobVM0bD2MQvShk2I1gSV43isEPA2S5w+GTWcNXrojyT1V+t+dQtftV/zpo MQu4nlNd+x+LAa+X8UmHO1dmVo2W7su3egNoZxj7dnrmDA7Quoa+GWc3X9g0RYzLUiGU XC3CJOP9dKai2bzRtBk0FniL94FTJk7xT9TRh8W9wtSLnr5OUYIQcfBu/wXfVufsOC5h bWOA== X-Gm-Message-State: AOJu0YyBR/HiLiyZFCWu42G3/htPygJZwJc6umNwQ0088bIyz9BbpxIK 3pG5Oar9AzjlDaHpW6LNIcPDxmb+ZE0o43H8itGa/vuq0+vksklHG4OXL+Hg+kbcoYaBjMtu4Nh d1BFID3tL2NmaUO6RpRTYcjI5X1nGu/PH/l6kR+1GQ41kvOHzw0aM7LTieTsz7HVlsQ== X-Gm-Gg: ASbGncs5j+LHtamFkr2BrKWTHmxgwTlBrK4O7J4ZVXuqSFqXE5ePS76lWDd1TZNc/EE awuQ4m4X6WLPh9VIeaWSzg6DeFjyn+SrY3SJqyhH2jx/jQj+Nv3xXdYZaNAXt/487A009mE2LYh IbIVvUWSzkuNCmAykYZlEyE1JvZdke6nJ8o0+JF6vaCFJzVFluZC2mLRzf+T/fMiW7b71OUNoMT On339WZg9vCkC89bT+OxS8W0F2b/eSR7vpdzeXKgyxTrMyBRwItonuHeO3UgQPxGTNTj9WZyOMO Tf5X9BLhsarTgQB3oNxavrRm992S4WVmIWuDr7PC+i2ImeDNO1oVTYrY3bGQFrxS+cGen+nu3zG xmpnL7q9mf43dhw== X-Received: by 2002:a05:600c:3ba4:b0:477:95a0:fe95 with SMTP id 5b1f17b1804b1-477c1123ae7mr218159445e9.24.1764067610095; Tue, 25 Nov 2025 02:46:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IEAJfWhKgd09T2car/i+8ldH3Cwh2rfeHteEUcaudCDaxCulu+WwtnB46ubUTkQ9KQ4y6UHUw== X-Received: by 2002:a05:600c:3ba4:b0:477:95a0:fe95 with SMTP id 5b1f17b1804b1-477c1123ae7mr218158975e9.24.1764067609714; Tue, 25 Nov 2025 02:46:49 -0800 (PST) Received: from [192.168.88.32] ([212.105.153.231]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fd8e54sm34315468f8f.40.2025.11.25.02.46.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Nov 2025 02:46:48 -0800 (PST) Message-ID: Date: Tue, 25 Nov 2025 11:46:46 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v07 8/9] hinic3: Add netdev notifier interfaces To: Fan Gong , Zhu Yikai , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , Andrew Lunn , Markus Elfring , Pavan Chebbi , ALOK TIWARI Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, luosifu , Xin Guo , Shen Chenyang , Zhou Shuai , Wu Like , Shi Jing , Luo Yang , Meny Yossefi , Gur Stavi References: Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/19/25 1:43 PM, Fan Gong wrote: > Add netdev notifier interfaces. > As we stipulate that netdevices with a vlan depth greater than 1 > should disable the offload feature, Layer 1 vlan netdevices use > notifier to modify vlan_features. As mentioned by Jakub in the previous revision, the net stack can send packets with multiple stacked vlans. You need to implement ndo_features_check(), check for the problematic packet layout there and ev return a smaller features check excluding the relevant offloads. > +static u16 hinic3_get_vlan_depth(struct net_device *netdev) > +{ > + u16 vlan_depth = 0; > + > +#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE) > + while (is_vlan_dev(netdev)) { > + netdev = vlan_dev_priv(netdev)->real_dev; > + vlan_depth++; > + } > +#endif > + return vlan_depth; AFAICS the above can return any number >= HINIC3_MAX_VLAN_DEPTH_OFFLOAD_SUPPORT ... > +} > + > +static int hinic3_netdev_event(struct notifier_block *notifier, > + unsigned long event, void *ptr) > +{ > + struct net_device *ndev = netdev_notifier_info_to_dev(ptr); > + struct hinic3_nic_dev *nic_dev = netdev_priv(ndev); > + u16 vlan_depth; > + > + if (!is_vlan_dev(ndev)) > + return NOTIFY_DONE; > + > + netdev_hold(ndev, &nic_dev->tracker, GFP_ATOMIC); > + > + switch (event) { > + case NETDEV_REGISTER: > + vlan_depth = hinic3_get_vlan_depth(ndev); > + if (vlan_depth == HINIC3_MAX_VLAN_DEPTH_OFFLOAD_SUPPORT) ... so here you should use '>='> + ndev->vlan_features &= (~HINIC3_VLAN_CLEAR_OFFLOAD); > + > + break; > + > + default: > + break; > + } > + > + netdev_put(ndev, &nic_dev->tracker); > + > + return NOTIFY_DONE; > +} > + > +static struct notifier_block hinic3_netdev_notifier = { > + .notifier_call = hinic3_netdev_event, > +}; > + > static void init_intr_coal_param(struct net_device *netdev) > { > struct hinic3_nic_dev *nic_dev = netdev_priv(netdev); > @@ -309,6 +364,36 @@ static int hinic3_set_default_hw_feature(struct net_device *netdev) > return 0; > } > > +static void hinic3_register_notifier(struct net_device *netdev) > +{ > + struct hinic3_nic_dev *nic_dev = netdev_priv(netdev); > + int err; > + > + mutex_lock(&hinic3_netdev_notifiers_mutex); > + hinic3_netdev_notifiers_ref_cnt++; > + if (hinic3_netdev_notifiers_ref_cnt == 1) { Why do you need this notifier accounting? Instead you should be able to call hinic3_register_notifier() only once. /P