From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F1E6C2D0A3 for ; Thu, 29 Oct 2020 07:21:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C2BF21D41 for ; Thu, 29 Oct 2020 07:21:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G4hu6+LP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726408AbgJ2HVo (ORCPT ); Thu, 29 Oct 2020 03:21:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49426 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726081AbgJ2HVJ (ORCPT ); Thu, 29 Oct 2020 03:21:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603956067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k+MySIa0GO5sAsedbOJklvkP1JxXrpHRlnL4dRpsf/4=; b=G4hu6+LPzLZiY1zNpGWejRN1iRAMp2Q2GNLdqbmT257sRo+Bf1ysqV76lin2NVdC+gC5Sh No6beNH6NsXdi/Tmmh9Ux0nYYZnj2F4Rw8fbM6NpyN+MWhCDkE15FY8CvZIP3Z7h8kTUP9 /Nafq0HQkbH7z+N7kfT/JkJvMux6zjQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194-IRYWTd8mNVSj-YtfJTgKsw-1; Thu, 29 Oct 2020 03:04:35 -0400 X-MC-Unique: IRYWTd8mNVSj-YtfJTgKsw-1 Received: by mail-wr1-f71.google.com with SMTP id n14so882941wrp.1 for ; Thu, 29 Oct 2020 00:04:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k+MySIa0GO5sAsedbOJklvkP1JxXrpHRlnL4dRpsf/4=; b=XdMs/iP0/OKb39sJOohVlKi4Clnmh6bYupM/Op1NkrhWDoAAmE+IFkB57tCtBrNJ6c MYVDclXmcvYmXHYxG/6HE0d9yJXDw8WX0kVjJX7URyV2HiQFQQNjO5jKfANiSUHejlC9 7eEUXuo7R9w7E2XGXTThIiSsR6ZfnehtB6zKHa9AKJECV0soCH2Ws+3o1yuow5I+DNwL 1Qqj9nkNnkNByqCPHrgHgmTL4CGSOjZXGfykIwW3mIetTWZlvueYYkF4/uX7F+5ZrSU9 LtmXI3vJXvcsUdD6+jh3DdPRW/pj++47jsP9eMb19NCsrU84+Hx+17XNUvYP9Ur4SUS9 LD9w== X-Gm-Message-State: AOAM532004zQXp1lDbJhJ/T+bCnsoOe6BvL/+FRGM4L9AwQmTmJPROml qWTJsMIgp1c6dP0ONbi1dp6Ba1HDJ4Zbq1Rrwiz0ZQplrwVc8wRjK0l3WZGHTHtViv4oUevjJ6E KMCB8hdEqHzBP6d7S1WAGdPuD X-Received: by 2002:adf:e4ca:: with SMTP id v10mr3780260wrm.53.1603955073915; Thu, 29 Oct 2020 00:04:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjtd7rX2GzPMeGPldc12GMpi5saPCqNeQJ2ZCa70evuRQIB96hYYOHQ+JlKqMs5entrVHldQ== X-Received: by 2002:adf:e4ca:: with SMTP id v10mr3780234wrm.53.1603955073729; Thu, 29 Oct 2020 00:04:33 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id 3sm2825527wmd.19.2020.10.29.00.04.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2020 00:04:33 -0700 (PDT) Subject: Re: [PATCH] [v2] x86: apic: avoid -Wshadow warning in header To: Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org Cc: Arnd Bergmann , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , "H. Peter Anvin" , "Rafael J. Wysocki" , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, platform-driver-x86@vger.kernel.org, xen-devel@lists.xenproject.org, iommu@lists.linux-foundation.org References: <20201028212417.3715575-1-arnd@kernel.org> From: Paolo Bonzini Message-ID: Date: Thu, 29 Oct 2020 08:04:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201028212417.3715575-1-arnd@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/10/20 22:20, Arnd Bergmann wrote: > Avoid this by renaming the global 'apic' variable to the more descriptive > 'x86_system_apic'. It was originally called 'genapic', but both that > and the current 'apic' seem to be a little overly generic for a global > variable. The 'apic' affects only the current CPU, so one of 'x86_local_apic', 'x86_lapic' or 'x86_apic' is probably preferrable. I don't have huge objections to renaming 'apic' variables and arguments in KVM to 'lapic'. I do agree with Sean however that it's going to break again very soon. Paolo