From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934765AbcHEH1F (ORCPT ); Fri, 5 Aug 2016 03:27:05 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:57995 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932153AbcHEH1C (ORCPT ); Fri, 5 Aug 2016 03:27:02 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/3] dt/bindings: arm-pl330: add description of arm,pl330-periph-burst To: Vinod Koul References: <1470365602-32586-1-git-send-email-shawn.lin@rock-chips.com> <1470365602-32586-2-git-send-email-shawn.lin@rock-chips.com> <20160805033410.GJ9681@localhost> Cc: shawn.lin@rock-chips.com, Rob Herring , Huibin Hong , Xing Zheng , devicetree@vger.kernel.org, dianders@chromium.org, briannorris@chromium.org, Caesar Wang , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org From: Shawn Lin Message-ID: Date: Fri, 5 Aug 2016 15:25:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160805033410.GJ9681@localhost> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vinod, 在 2016/8/5 11:34, Vinod Koul 写道: > On Fri, Aug 05, 2016 at 10:53:20AM +0800, Shawn Lin wrote: >> This patch adds the "arm,pl330-periph-burst" for arm-pl330 to >> support busrt mode. > > why should this be DT property. Only reason I can think of if some hw > versions support this and some won't. yes, if we want to support burst mode, both of the master(pl330) and client(several peripherals) should implement it, otherwise it will be broken when enabling. So I mentioned it on my cover letter as the reason to introduce this optional property. If people add this property and find it's ok for their platform, they could land new dt-patch to add it. But we could *not* presume that we could get all users involved in testing this patchet. I don't wanna to break any other platforms, so it's needed. Thanks. > > If all are supporting, please enable it everywhere for obvious reasons. > -- Best Regards Shawn Lin