From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Markus Elfring <Markus.Elfring@web.de>, linux-m68k@lists.linux-m68k.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Greg Ungerer <gerg@linux-m68k.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH] m68k/PCI: Fix a memory leak in an error handling path
Date: Sat, 18 Apr 2020 22:55:00 +0200 [thread overview]
Message-ID: <ea3d9b35-4409-fb86-8855-0ddb73989829@wanadoo.fr> (raw)
In-Reply-To: <2e00c1f1-8faa-5045-ddf5-2bf943f714f2@web.de>
Le 18/04/2020 à 22:00, Markus Elfring a écrit :
>> If 'ioremap' fails, we must free 'bridge', as done in other error handling
>> path bellow.
> I suggest to improve this change description.
I suggest you stop proposing over and over useless comments.
Please just ignore my proposals as I do for your boring, never
constructing, replies.
> * Please avoid a typo.
>
> * Is an imperative wording preferred?
>
* is Melissa still around?
> …
>> +++ b/arch/m68k/coldfire/pci.c
>> @@ -216,8 +216,10 @@ static int __init mcf_pci_init(void)
> …
>
> I propose to move the pci_free_host_bridge() call for the desired
I propose to let patch submitter and maintainer decide about it.
I don't need your point of view. I guess that maintainers don't either.
No need to waste time trying to engage any discussion with me.
This is the first and very last exchange we will ever have.
Best regards,
CJ
> exception handling to the end of this function implementation.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=c0d73a868d9b411bd2d0c8e5ff9d98bfa8563cb1#n450
>
> Regards,
> Markus
>
next prev parent reply other threads:[~2020-04-18 20:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 20:00 Markus Elfring
2020-04-18 20:55 ` Christophe JAILLET [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-18 7:07 Christophe JAILLET
2020-04-20 7:08 ` Geert Uytterhoeven
2020-04-21 7:12 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea3d9b35-4409-fb86-8855-0ddb73989829@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=Markus.Elfring@web.de \
--cc=bhelgaas@google.com \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®