From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
namhyung@kernel.org, ravi.bangoria@amd.com, sandipan.das@amd.com,
ananth.narayan@amd.com, gautham.shenoy@amd.com,
eranian@google.com
Subject: Re: [RFC PATCH 1/4] perf: Read cache instance ID when building cache topology
Date: Mon, 3 Apr 2023 08:13:35 +0530 [thread overview]
Message-ID: <ea3ddf8e-1809-1211-7ac4-d7175dbb4e08@amd.com> (raw)
In-Reply-To: <ZCbKCwJDf3PrjSLH@kernel.org>
Hello Arnaldo,
Thank you for taking a look at the series.
On 3/31/2023 5:24 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Mar 31, 2023 at 10:21:14AM +0530, K Prateek Nayak escreveu:
>> CPU cache level data currently stores cache level, type, line size,
>> associativity, sets, total cache size, and the CPUs sharing the cache.
>> Also read and store the cache instance ID from
>> "/sys/devices/system/cpu/cpuX/cache/indexY/id" in the cache level data.
>> Use instance ID as well when comparing cache levels.
>
> And if a new perf tool is used in an older kernel without this new 'id'
> file?
>
> Please check if the file exists, if it doesn't don't fail, just
> initialize with a zero, this way the latest perf will be usable in older
> kernels.
That makes sense. I'll handle this case as you suggested in the next
version.
>
> - Arnaldo
>
>> [..snip..]
>
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2023-04-03 2:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 4:51 [RFC PATCH 0/4] perf stat: Add option to aggregate data based on the " K Prateek Nayak
2023-03-31 4:51 ` [RFC PATCH 1/4] perf: Read cache instance ID when building " K Prateek Nayak
2023-03-31 11:54 ` Arnaldo Carvalho de Melo
2023-04-03 2:43 ` K Prateek Nayak [this message]
2023-03-31 4:51 ` [RFC PATCH 2/4] perf: Save cache instance ID when saving cache topology data K Prateek Nayak
2023-03-31 4:51 ` [RFC PATCH 3/4] perf: Extract building cache level for a CPU into separate function K Prateek Nayak
2023-03-31 4:51 ` [RFC PATCH 4/4] perf: Add option for --per-cache aggregation K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea3ddf8e-1809-1211-7ac4-d7175dbb4e08@amd.com \
--to=kprateek.nayak@amd.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=eranian@google.com \
--cc=gautham.shenoy@amd.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=sandipan.das@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®