From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2315DC77B73 for ; Sat, 6 May 2023 13:18:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232374AbjEFNSk (ORCPT ); Sat, 6 May 2023 09:18:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231956AbjEFNSf (ORCPT ); Sat, 6 May 2023 09:18:35 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 433C81CFC1; Sat, 6 May 2023 06:18:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=copZqT4Awq3JwFogujKYu6Qa/kRT3sXtwa10VzFrQvY=; b=2tldN4awosLIqOjCnZf2PjXhX9 PWeflNPxop0MlRw+lJxVriLGxYmbxqNy5Q4lfN16rlw61echF1/7/RNaZuGDh7Q9BGh5j+l1LdBDr lKcIrLap1x272E+VwU11eEoKthzAAl5bamizgCKZ4VnIAmhY8FFaJjhN6Zy2s8yAIXM4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pvHnm-00C4D0-JH; Sat, 06 May 2023 15:18:18 +0200 Date: Sat, 6 May 2023 15:18:18 +0200 From: Andrew Lunn To: Christophe JAILLET Cc: Tobias Waldekranz , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Florian Fainelli , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net] net: mdio: mvusb: Fix an error handling path in mvusb_mdio_probe() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 05, 2023 at 08:39:33PM +0200, Christophe JAILLET wrote: > Should of_mdiobus_register() fail, a previous usb_get_dev() call should be > undone as in the .disconnect function. > > Fixes: 04e37d92fbed ("net: phy: add marvell usb to mdio controller") > Signed-off-by: Christophe JAILLET Reviewed-by: Andrew Lunn Andrew