mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Mehmet Fide <mehmet.fide@gmail.com>
Cc: "luka.gejak@linux.dev" <luka.gejak@linux.dev>,
	"rtl8821cerfe2@gmail.com" <rtl8821cerfe2@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mehmet.fide@screeningeagle.com" <mehmet.fide@screeningeagle.com>
Subject: RE: [PATCH rtw-next v4 2/2] wifi: rtw88: support channel switch in AP mode
Date: Wed, 7 Oct 2026 08:17:25 +0000	[thread overview]
Message-ID: <ea472899e65e4140990b15603e23d0ee@realtek.com> (raw)
In-Reply-To: <20261007080930.2473263-1-mehmet.fide@gmail.com>

Mehmet Fide <mehmet.fide@gmail.com> wrote:
> On 2026-10-07 Ping-Ke Shih wrote:
> > > -                       rtw_fw_download_rsvd_page(rtwdev);
> > > -                       rtw_send_rsvd_page_h2c(rtwdev);
> > > +                       if (!rtw_fw_csa_active(rtwdev)) {
> >
> > Does it actually happen to AP mode?
> >
> > If it could happen, check the condition by conf->csa_active (like below)?
> 
> Not for the AP interface: mac80211 raises BSS_CHANGED_ASSOC for a
> station interface only. The hunk is for the STA+AP combination the
> driver registers for the 8822C, and it does happen there: with an AP
> on an RTL8822CU counting down from channel 6 to 11, a station interface
> on the same device that had a fresh scan result associated with an AP
> on channel 11 while the countdown ran, so BSS_CHANGED_ASSOC arrived in
> the middle of it. That download would rebuild the reserved page with a
> fresh beacon. conf belongs to the station there, so conf->csa_active
> would say nothing about the AP; that is why the check is on
> rtwdev->csa_vif.

Got it. Add a comment to point out "STA+AP combination" then.

And, agree with your other reply. 

Ping-Ke


      reply	other threads:[~2026-10-07  8:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07  6:11 [PATCH rtw-next v4 0/2] wifi: rtw88: " Mehmet Fide
2026-10-07  6:11 ` [PATCH rtw-next v4 1/2] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
2026-10-07  6:11 ` [PATCH rtw-next v4 2/2] wifi: rtw88: support channel switch in AP mode Mehmet Fide
2026-10-07  6:39   ` Ping-Ke Shih
2026-10-07  8:09     ` Mehmet Fide
2026-10-07  8:17       ` Ping-Ke Shih [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea472899e65e4140990b15603e23d0ee@realtek.com \
    --to=pkshih@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luka.gejak@linux.dev \
    --cc=mehmet.fide@gmail.com \
    --cc=mehmet.fide@screeningeagle.com \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®