mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Chi-Hsien.Lin@infineon.com>
To: <zhangchangzhong@huawei.com>, <arend.vanspriel@broadcom.com>,
	<franky.lin@broadcom.com>, <hante.meuleman@broadcom.com>,
	<Wright.Feng@infineon.com>, <kvalo@codeaurora.org>,
	<davem@davemloft.net>, <kuba@kernel.org>,
	<Chung-Hsien.Hsu@infineon.com>
Cc: <linux-wireless@vger.kernel.org>,
	<brcm80211-dev-list.pdl@broadcom.com>,
	<brcm80211-dev-list@cypress.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] brcmfmac: fix error return code in brcmf_cfg80211_connect()
Date: Fri, 13 Nov 2020 08:45:50 +0000	[thread overview]
Message-ID: <ea4b55d801ed418f9b0430ddba559457@infineon.com> (raw)
In-Reply-To: <1605248896-16812-1-git-send-email-zhangchangzhong@huawei.com>

> Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in th>
>
> Fixes: 3b1e0a7bdfee ("brcmfmac: add support for SAE authentication offload")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Reviewed-by: Chi-hsien Lin <chi-hsien.lin@infineon.com>

> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadc>
> index a2dbbb9..0ee421f 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -2137,7 +2137,8 @@ brcmf_cfg80211_connect(struct wiphy *wiphy, struct net_device *ndev,
>               BRCMF_WSEC_MAX_PSK_LEN);
>     else if (profile->use_fwsup == BRCMF_PROFILE_FWSUP_SAE) {
>       /* clean up user-space RSNE */
> -             if (brcmf_fil_iovar_data_set(ifp, "wpaie", NULL, 0)) {
> +             err = brcmf_fil_iovar_data_set(ifp, "wpaie", NULL, 0);
> +             if (err) {
>                       bphy_err(drvr, "failed to clean up user-space RSNE\n");
>                       goto done;
> }
> --
> 2.9.5

  reply	other threads:[~2020-11-13  8:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13  6:28 Zhang Changzhong
2020-11-13  8:45 ` Chi-Hsien.Lin [this message]
2020-11-24 15:00 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea4b55d801ed418f9b0430ddba559457@infineon.com \
    --to=chi-hsien.lin@infineon.com \
    --cc=Chung-Hsien.Hsu@infineon.com \
    --cc=Wright.Feng@infineon.com \
    --cc=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211-dev-list@cypress.com \
    --cc=davem@davemloft.net \
    --cc=franky.lin@broadcom.com \
    --cc=hante.meuleman@broadcom.com \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=zhangchangzhong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®