From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED5D5C432C0 for ; Tue, 3 Dec 2019 08:56:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7BC620661 for ; Tue, 3 Dec 2019 08:56:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726251AbfLCI4w (ORCPT ); Tue, 3 Dec 2019 03:56:52 -0500 Received: from smtprelay0117.hostedemail.com ([216.40.44.117]:37562 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725773AbfLCI4w (ORCPT ); Tue, 3 Dec 2019 03:56:52 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id A8A5718037C64; Tue, 3 Dec 2019 08:56:50 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: taste11_3b9cb87ae0b31 X-Filterd-Recvd-Size: 2898 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA; Tue, 3 Dec 2019 08:56:49 +0000 (UTC) Message-ID: Subject: Re: [PATCH] checkpatch: Look for Kconfig indentation errors From: Joe Perches To: Krzysztof Kozlowski Cc: Jani Nikula , Andy Whitcroft , "linux-kernel@vger.kernel.org" , Pierre-Louis Bossart Date: Tue, 03 Dec 2019 00:56:16 -0800 In-Reply-To: References: <1574906800-19901-1-git-send-email-krzk@kernel.org> <87a78gnyaz.fsf@intel.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-12-03 at 16:40 +0800, Krzysztof Kozlowski wrote: > On Thu, 28 Nov 2019 at 17:35, Joe Perches wrote: > > On Thu, 2019-11-28 at 11:29 +0200, Jani Nikula wrote: > > > On Thu, 28 Nov 2019, Krzysztof Kozlowski wrote: > > > > Kconfig should be indented with one tab for first level and tab+2 spaces > > > > for second level. There are many mixups of this so add a checkpatch > > > > rule. > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > > I agree unifying the indentation is nice, and without something like > > > this it'll start bitrotting before Krzysztof's done fixing them all... I > > > think there's been quite a few fixes merged lately. > > > > > > I approve of the idea, but I'm clueless about the implementation. > > > > I think that a grammar, or a least an array of words > > that are supposed to start on a tab should be used here. > > This won't work for wrong indentation of help text. This is quite > popular Kconfig indentation violation so worth checking. I can then > check for: > 1. any white-space violations before array of Kconfig words - that > 2. spaces mixed with tab before any text, > 3. just spaces before any text, > 4. tab + wrong number of spaces before any text. > > It would look like: > + if ($realfile =~ /Kconfig/ && > + (($rawline =~ > /^\+\s+(?:config|menuconfig|choice|endchoice|if|endif|menu|endmenu|source|bool|tristate|prompt|help|---help---|depends|select)\b/ Many of these are not correct. config, menuconfig, choice, endchoice, source are primarily used at the beginning of a line. if is odd as it's a logical block or test It really needs a lex grammar to work properly.