mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Constantine Sapuntzakis" <csapuntz@gmail.com>
To: "Jens Axboe" <axboe@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] loop.c: respect bio barrier and sync
Date: Fri, 5 May 2006 15:37:08 -0700	[thread overview]
Message-ID: <ea59786f0605051537o65338d7dr1f842927047494d5@mail.gmail.com> (raw)
In-Reply-To: <20060505145437.GW4324@suse.de>

Sorry about the patch as attachments.

> - You should handle sync_file() failure. If we don't have !f_op (will
>   that ever hit, btw?) or ->fsync(), then fail the barrier with
>   -EOPNOTSUPP. For fsync failure, well... You probably want to just
>   error the bio with -EIO then.

Will fix.

> - Does this work for all loop_device types?

What are the other loop_device types?

BTW, should/does an fsync on a block device translate into a disk flush?
I was looking at sync_blockdev and couldn't figure out how that happened.

Thanks,
-Costa

      reply	other threads:[~2006-05-05 22:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-05  2:19 Constantine Sapuntzakis
2006-05-05 14:54 ` Jens Axboe
2006-05-05 22:37   ` Constantine Sapuntzakis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea59786f0605051537o65338d7dr1f842927047494d5@mail.gmail.com \
    --to=csapuntz@gmail.com \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®