mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Malladi, Meghana" <m-malladi@ti.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Roger Quadros" <rogerq@kernel.org>,
	"Siddharth Vadapalli" <s-vadapalli@ti.com>,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Jesper Dangaard Brouer" <hawk@kernel.org>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Christian König" <christian.koenig@amd.com>,
	srk@ti.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org, linux-media@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [EXTERNAL] Re: [PATCH RFC net-next 0/5] net: ethernet: ti: am65-cpsw: add AF_XDP zero copy support
Date: Mon, 14 Jul 2025 21:18:27 +0530	[thread overview]
Message-ID: <ea631e0e-9cf7-4fae-820a-43013adcd1ec@ti.com> (raw)
In-Reply-To: <20250714080629.29aa7a2d@kernel.org>

Hi Jakub,

Sorry for the duplicate mail.

On 7/14/2025 8:36 PM, Jakub Kicinski wrote:
> On Mon, 14 Jul 2025 14: 50: 05 +0530 Malladi, Meghana wrote: > > AF_XDP 
> performance using 64 byte packets in Kpps. > > Benchmark: XDP-SKB XDP- 
> Native XDP-Native(ZeroCopy) > > rxdrop 317 504 824 > > txonly 400 405 757 >
> ZjQcmQRYFpfptBannerStart
> This message was sent from outside of Texas Instruments.
> Do not click links or open attachments unless you recognize the source 
> of this email and know the content is safe.
> Report Suspicious
> <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK! 
> uDdqXRfP1m37CoZlPNNDnQgOintsvKy- 
> cENuCwB1b5Qxa66rT1SFJDmyny6jsjalW7Wur6ukCSGrdQ$>
> ZjQcmQRYFpfptBannerEnd
> 
> On Mon, 14 Jul 2025 14:50:05 +0530 Malladi, Meghana wrote:
>> > AF_XDP performance using 64 byte packets in Kpps.
>> > Benchmark:	XDP-SKB		XDP-Native	XDP-Native(ZeroCopy)
>> > rxdrop		317		504		824
>> > txonly		400		405		757
>> > l2fwd 		207		264		0
>> > 
>> > AF_XDP performance using 1500 byte packets in Kpps.
>> > Benchmark:	XDP-SKB		XDP-Native	XDP-Native(ZeroCopy)
>> > rxdrop		82		82		82
>> > txonly		82		82		82
>> > l2fwd 		82		82		82
>> > 
>> > [1]: https://urldefense.com/v3/__https://github.com/xdp-project/bpf-examples/ 
> tree/master/AF_XDP-example__;!!G3vK!Sv1p-bFPBDlzD-YMO2sjo- 
> X2gv3CW5uHD_O771StRVzMR8Vr75k7tTGQJ27MRy_fz3d9m40aZg$ <https://urldefense.com/v3/__https://github.com/xdp-project/bpf-examples/tree/master/AF_XDP-example__;!!G3vK!Sv1p-bFPBDlzD-YMO2sjo-X2gv3CW5uHD_O771StRVzMR8Vr75k7tTGQJ27MRy_fz3d9m40aZg$>
>> > 
>> > To:
>> > 
>> > Signed-off-by: Roger Quadros <rogerq@kernel.org>  
>> 
>> This series crashes Linux on am64xx-hsevm, when I tried nfs boot using 
>> AM65-CPSW-NUSS driver:
>> logs: 
>> https://urldefense.com/v3/__https://gist.github.com/MeghanaMalladiTI/ 
> d655a1c8ca88113ee7f5f57d6ab0ec4c__;!!G3vK!Sv1p-bFPBDlzD-YMO2sjo- 
> X2gv3CW5uHD_O771StRVzMR8Vr75k7tTGQJ27MRy_fz3ecuWN_dw$ <https://urldefense.com/v3/__https://gist.github.com/MeghanaMalladiTI/d655a1c8ca88113ee7f5f57d6ab0ec4c__;!!G3vK!Sv1p-bFPBDlzD-YMO2sjo-X2gv3CW5uHD_O771StRVzMR8Vr75k7tTGQJ27MRy_fz3ecuWN_dw$>
>> 
>> Seems like you have reverted the fix for the same bug which was reported 
>> by Siddharth and fixed by Julien: 
>> https://urldefense.com/v3/__https://lore.kernel.org/ 
> all/7f7fb71a-6d15-46f1-b63c-b569a2e230b7@baylibre.com/__;!!G3vK!Sv1p- 
> bFPBDlzD-YMO2sjo-X2gv3CW5uHD_O771StRVzMR8Vr75k7tTGQJ27MRy_fz3exh7VnCw$ <https://urldefense.com/v3/__https://lore.kernel.org/all/7f7fb71a-6d15-46f1-b63c-b569a2e230b7@baylibre.com/__;!!G3vK!Sv1p-bFPBDlzD-YMO2sjo-X2gv3CW5uHD_O771StRVzMR8Vr75k7tTGQJ27MRy_fz3exh7VnCw$>
>> 
>> reverted lines:
>> 		if (!common->ports[port].ndev)
>> 		/* FIXME should we BUG here? */
>> 			continue;
>> 
>> Can you please take a look at it.
> 
> Just to be clear -- you're reporting this problem to Roger so that its
> fixed before the series is reposted? I don't see this in the tree, I
> wanted to make sure it's not something I need to track as a regression.
> 

Yes you are right. This isn't a regression, I reported this as part of 
my testing for this RFC patch series.

-- 
Thanks,
Meghana Malladi


      reply	other threads:[~2025-07-14 15:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-20 10:23 Roger Quadros
2025-05-20 10:23 ` [PATCH RFC net-next 1/5] net: ethernet: ti: am65-cpsw: fix BPF Program change on multi-port CPSW Roger Quadros
2025-05-20 10:23 ` [PATCH RFC net-next 2/5] net: ethernet: ti: am65-cpsw: add XSK pool helpers Roger Quadros
2025-05-20 10:23 ` [PATCH RFC net-next 3/5] net: ethernet: ti: am65-cpsw: Add AF_XDP zero copy for RX Roger Quadros
2025-05-20 10:23 ` [PATCH RFC net-next 4/5] net: ethernet: ti: am65-cpsw: Add AF_XDP zero copy for TX Roger Quadros
2025-05-20 10:23 ` [PATCH RFC net-next 5/5] net: ethernet: ti: am65-cpsw: enable zero copy in XDP features Roger Quadros
2025-07-14  9:20 ` [PATCH RFC net-next 0/5] net: ethernet: ti: am65-cpsw: add AF_XDP zero copy support Malladi, Meghana
2025-07-14 15:06   ` Jakub Kicinski
2025-07-14 15:48     ` Malladi, Meghana [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea631e0e-9cf7-4fae-820a-43013adcd1ec@ti.com \
    --to=m-malladi@ti.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rogerq@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=srk@ti.com \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®