From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: pgonda@google.com, seanjc@google.com,
Marc Orr <marcorr@google.com>,
David Rientjes <rientjes@google.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 4/7] KVM: SEV: Add support for SEV intra host migration
Date: Fri, 12 Nov 2021 10:35:23 +0100 [thread overview]
Message-ID: <ea64e454-17c3-374b-67a1-f382cdf6c6a6@redhat.com> (raw)
In-Reply-To: <20211111154930.3603189-5-pbonzini@redhat.com>
On 11/11/21 16:49, Paolo Bonzini wrote:
> +out_dst_cgroup:
> + if (ret < 0) {
> + sev_misc_cg_uncharge(dst_sev);
> +out_dst_put_cgroup:
> + put_misc_cg(dst_sev->misc_cg);
> + dst_sev->misc_cg = NULL;
> + }
Wrong (you must not uncharge if the dst_sev and src_sev cgroup are the
same) _and_ unnecessarily complicated.
I'll send an 8/7 patch as a fixup.
Paolo
next prev parent reply other threads:[~2021-11-12 9:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 15:49 [PATCH v12 0/7] Add AMD SEV and SEV-ES intra host migration support Paolo Bonzini
2021-11-11 15:49 ` [PATCH 1/7] KVM: SEV: Refactor out sev_es_state struct Paolo Bonzini
2021-11-11 15:49 ` [PATCH 2/7] KVM: generalize "bugged" VM to "dead" VM Paolo Bonzini
2021-11-11 15:49 ` [PATCH 3/7] KVM: SEV: provide helpers to charge/uncharge misc_cg Paolo Bonzini
2021-11-11 15:49 ` [PATCH 4/7] KVM: SEV: Add support for SEV intra host migration Paolo Bonzini
2021-11-12 9:35 ` Paolo Bonzini [this message]
2021-11-11 15:49 ` [PATCH 5/7] KVM: SEV: Add support for SEV-ES " Paolo Bonzini
2021-11-11 15:49 ` [PATCH 6/7] selftest: KVM: Add open sev dev helper Paolo Bonzini
2021-11-11 15:49 ` [PATCH 7/7] selftest: KVM: Add intra host migration tests Paolo Bonzini
2021-11-12 9:40 ` [PATCH 8/7] KVM: SEV: unify cgroup cleanup code for svm_vm_migrate_from Paolo Bonzini
2021-11-12 23:12 ` [PATCH v12 0/7] Add AMD SEV and SEV-ES intra host migration support Peter Gonda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea64e454-17c3-374b-67a1-f382cdf6c6a6@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=dgilbert@redhat.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcorr@google.com \
--cc=mingo@redhat.com \
--cc=pgonda@google.com \
--cc=rientjes@google.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®