From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 896AE38F254 for ; Mon, 2 Mar 2026 09:28:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772443725; cv=none; b=W4pGNaVBvH7CjwdLR+cFSkwRNsJcBP3ZdVpNlOLx5jxidCGY72GmsDrYZwldR3Cc6ZamU3iEx7Ck6CAwVkRUYFVeJnnNLt5U4G+N25HN3LoLRwCQeSAWnwWuFTOY5DOJaDAxisw4sNR9VZR6+MBRWfGpJjBheipLac42Ag+XxkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772443725; c=relaxed/simple; bh=283ITlUTpw+pnnWf8GlTk3ilsVM0BLNnI2fU0ZTZpAs=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=JHhmhjLjzVlx1L4FTWqey5TNUpyvH+lnojlU7Co4Ktb1Oz65Lq1cP4wnTlFYc+sLUav+3SsJc9sTpBWpPUKeS+YFM7J9oJ7NKdERG5y5W7vHsq7r0HYGlCpuL5ZppsAEsvuagvTzYbSqYGQLw2++3OBjxhaOrq0bqQl5TbWTeCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GoRcKCM7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HAQXKj1L; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GoRcKCM7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HAQXKj1L" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6229ErX23630818 for ; Mon, 2 Mar 2026 09:28:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ht8a1jegW8k/H9PVxZasCwKoJs5NEx57HRzB+8Y1KVo=; b=GoRcKCM7831kuUhp I5iRKWUanqqzJFpMCKE4KqTqTkEiVQz8Oq4LpbM+OJtjJu9kqs+IqAq+aMB4u47h irngferz5Ea6YPaLiPrYNznw33L33vSJhrzYPzWFkAcWTSi43pfFnMj2s6KhKyPB VaJFxFU+CEoQpoGlVu9xQ6d8wyLzyjfL8WNDzUd1Z21CpgxFbFWwSmdso+1T8QZJ 5syQ7xhsSAhJkuQ1stVjxQO1+8H5+EmoE/hiGDAiXU5FeyMPvf9MYsLRUeK0utc+ ukYtUiRDUWhz0cYj82yh5zEG2xquF1tBGfaV3z07jNuGyAOIrFpU36Obt8ozCa0P Af823Q== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cn7rhr1tj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 09:28:42 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35982c5940cso1055364a91.1 for ; Mon, 02 Mar 2026 01:28:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772443721; x=1773048521; darn=vger.kernel.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=ht8a1jegW8k/H9PVxZasCwKoJs5NEx57HRzB+8Y1KVo=; b=HAQXKj1LZOf/bkOBpFO8RSxF3p1pu8TmGDm3kL12okUxlmnuF80uTwxY2M5gKNvY0X +pVhCJrmkADX04+Hk9zFILjk432uE2clk2fLiIxm9aYviPcHwKkshsA0gmsqwDoQHzVU d434cJmCi+Q53psdcOUMmIn7CNK+JqXcesvuKJTUIal/F8uxD2F7O/4heqsXdoTguPpc FjVoqL7a/C8gU/Lzz4p9KJHgesp5CUnBxfxlBbcpyeSX8xRmeF4a2QKNMJWFEJY77Hau vbcolF4tK6+p+S00PBsIoeXuwpN9aQGKqWnuCQA3siucghQdNsEMkYuHJiLrX/MDVRIH Yapg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772443721; x=1773048521; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ht8a1jegW8k/H9PVxZasCwKoJs5NEx57HRzB+8Y1KVo=; b=rKJEoxFqLW3t78p0dxvJx6P1u7FoELxpbyC+Xfzbp3zDEjiz6IdlwA6CSPu7oYhDR/ BH1rW2eciiuvHFQqYFBKPVTKx5b7ydWRVaWrY7Ylt5q1ktNwOLsglBEu/LqTRzsZN0nE X85zZhzoAiTcKRpT6pdsCC9W7/Kdlp7iDCRObcUJyW0DJTcP3sSnBntiHLvzSP05KbhQ FQEzpmtT9oNd4jkKCdog9KBcU/g90xKxPwVrBltHRrLZh8WSEkETFv7/plmV8vwBNsAF NM2ACTsjZ8wjGxLfNi+qD8HW2hapxfnSLPXHU5q3vwrbSxnKyk8tJhaz+OVEDbaGiPrc E39g== X-Forwarded-Encrypted: i=1; AJvYcCW7iHRW6Tgaq+e8NdhKMFjhb2dQQQqgGTxC9Nc5erzd4BTc7dB5MVQ99rty585lc71h4zrg2fJ2ND/+DGo=@vger.kernel.org X-Gm-Message-State: AOJu0Yxk/t33ErKMDDIGq2E1DChc+5xIApDu+hxAzfWciz1Lj319u/4V ISCkGbJX6a3QpdBcuz6TP4yeGGWtjqA6Sj7e58ZXkGaTn9/nODNgzOmsYCxJsb8yG7oAXm6rbY4 7AXkqciX0fvZRDwkv1p1GeYLZLgB16XrL4j7Zvab6nbw52TjXb/efFP9hUZZBrxf97cs= X-Gm-Gg: ATEYQzwbZP+6aDjQxoXEMpJfgLF3CMOanRfn/Rf9cjHZQ4KlPiwtAJNSwEgkm0fkMar 27zPVVZiy2T7u0NePzKUXnQxcQU/8B9F1dXR7RAYKwoR9zQ2L46kYZ8UK9m89bV2xZjGXaGBKle xl24UaiRtDG0XL55TLtjR/AmfqO+zsdbJAkRZuDNl5dDRNPz9bKfVwHctovMUqpJIfZdL2JA2y5 NfWztDpnSUCmX4WiZ8gvN+5RhNKj4mIpfLVLTG4tOrR5vH5NQPrz10DLHvvl+SaXlHpMAZH4VqW uWtATmLCeMgYAcdDf7uZKrlfN8NOrWH2Adve7XYe/8KV2by/bHSp8U2O//rtUoH+5kJC99c6AwK LMgItQ0Q0GAK8ZnsaskY0TcaJimotEmHEYNhV/hb6wFHdworIYQ== X-Received: by 2002:a17:90a:fc4d:b0:33b:bed8:891c with SMTP id 98e67ed59e1d1-35965cc9d6amr10190634a91.23.1772443721266; Mon, 02 Mar 2026 01:28:41 -0800 (PST) X-Received: by 2002:a17:90a:fc4d:b0:33b:bed8:891c with SMTP id 98e67ed59e1d1-35965cc9d6amr10190617a91.23.1772443720773; Mon, 02 Mar 2026 01:28:40 -0800 (PST) Received: from [10.217.222.63] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3597dfea2e7sm6307474a91.12.2026.03.02.01.28.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 01:28:40 -0800 (PST) Subject: Re: [PATCH v3 1/4] soc: qcom: ice: Fix race between qcom_ice_probe() and of_qcom_ice_get() To: Manivannan Sadhasivam , Bjorn Andersson Cc: manivannan.sadhasivam@oss.qualcomm.com, Konrad Dybcio , Adrian Hunter , Ulf Hansson , "James E.J. Bottomley" , "Martin K. Petersen" , Abel Vesa , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org, Sumit Garg , stable@vger.kernel.org References: <20260223-qcom-ice-fix-v3-0-6ca5846329f7@oss.qualcomm.com> <20260223-qcom-ice-fix-v3-1-6ca5846329f7@oss.qualcomm.com> From: Neeraj Soni Message-ID: Date: Mon, 2 Mar 2026 14:58:34 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 00Hr1_VMFEzuDWKP6-uKwtP4xbt7q_W0 X-Proofpoint-GUID: 00Hr1_VMFEzuDWKP6-uKwtP4xbt7q_W0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDA3OSBTYWx0ZWRfX4H39JiuA63Zg VGbMXNL6uI4kITPMR4yC96t3ujZhQ8LmMSizLYY3nsf3QLpoVvhvxrxwpRtRjiG3QgN72QT89x1 35I6/J673Y2I4pe9P3CCvB9HECP95O4KjP6IyWMm/NvjjYdS75psoSQvcFZa4pAb6gpf8vwupqE LAG0SXmTOhawjuGTv0w12BQYg+8olW96QuBY+S3kdI3ggYtwBg5jWLTaRC6lNBhv/UMjyhoGow8 6+hf1ORAwMT5+4UrWDSTeiyR8FcNQbhN2iVrJ7S9HLuKvf+CTEhZdCUaYQSRWLe48oWIn5o4a61 c3SnCENXdI3Ypvrl9on4nKLWxeBshr3lUpIGYhzNukFNz7T7MKuJn3j9ZvFQOiSuOx+Z6YpISm+ LMriUmVG5ZygZvSQ0yrkqXMpAVU4UwNCl/ZZncEaJTWUWCzma6Um9ZyKNdf4j48YNKz3DwfuBPh cVT2hh644eEH9UTjrBw== X-Authority-Analysis: v=2.4 cv=cLntc1eN c=1 sm=1 tr=0 ts=69a5584a cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=xC54U6B0g8_6vy67BIAA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_02,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020079 On 2/24/2026 10:16 AM, Manivannan Sadhasivam wrote: > + Neeraj > > On Mon, Feb 23, 2026 at 02:35:04PM -0600, Bjorn Andersson wrote: >> On Mon, Feb 23, 2026 at 01:32:52PM +0530, Manivannan Sadhasivam via B4 Relay wrote: >>> From: Manivannan Sadhasivam >>> >>> The current platform driver design causes probe ordering races with >>> consumers (UFS, eMMC) due to ICE's dependency on SCM firmware calls. If ICE >>> probe fails (missing ICE SCM or DT registers), devm_of_qcom_ice_get() loops >>> with -EPROBE_DEFER, leaving consumers non-functional even when ICE should >>> be gracefully disabled. devm_of_qcom_ice_get() doesn't know if the ICE >>> driver probe has failed due to above reasons or it is waiting for the SCM >>> driver. >>> >>> Moreover, there is no devlink dependency between ICE and consumer drivers >>> as 'qcom,ice' is not considered as a DT 'supplier'. So the consumer drivers >>> have no idea of when the ICE driver is going to probe. >>> >>> To address these issues, introduce a global ice_handle to store the valid >>> ICE handle pointer, and set during successful ICE driver probe. On probe >>> failure, set it to an error pointer and propagate the error from >>> of_qcom_ice_get(). >>> >>> Additionally, add a global ice_mutex to synchronize qcom_ice_probe() and >>> of_qcom_ice_get(). >>> >>> Note that this change only fixes the standalone ICE DT node bindings and >>> not the ones with 'ice' range embedded in the consumer nodes, where there >>> is no issue. >>> >>> Cc: # 6.4 >>> Fixes: 2afbf43a4aec ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver") >>> Reported-by: Sumit Garg >>> Signed-off-by: Manivannan Sadhasivam >>> --- >>> drivers/soc/qcom/ice.c | 44 +++++++++++++++++++++++++++----------------- >>> 1 file changed, 27 insertions(+), 17 deletions(-) >>> >>> diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c >>> index b203bc685cad..3c3c189e24f9 100644 >>> --- a/drivers/soc/qcom/ice.c >>> +++ b/drivers/soc/qcom/ice.c >>> @@ -113,6 +113,9 @@ struct qcom_ice { >>> u8 hwkm_version; >>> }; >>> >>> +static DEFINE_MUTEX(ice_mutex); >>> +static struct qcom_ice *ice_handle; >> >> Did we get confirmation that in the UFS + SDCC case, there's only a >> single ICE instance per SoC? >> > > Right now there is only a single instance per SoC. But Neeraj told me that > upcoming SoCs are going to have multiple instances. But I don't want to spend Yes and patches for same are under review here: https://lore.kernel.org/all/20260217052526.2335759-1-neeraj.soni@oss.qualcomm.com/ > too much time on *upcoming* support, but rather fix the current > implementations. > > Extending this to multiple instances would just require storing the ice_handle > with node name/address pair in xarray or in some other data structures. > > - Mani >