mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"pawel.moll@arm.com" <pawel.moll@arm.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
	"galak@codeaurora.org" <galak@codeaurora.org>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/4] ARM: dts: Enable SAI ALSA SoC DAI device for Vybrid VF610 TOWER board.
Date: Wed, 19 Feb 2014 07:25:43 +0000	[thread overview]
Message-ID: <ea66b1869211439f96598b54e24e282a@BY2PR03MB505.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20140219070630.GE3010@S2101-09.ap.freescale.net>


> > @@ -127,9 +127,27 @@
> >  				VF610_PAD_PTB5__UART1_RX		0x21a1
> >  			>;
> >  		};
> > +
> > +		pinctrl_sai2: sai2grp {
> 
> To sort it alphabetically, the entry should be added before
> pinctrl_uart1.
> 
> > +		      fsl,pins = <
> > +			      VF610_PAD_PTA16__SAI2_TX_BCLK   0x02ed
> > +			      VF610_PAD_PTA18__SAI2_TX_DATA   0x02ee
> > +			      VF610_PAD_PTA19__SAI2_TX_SYNC   0x02ed
> > +			      VF610_PAD_PTA21__SAI2_RX_BCLK   0x02ed
> > +			      VF610_PAD_PTA22__SAI2_RX_DATA   0x02ed
> > +			      VF610_PAD_PTA23__SAI2_RX_SYNC   0x02ed
> > +			      VF610_PAD_PTB18__EXT_AUDIO_MCLK 0x02ed
> 
> Use tabs instead of spaces.
> 
> Shawn
> 

Yes, I'll fix these two issues above.

Thanks,

--
Best Regards,
Xiubo


  reply	other threads:[~2014-02-19  7:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-19  5:38 [PATCH 0/4] Add audio card support for Vybird-TWR board Xiubo Li
2014-02-19  5:38 ` [PATCH 1/4] ARM: dts: Add Freescale SAI ALSA SoC Digital Audio Interface node for VF610 Xiubo Li
2014-02-19  7:07   ` Shawn Guo
2014-02-19  7:26     ` Li.Xiubo
2014-02-19  5:38 ` [PATCH 2/4] ARM: dts: Enable SAI ALSA SoC DAI device for Vybrid VF610 TOWER board Xiubo Li
2014-02-19  7:06   ` Shawn Guo
2014-02-19  7:25     ` Li.Xiubo [this message]
2014-02-19  7:11   ` Shawn Guo
2014-02-19  7:28     ` Li.Xiubo
2014-02-19  5:38 ` [PATCH 3/4] ARM: dts: Enable SGTL5000 codec based audio driver node for VF610 TOWER Xiubo Li
2014-02-19  7:13   ` Shawn Guo
2014-02-19  5:38 ` [PATCH 4/4] ARM: dts: Add simple-card support for Vybird-TWR board Xiubo Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea66b1869211439f96598b54e24e282a@BY2PR03MB505.namprd03.prod.outlook.com \
    --to=li.xiubo@freescale.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®