From: "Christian König" <christian.koenig@amd.com>
To: Julia Lawall <Julia.Lawall@inria.fr>,
Alex Deucher <alexander.deucher@amd.com>
Cc: kernel-janitors@vger.kernel.org, Xinhui Pan <Xinhui.Pan@amd.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 29/35] drivers/gpu/drm: Reorganize kerneldoc parameter names
Date: Mon, 30 Sep 2024 13:22:52 +0200 [thread overview]
Message-ID: <ea6868b2-ea0e-42ad-8351-c02553691b74@amd.com> (raw)
In-Reply-To: <20240930112121.95324-30-Julia.Lawall@inria.fr>
Am 30.09.24 um 13:21 schrieb Julia Lawall:
> Reorganize kerneldoc parameter names to match the parameter
> order in the function header.
Please split that up by driver, apart from that looks good to me.
Christian.
>
> Problems identified using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
> drivers/gpu/drm/radeon/radeon_ib.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 6005280f5f38..ad4fdd4d4d82 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -2773,11 +2773,11 @@ int amdgpu_vm_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
> * amdgpu_vm_handle_fault - graceful handling of VM faults.
> * @adev: amdgpu device pointer
> * @pasid: PASID of the VM
> - * @ts: Timestamp of the fault
> * @vmid: VMID, only used for GFX 9.4.3.
> * @node_id: Node_id received in IH cookie. Only applicable for
> * GFX 9.4.3.
> * @addr: Address of the fault
> + * @ts: Timestamp of the fault
> * @write_fault: true is write fault, false is read fault
> *
> * Try to gracefully handle a VM fault. Return true if the fault was handled and
> diff --git a/drivers/gpu/drm/radeon/radeon_ib.c b/drivers/gpu/drm/radeon/radeon_ib.c
> index 1aa41cc3f991..8611a27dfb3d 100644
> --- a/drivers/gpu/drm/radeon/radeon_ib.c
> +++ b/drivers/gpu/drm/radeon/radeon_ib.c
> @@ -49,8 +49,8 @@ static void radeon_debugfs_sa_init(struct radeon_device *rdev);
> *
> * @rdev: radeon_device pointer
> * @ring: ring index the IB is associated with
> - * @vm: requested vm
> * @ib: IB object returned
> + * @vm: requested vm
> * @size: requested IB size
> *
> * Request an IB (all asics). IBs are allocated using the
>
next prev parent reply other threads:[~2024-09-30 11:23 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 11:20 [PATCH 00/35] " Julia Lawall
2024-09-30 11:20 ` [PATCH 01/35] ARM: OMAP2/3: PRM: " Julia Lawall
2024-09-30 14:07 ` Roger Quadros
2024-10-04 21:02 ` Kevin Hilman
2024-09-30 11:20 ` [PATCH 02/35] resource: " Julia Lawall
2024-09-30 11:20 ` [PATCH 03/35] bnxt_en: " Julia Lawall
2024-10-01 9:30 ` Paolo Abeni
2024-09-30 11:20 ` [PATCH 04/35] ALSA: " Julia Lawall
2024-09-30 14:02 ` Takashi Iwai
2024-09-30 11:20 ` [PATCH 05/35] libnvdimm: " Julia Lawall
2024-09-30 22:26 ` Ira Weiny
2024-09-30 11:20 ` [PATCH 06/35] lru_cache: " Julia Lawall
2024-09-30 11:20 ` [PATCH 07/35] leds: leds-gpio-register: " Julia Lawall
2024-10-10 13:42 ` (subset) " Lee Jones
2024-09-30 11:20 ` [PATCH 08/35] fs: " Julia Lawall
2024-09-30 12:09 ` (subset) " Christian Brauner
2024-09-30 12:25 ` Jan Kara
2024-09-30 11:20 ` [PATCH 09/35] sysctl: " Julia Lawall
2024-10-22 19:31 ` Joel Granados
2024-10-22 20:13 ` Julia Lawall
2024-10-23 13:38 ` Joel Granados
2024-09-30 11:20 ` [PATCH 10/35] dccp: " Julia Lawall
2024-09-30 11:20 ` [PATCH 11/35] powerpc/ps3: " Julia Lawall
2024-09-30 11:58 ` Geert Uytterhoeven
2024-10-02 8:43 ` Geoff Levand
2024-09-30 11:20 ` [PATCH 12/35] soundwire: stream: " Julia Lawall
2024-09-30 11:20 ` [PATCH 13/35] mei: bus: " Julia Lawall
2024-09-30 11:21 ` [PATCH 14/35] maple_tree: " Julia Lawall
2024-10-09 0:27 ` Liam R. Howlett
2024-09-30 11:21 ` [PATCH 15/35] tipc: " Julia Lawall
2024-09-30 11:21 ` [PATCH 16/35] net: " Julia Lawall
2024-09-30 11:21 ` [PATCH 17/35] mfd: atmel-smc: " Julia Lawall
2024-10-10 13:43 ` (subset) " Lee Jones
2024-09-30 11:21 ` [PATCH 18/35] usb: " Julia Lawall
2024-09-30 11:21 ` [PATCH 19/35] iommu: " Julia Lawall
2024-10-15 8:21 ` Joerg Roedel
2024-09-30 11:21 ` [PATCH 20/35] drivers/gpu/drm: " Julia Lawall
2024-09-30 11:21 ` [PATCH 21/35] ring-buffer: " Julia Lawall
2024-09-30 15:14 ` Steven Rostedt
2024-10-10 19:36 ` Steven Rostedt
2024-10-10 19:54 ` Julia Lawall
2024-09-30 11:21 ` [PATCH 22/35] PCI: hotplug: " Julia Lawall
2024-09-30 16:42 ` Bjorn Helgaas
2024-09-30 11:21 ` [PATCH 23/35] SUNRPC: " Julia Lawall
2024-09-30 11:21 ` [PATCH 24/35] soc: qcom: qmi: " Julia Lawall
2024-09-30 11:21 ` [PATCH 25/35] drm/amd/display: " Julia Lawall
2024-09-30 14:48 ` Harry Wentland
2024-09-30 15:51 ` Alex Deucher
2024-09-30 11:21 ` [PATCH 26/35] firmware_loader: " Julia Lawall
2024-09-30 11:21 ` [PATCH 27/35] mac80211: " Julia Lawall
2024-09-30 14:29 ` Jeff Johnson
2024-09-30 11:21 ` [PATCH 28/35] UBI: " Julia Lawall
2024-10-08 8:18 ` Zhihao Cheng
2024-09-30 11:21 ` [PATCH 29/35] drivers/gpu/drm: " Julia Lawall
2024-09-30 11:22 ` Christian König [this message]
2024-09-30 11:38 ` Julia Lawall
2024-09-30 11:21 ` [PATCH 30/35] audit: " Julia Lawall
2024-10-03 19:03 ` Paul Moore
2024-09-30 11:21 ` [PATCH 31/35] slimbus: messaging: " Julia Lawall
2024-09-30 11:21 ` [PATCH 32/35] mm/mmu_notifiers: " Julia Lawall
2024-09-30 11:21 ` [PATCH 33/35] drivers/net/ethernet/intel: " Julia Lawall
2024-09-30 21:14 ` Tony Nguyen
2024-09-30 11:21 ` [PATCH 34/35] pinctrl: " Julia Lawall
2024-09-30 11:21 ` [PATCH 35/35] comedi: comedi_8254: " Julia Lawall
2024-10-06 1:55 ` (subset) [PATCH 00/35] " Bjorn Andersson
2024-11-17 12:09 ` Michael Ellerman
2024-12-20 17:27 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea6868b2-ea0e-42ad-8351-c02553691b74@amd.com \
--to=christian.koenig@amd.com \
--cc=Julia.Lawall@inria.fr \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®