From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 101BA31714F for ; Tue, 16 Jun 2026 13:16:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781615794; cv=none; b=JT3gtNy5PrTDRs5vN7IFtRVqWmaN+sLPq0EYrqKkYceJWwWbmMavgQRwOF66q0JwpgCYJjwV4Pn+1KeJ8b+FyiN9Tmp1WCzxXByLrqqMUlDzTdpwxt3w5mF5PF4XPRR1qTy6FonJFH6MtTdBORCaOKashUxk8kquv4nT8vZCM4E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781615794; c=relaxed/simple; bh=49PdK05MfJuPjs1aRlijj6dHIPLp72WX74A/rJI6gok=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QPaEvo6DBoeHSGoG3gsutFh39sRdDBHrZgCQSZBAk9GqSW4ICVNhpdVklwDxqtKL8xLfA3ZzzvjHkWJg97KzIPed6zyAUfTOnPR3j30b5LPZAQpB/TkwUOMPA7PIs+wDf5wxV6Ud+mAvV7cG4/uDmwwBvnMqyTnenKNVzwaUe2g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=durfiHYN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=We8PQEIH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="durfiHYN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="We8PQEIH" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GABH193223774 for ; Tue, 16 Jun 2026 13:16:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BowRZ2AS+201sr5j8jJBVB2tSw9pjrUlTsmfC3fjNtg=; b=durfiHYNrkEpvh73 Q462eTqBlCeQulUOGCwf/kh43n4TaCYOJVAwewBOqK4XpXk0wFSmnHdLq/U7xfpm l1pf/A5sNVN/qRhrSzWhsvSKFzKxq6iPLkq9Jur3t4B19aTBxAqvocq9yhCuGeAo 9YfmcYECHLXFhEpthCZAZTIwfzHO9z+EbycTSaBQG4mOUPk9qTHw/wmkihsWOPrv /dUpNBfw/V3N7LqUIwYdkzSLxEgJDyNCEAY5BHZbegbbljvyFvG1I1XSU3xmzW1E XVUhy1bSW/X/Sqgtp/wklban5G9bpA9ro4xhs/9aTXReBnbpxw9EIk6DNrD/nDQm S9SPCA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eu1ysse4w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 13:16:30 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-914b9d0162aso49769085a.2 for ; Tue, 16 Jun 2026 06:16:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781615790; x=1782220590; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BowRZ2AS+201sr5j8jJBVB2tSw9pjrUlTsmfC3fjNtg=; b=We8PQEIHJ+LC5VHPYko/TDV82PZTMyoP1ZDgT2v5DBaqvbtcwV00/RsGo2vtfE5j6l 1gb6x6vwa7fK3HB77hpd0Dertlk1M1AdYk2ITjeXM7ChmxuCUQ6LQNABe+iZ2UaG1iaP lLwSs9A5IUb5soAb220nn8Yfym3zUxofnFuSOqZIaR1CyUg4i7MoqMd2+za8OBN67Pvj NKzg+IRnaZTmearzv99jT/5MU4HtlxIy2DFbJRgDCZigxR/yHLZeMclPc8BHMvbwfcrK 05v/VuyLcaeg/kW7O62CgHtqBYP826Jqadtjf7Io3S3Ae7OrHONg8NzG0aWt1Q94xmTN YzvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781615790; x=1782220590; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BowRZ2AS+201sr5j8jJBVB2tSw9pjrUlTsmfC3fjNtg=; b=jTaWznm+ZK2AnCDtqSpd/JK4w5SBkFOdMxuy+T8mdPWwSHU/NKoRqCTf+4hEMpZhN9 OOr544dVcAOOcPdLcg0OB6YvGOmyMHnB0iYPPNXhblyJHQl1cXZvU9CaCM6V6kkEvR6e Xof7TfA37ifkDPGANc8LOHh582mPO4ZnOWpQsqLH/vSftAfiDDKlYROkeBbfoy78aIoG cB3wm2gDTnrlDDoa8KLOstacTlpbYR/1mLUAWrezGFjC9JMYx3RSz7sQ5BLp92NmDIUP AocHIX1YQI6g2rHTT4VlsTp0hXmXEsywzcWHarYWQPcExU3F6m5ljgPEvW5ZiaZwPjfq gZ9g== X-Forwarded-Encrypted: i=1; AFNElJ+FVhsQ+q3PCT4QkjdAmyYBLfLlzUwFFWAGu+UARPJp3xyIvEoXcuwwFGKLKh5CNaIX/xzMZ0VOqx/NlR4=@vger.kernel.org X-Gm-Message-State: AOJu0YyhWcrL4xjsWrwrIVUSEySJh1HGyIVmI1ugkMEtcMwPh3GPeAeW nTkplBkAULCjoiApk598pVhqCJI4hm3k0QW5/WM6SP5Zr5i3NcGUpE53h3ygoreZGFK32YNUf+S gpVXJ23EoS5yfo/bNLfudxo03db0lOfDqhNYaMKesVgSlZTAn0EhDNb8h4DMCkDZB2RocRQZ6lq M= X-Gm-Gg: Acq92OFHDFwZg6LnwSiv+tyvZX48P3IJ0GwS5C7+JbvB9eD2fL71Q0ZjzNFssCud69q JzPk3mqPBnyQjBbvSVdu5NmlzHvSvLRA4wPn7CygzI0irzFwTqtpkWaIlGv5z2TUSEvjfXYuC5/ Mtvho0Ow3nL+VVDF5zFJ3vL3awo1m49nVW567ny3T6YLAUSCH9NEXRxeHWr8CxAYeUj94oxtCht o+5aqjde2QW1zCeuq/DQHrPPhSezCQVsmVSFnfEErMSZvm3t+ya89LDyezotMPnURzCsvj8s0Fm s2oBqm0ahK/bZK+ry9WfV7ASyThsXMiOqN7WcwZ/PMHe+oj3lb9Ok0wrF4FzEpSi5x1VKEapg48 GPMLYkZc2RqLAjGP7kFcAXW8JMMGVsulsNoJXwiJUHj+ZCg== X-Received: by 2002:a05:620a:2a07:b0:902:daaf:22cd with SMTP id af79cd13be357-9161b9598e7mr1677790685a.0.1781615790284; Tue, 16 Jun 2026 06:16:30 -0700 (PDT) X-Received: by 2002:a05:620a:2a07:b0:902:daaf:22cd with SMTP id af79cd13be357-9161b9598e7mr1677788385a.0.1781615789754; Tue, 16 Jun 2026 06:16:29 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e1a730esm3517152e87.41.2026.06.16.06.16.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 06:16:28 -0700 (PDT) Message-ID: Date: Tue, 16 Jun 2026 15:16:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: typec: ucsi: unregister debugfs entries on teardown To: Bjorn Andersson , Heikki Krogerus , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260611-usci-unregister-debugfs-v1-1-f4a518a94f27@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260611-usci-unregister-debugfs-v1-1-f4a518a94f27@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: wOcfwCPbZJDwM4VumtxOrjEcpz678BON X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDEzNSBTYWx0ZWRfX7jkseMsJoHuT zJBrUARl5QOL29+zl0wUvrnCc3RtZj/tPqPwzgt/ijKXE5keza9sWFOZeeCetYpPyoPpp9ag+Lx 5BtMcxitlT5sJ4uYuzip4KKLJsDVWfA= X-Proofpoint-ORIG-GUID: wOcfwCPbZJDwM4VumtxOrjEcpz678BON X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDEzNSBTYWx0ZWRfX3PCSFDUYBReY s/1sTVsbwPzcVsiLv+2f97CFxBuYPqYc0qc0XS0HyPYWLDG3tZIUtWy/vvekkWCldg53IgcBger sNQOjzAcIzV6rBaE75t8Nh5oV2s+dUPtNrIB05Epw2CHHklpQ9+wlmeRtQxWJwbRRVO67Ijvebb QqIRI8cs0di6seyIADRaVrDpg54LSI2kWbkvp2ssxoMahpOBURVA3dGtFBF316kpyr/GDQoMeIP Ix5VyzMRAiuOFG6XwZVSY3ZsyxOuAwPHR0A5wc2VW5UEn2d5CxJxQUrhPcHOJH/Gww+Up3bvHnn jG693ZLA/OLlLq6x9vg/uRxxGFIJnoQ/MaxmlSBXTDdkg4f+aMAWd/FNLgnJ0fzaqP6jGXcIsVj Jgv10TgEi1fRn3Ddn4q/hY7ggTrHal34cG5k4Ip76FAkh5+mSUjJESZJ6r5/1+4PcVwCfbTVTkM 6IXshn7AjjKoltjYXVQ== X-Authority-Analysis: v=2.4 cv=JJcLdcKb c=1 sm=1 tr=0 ts=6a314caf cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=N3f1q4s7xJVnOBk5yegA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_03,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 bulkscore=0 malwarescore=0 suspectscore=0 phishscore=0 priorityscore=1501 adultscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160135 On 6/12/26 12:22 AM, Bjorn Andersson wrote: > ucsi_register() creates per-instance debugfs entries, but > ucsi_unregister() keeps them around until ucsi_destroy(). > > Drivers like ucsi_glink that unregister/register the same UCSI > instance across remoteproc restart then try to create an already > existing debugfs directory and log: > > debugfs: 'pmic_glink.ucsi.0' already exists in 'ucsi' > > Unregister debugfs entries as part of ucsi_unregister(), and > clear ucsi->debugfs after freeing it so repeated unregister > paths remain safe. > > Assisted-by: Codex:GPT-5.5 > Signed-off-by: Bjorn Andersson > --- Fixes: df0383ffad64 ("usb: typec: ucsi: Add debugfs for ucsi commands") Tested-by: Konrad Dybcio # X1E80100 CRD Reviewed-by: Konrad Dybcio Konrad