From: Jon Hunter <jonathanh@nvidia.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
<linux-tegra@vger.kernel.org>, Matthias Reichl <hias@horus.com>,
<alsa-devel@alsa-project.org>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Takashi Iwai <tiwai@suse.com>, <linux-kernel@vger.kernel.org>,
Marcel Ziswiler <marcel@ziswiler.com>
Subject: Re: [alsa-devel] [PATCH v1 3/3] ASoC: soc-core: fix platform name vs. of_node assignement
Date: Fri, 11 Jan 2019 09:15:42 +0000 [thread overview]
Message-ID: <ea6b6a3a-b4eb-1d29-51fd-330b2b170005@nvidia.com> (raw)
In-Reply-To: <87h8efpoxh.wl-kuninori.morimoto.gx@renesas.com>
On 11/01/2019 08:51, Kuninori Morimoto wrote:
>>> Indeed there is such case so far, but my understanding is that current
>>> driver should select "legacy style" or "modern style".
>>> If driver setup it as "legacy", but access to "modern" member,
>>> it is driver side bug, right ?
>>
>> Yes absolutely it is a driver bug, but looking at the snd_soc_dai_link
>> structure today it is not clear what the driver should be setting and
>> what is 'modern' and what is 'legacy'. You need to dig through the git
>> history and code to figure this out. So you could say it is not very
>> well documented/commented from a soc-core perspective and could be easy
>> for a driver writer to get themselves in a pickle/mess. Anyway, that is
>> easy to fix and we could add some comments to clear it up.
>
> Thank you for your feedback.
> Yes, indeed there is no enough information/documentation about
> legacy/modern style, and its plan
> (= all driver will be switched to modern, legacy will be removed, etc, etc..).
>
> So, can you agree about these ?
> 1) Add enough information/documentation about legacy/modern style and its plan.
> 2) Add dirty pointer fixup patch as workaround
> 3) switch to modern style as much as possible
I think that Mark needs to decided on whether use your 'dirty pointer'
fix or not.
Jon
--
nvpublic
next prev parent reply other threads:[~2019-01-11 9:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 11:18 [PATCH v1 0/3] ASoC: last minute fixes Marcel Ziswiler
2018-10-18 11:18 ` [PATCH v1 1/3] ASoC: tegra_sgtl5000: fix device_node refcounting Marcel Ziswiler
2018-10-18 11:18 ` [PATCH v1 2/3] ASoC: soc-core: fix trivial checkpatch issues Marcel Ziswiler
2018-10-19 12:26 ` Applied "ASoC: soc-core: fix trivial checkpatch issues" to the asoc tree Mark Brown
2018-10-19 12:34 ` Mark Brown
2018-10-18 11:18 ` [PATCH v1 3/3] ASoC: soc-core: fix platform name vs. of_node assignement Marcel Ziswiler
2018-10-19 10:22 ` Jon Hunter
2018-10-21 11:23 ` Mark Brown
2018-12-18 17:40 ` [alsa-devel] " Matthias Reichl
2019-01-03 16:42 ` Jon Hunter
2019-01-08 2:25 ` Kuninori Morimoto
2019-01-08 10:50 ` Jon Hunter
2019-01-08 12:03 ` Jon Hunter
2019-01-08 15:48 ` Jon Hunter
2019-01-08 16:09 ` Mark Brown
2019-01-09 1:51 ` Kuninori Morimoto
2019-01-09 11:03 ` Jon Hunter
2019-01-09 12:53 ` Mark Brown
2019-01-09 14:11 ` Jon Hunter
2019-01-09 14:14 ` Mark Brown
2019-01-10 1:16 ` Kuninori Morimoto
2019-01-10 3:46 ` Kuninori Morimoto
2019-01-10 10:56 ` Jon Hunter
2019-01-11 0:52 ` Kuninori Morimoto
2019-01-11 8:41 ` Jon Hunter
2019-01-11 8:51 ` Kuninori Morimoto
2019-01-11 9:15 ` Jon Hunter [this message]
2019-01-14 23:02 ` Mark Brown
2019-01-15 15:26 ` Jon Hunter
2019-01-15 18:07 ` Matthias Reichl
2019-01-08 15:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea6b6a3a-b4eb-1d29-51fd-330b2b170005@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hias@horus.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marcel@ziswiler.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®