From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C4D324A06E for ; Tue, 27 May 2025 09:28:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748338139; cv=none; b=ovwyhPTkcg6xYmxERmecGCYae6Yha/nkQh3RtpH1HSSuKC3/0Th7NqAzP+4Ao4O/tIJZKgcDIv+Y2aISdaun6pWk12sAd/RaCJrs5de/AN3VNeSwUH+SHwXRGhmIko9H+yVp1v7Ud2zREa41LBDnXmRCDutvgheKRtVIbuavBsg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748338139; c=relaxed/simple; bh=jYEhg75W17+LrrRp5ozft0smLaCDvCUlIDdgZkc8Maw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JhvNwvfhRIXFAauGQNR0SfFuuwuVkaNewVTIPIABOd3uQzIOyw4cXtUie1LwyTx3w0iEgTrDafeC8pARynWKPHVcI3Ytb2j5iI36CdWEJj5s5hhVJYQea+isKurT2oZEfq0fG1Hp2L0T1Z82gCfP+yiCkoDup4bjyRGt0sEFUV8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GcnF3O2+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GcnF3O2+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748338136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d2VX9MfL1HCTriT+S3B9Z1XwLwg3XDZQ+O6lDXv3bE4=; b=GcnF3O2+DhFxEc9GW8lAH0adS9eRHDdbK9qujz628jaSAOdvosEvbho12Xw395xCiZK7QJ ZuNvrRLEIXoPnMFelBvsL+tT5Epk9WZA2rq5QV+0bRaQpSPM57k+CDAgKIDNfHrL9rZLNk bbO6XtMt6TTIrBsKgyVLTUpUr6ZXJ8c= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-WQwunQL9OwCx4OcmC_POgg-1; Tue, 27 May 2025 05:28:54 -0400 X-MC-Unique: WQwunQL9OwCx4OcmC_POgg-1 X-Mimecast-MFC-AGG-ID: WQwunQL9OwCx4OcmC_POgg_1748338133 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43e9b0fd00cso15797265e9.0 for ; Tue, 27 May 2025 02:28:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748338133; x=1748942933; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d2VX9MfL1HCTriT+S3B9Z1XwLwg3XDZQ+O6lDXv3bE4=; b=M93JvT43JAH6ptIEaBYv23DYBV9AQJ8Pwy98+iGyqCe9pe4IuD87ZBolCtd0EaKejf 8KO6VW37T9WHFCC2Ugu2ffNelyR5GKHsa4jXA2tHGRVI4n42MgUasWsUSBuztqzagiZF epKMwu5OzPVYESZUoxDcnlQY1rFF5R5msDzPOP/H+8UcOJtBaQx9aOmeKUUMhESUCQQU wj/v0+kuwJXaPZFqvR7ubZA7U7z87YMTKGWjEykafaGoDpD2fYubSHGJ7ED7QHYAOi2c QQQhuF4Yqb3Ms4ceUlAncNUGC1TrzySewjHiskPTQk1iYcNFxnp7y9zj1vnDdo0+9mPD 632A== X-Forwarded-Encrypted: i=1; AJvYcCWk6EYcCmqVyQIkdM74tw9JfhMsXpAUrz7YAtSRgO+YSWE2mdJXIN3yFcuyItiB2/DX6LdLjUr2c/zQNIc=@vger.kernel.org X-Gm-Message-State: AOJu0YwcEIXkxj56iC/PmDYfPN3qvHCiq0NJE5t2Ty4XWjkVj1j/i9Zc 4ZJh248Im6sFnPqRVLKeTd+D8BuBWkC9OXLb2kyxRJKEFwTDzXoOFyQtjRT3L0zC1/zgk/WZ0xG vXTM9zchPxoJRuEAh3hq0MXi+z8ybGawrh+vFZEVC1LGU1+0WQSAu8vB8J4P+Fcrx6A== X-Gm-Gg: ASbGncsgi5kYPuX0xlYmTy/cvbUcttUomjPG+5DsSoNWuL2Wx47hKV3iVWcA65OKsXE pdlHCuUMWDQ9X5wK2LSy1OucCVb56UBmqtARCM1sw2Q7MqSojWX/mmJVVukwWCzUbCMQc0Rt6GT oG2PTxJJe3PZ8fYPYkaAdCvEDrgzFKPko3bN1tujay82tm29gbQwWNZv0Jp0zwVtAPRyrSizIwb 44oKRWTseKa1TmU15HHD+cEqiqvhP7rGNpUSf8KYVV8/9TInTorFiC2qunvwq4v05UUcPYAP2qA Uy6wpFZ6jTLpaOvA+iQ= X-Received: by 2002:a05:600c:1d0a:b0:43d:186d:a4bf with SMTP id 5b1f17b1804b1-44c77bf3aa2mr98283955e9.0.1748338133538; Tue, 27 May 2025 02:28:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFW/XvOutq354S3u3kVQy6maNZpndfNYmmZuqtvnQwyMkFCqY+qleAw2OpAQBAisEp90oBu4Q== X-Received: by 2002:a05:600c:1d0a:b0:43d:186d:a4bf with SMTP id 5b1f17b1804b1-44c77bf3aa2mr98283485e9.0.1748338133127; Tue, 27 May 2025 02:28:53 -0700 (PDT) Received: from ?IPV6:2a0d:3344:2728:e810::f39? ([2a0d:3344:2728:e810::f39]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4e4c4739csm290454f8f.0.2025.05.27.02.28.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 May 2025 02:28:52 -0700 (PDT) Message-ID: Date: Tue, 27 May 2025 11:28:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next,v5] net: mana: Add handler for hardware servicing events To: Haiyang Zhang , linux-hyperv@vger.kernel.org, netdev@vger.kernel.org Cc: decui@microsoft.com, stephen@networkplumber.org, kys@microsoft.com, paulros@microsoft.com, olaf@aepfle.de, vkuznets@redhat.com, davem@davemloft.net, wei.liu@kernel.org, edumazet@google.com, kuba@kernel.org, leon@kernel.org, longli@microsoft.com, ssengar@linux.microsoft.com, linux-rdma@vger.kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, bpf@vger.kernel.org, ast@kernel.org, hawk@kernel.org, tglx@linutronix.de, shradhagupta@linux.microsoft.com, andrew+netdev@lunn.ch, kotaranov@microsoft.com, horms@kernel.org, linux-kernel@vger.kernel.org References: <1747873343-3118-1-git-send-email-haiyangz@microsoft.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <1747873343-3118-1-git-send-email-haiyangz@microsoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/22/25 2:22 AM, Haiyang Zhang wrote: > @@ -400,6 +448,33 @@ static void mana_gd_process_eqe(struct gdma_queue *eq) > eq->eq.callback(eq->eq.context, eq, &event); > break; > > + case GDMA_EQE_HWC_FPGA_RECONFIG: > + dev_info(gc->dev, "Recv MANA service type:%d\n", type); > + > + if (gc->in_service) { > + dev_info(gc->dev, "Already in service\n"); > + break; > + } > + > + if (!try_module_get(THIS_MODULE)) { > + dev_info(gc->dev, "Module is unloading\n"); > + break; > + } > + > + mns_wk = kzalloc(sizeof(*mns_wk), GFP_ATOMIC); > + if (!mns_wk) { > + module_put(THIS_MODULE); > + break; > + } > + > + dev_info(gc->dev, "Start MANA service type:%d\n", type); > + gc->in_service = true; > + mns_wk->pdev = to_pci_dev(gc->dev); > + pci_dev_get(mns_wk->pdev); Acquiring both the device and the module reference is confusing and likely unnecessary. pci_dev_get() should suffice. /P