From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 626371624DF for ; Thu, 16 Jul 2026 14:46:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784213210; cv=none; b=MvFR54gmikGLmzagp+HeMlW7Vhy/l3M93+ccFjyaXsH7P9rWa4YqIBmSKa/IFx1DUa0ubRBuV1Ki2hNuUJ1X6n//fNDcAoBb/lL3ZbVgeUDnaFLjxtuyHnNHgfKLIJ4Y0c1FZHFYJEFmEVYHw4qHp9SAzMw2UjriTqRhFE0iNbg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784213210; c=relaxed/simple; bh=b4PZofv5ZakvpsrCVmS7FDDeAS/fcZxBc65dgSUABDY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dpB5lxLpyBbd4CJcs4T60qiqZIPp6l18K0d/3Q1S26yoNNctkCRVEEfFNJNeVxG+WH2dROi3WqnvZpypYZ1fbE/e5/kTr+WxQ7qd7c4iB/qJqvDKuFRp2OThbYze5o/90OJS/5/bVWOX7zh5xBHZIR1cPmVB264DrBcA1yBU6LA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jJUg1Jne; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DQRzDTrW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jJUg1Jne"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DQRzDTrW" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66GDJnBU2897300 for ; Thu, 16 Jul 2026 14:46:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ISakoJPzKPUJBTay4/8sv84QNCBCM/qEUBUmFCduv4A=; b=jJUg1Jne/kQ1q7L0 Cr5mDXvqh/cJ77F431N5wgHInmNDO0kuq5Ai0cF6HSyUIwO7i8MvO7OApWFv/RFm iupysTl72VpH8sJ7L7g73kWE89OG/rzMaqGBekAa6/XtdYSn5JRrrIZ5ybnoFV9H 83VwTUCKIhZZ1g/LZ8v/m4lWb6QcM+LPifTht83ma3Kr4xAPn2ja3+IlyCQNRRCR sbmrhmWxFsiRnNJ57ATnCADBSUuEosJ+ws7d0Sys4W7K+dCvvoo5vLI6WtDnVS91 8xnWYZ28t6ogt3kJgIEyyiBVXW6TjmRq4sgtx6jq6N9XCPBB3yX3SigOVhQwiDV9 7Qb83Q== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4feve1shdp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Jul 2026 14:46:42 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c892143db7fso3118744a12.1 for ; Thu, 16 Jul 2026 07:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784213202; x=1784818002; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ISakoJPzKPUJBTay4/8sv84QNCBCM/qEUBUmFCduv4A=; b=DQRzDTrWJZyafsPnzajZkLI8jtJrgadOHg9yNWvWr8JGO++wI4J5LeBaEZh5fajk1d 7hgJ0qqFa2XUn17lEIe8ZLg9n59b3HWgFaAkfhxRk3D+F+Cq2JM0YqDCuUXYiAVkhnOj PX+rU3FErr4yYnKBSW5Biv9Y3g4wP5FG1hsQ7Aef2WXAFW7+nX0M6Vn/RE0BzuxaTCxl LUv2ICs30INMYKP5hmoMoK+aTAn5WBVKm5Hm3pKUsX7FFkceiqTChhvTpF+BgzXi+Y4S SglW2D4Ixz6AUA6gl1SC+DeuiKnncQ2qeBrSFIhh9SlWuUATQCD39JOpxxhWeA3G6buw 1x6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784213202; x=1784818002; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ISakoJPzKPUJBTay4/8sv84QNCBCM/qEUBUmFCduv4A=; b=LEnI8onbQum5FQNR+u1nTD7AHolURWi7cG6ad/oytGAN1wZ4uG0YMJAM/bm1kgfwrg 6T0F62wHNiSVi44ywaQhPAwkqJBrjnveWO/Qm5vfVc9PdAwoC1lc9efmpSIzKOaR9Ykn QuBmxJWoiJKr02Gh+H1313KOUzm/7cjrKjjlw0gTXBXr/mfjqEBQXNV/aBC0punLCy/u 03GuqdB/1SlEjse8xMP5c6mshZr40TntYCAHyZG8t2HDa/STnvtnqg/VFMPWgTn/jzJk YkclEp2N/wd5FuXT3AyZaPfb+eTZOsp9FgV/kLJBKuIWvGsLYDDQgEAIPgVewq6kGO7k /WPQ== X-Forwarded-Encrypted: i=1; AHgh+Rr5y7inS9kK/p1+1pEQYNC04yVNF5XZ/NSS14JUd5Kg9JbPZl6/HIBkkADT6/2DTjqTcBcztQvgYIVlTXw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6/UfvrMFdRlAeSUjhCRtJW3XwhcMrsAr8wDFLvaB8l+mpO7Ky xuo3drkQLa0co9kk9406CIsk45NRq2zuGkwQeJ2QQ/smRoWO4C6RiYx8hpL2HClju2DpmMwMMZK 8KFr/3dw2QJffJxGXDHuEkkoF1qETy+HjW+s7McWQgiMBB+r0ETQ2Ezvl8LlcNuG/Zus= X-Gm-Gg: AfdE7ckkZ4pkeL3wxF5FsvESzttm8XE45tMP5POc9jkChLopFykqxZnFSJCdXwLOsYZ uYqReCK4fCL5d9Av+qVdjk7TGhYr3M9EvbywVItESH7CEZ0TFdU9EK2jxniSReCkvLUF0lkviqP 5Qd/WjHxXHHDqlVdESRmyw83LJhRiBOCLndGKJnywPERemoidKzAT6P3ML/Cgpm2hiBAhnoQW+N +hNM1UpIVRKp1z9KMG8GheKrcYFCTWvfrR4G3hQLrqTfK13zfaIBzzPqJxg65kvrCM1TtZtc8r/ gYpcIuZSPHt0uw01qZUQ29UVMGC5gOAI6Rad6KVubJ6+QJ4G4+FGMh3mFOvQ27GF/7XLojuw/gd WTu2/0qmXPweiJPof6j+cAXnoZDBAzu4= X-Received: by 2002:a05:6a21:6cc4:b0:3bf:e66f:266a with SMTP id adf61e73a8af0-3c110adf3d6mr24918163637.59.1784213201736; Thu, 16 Jul 2026 07:46:41 -0700 (PDT) X-Received: by 2002:a05:6a21:6cc4:b0:3bf:e66f:266a with SMTP id adf61e73a8af0-3c110adf3d6mr24918127637.59.1784213201144; Thu, 16 Jul 2026 07:46:41 -0700 (PDT) Received: from [10.218.16.3] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cb259026640sm1872033a12.30.2026.07.16.07.46.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2026 07:46:40 -0700 (PDT) Message-ID: Date: Thu, 16 Jul 2026 20:16:33 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] ASoC: dt-bindings: qcom: add LPASS LPR vote clock ID To: Krzysztof Kozlowski Cc: Bjorn Andersson , Bartosz Golaszewski , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, Bartosz Golaszewski References: <20260715133243.3170821-1-prasad.kumpatla@oss.qualcomm.com> <20260715133243.3170821-2-prasad.kumpatla@oss.qualcomm.com> <20260716-powerful-aloof-wombat-5088a1@quoll> Content-Language: en-US From: Prasad Kumpatla In-Reply-To: <20260716-powerful-aloof-wombat-5088a1@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE2MDE1MSBTYWx0ZWRfX3Egfx2U9U4Rd 3tYg2XEAijZDBzZ8vQlBXzG/W9ukL9LukCxc+PYXu8KKLDLtuwRAiCdgsSTAPnDjtm5F/PcgcZg AOjguD6/C5kH4p2lI7yNHSmhrdFgV1tFqGkdg1eUHJcZv/zCC0UNmY1/VkYBuHYL1pmtqVDDfNj grJRpsB2/quOEjpOQNGxq6RmsjhnWlvfW18FEqc0gsjohSZDUXVwiMu6v4guBUZXmh9ZUvvnk9U BMAOT2MdrRIeDEbL+N7Pg8DZykqvt3vUgILuMFTeVbAcqDxetk3x+3NbeuMPc66XHmZCIxLJ9Hh NjiXaPch5OdNXDMcape62lP5197Dmx8TDE5tYJBsCUHLppMEvJetvFLj+lP6f5uq36MKsFbQpwe 56lj1YLPD44pwRQ0PysTnnJ9zNV3msZWh4+YKuvQevflm3+8xCLXM/QuiPf/HimxTYGmg2S03Jv QbppQD2mAMp2frbSUng== X-Authority-Analysis: v=2.4 cv=DvpmPm/+ c=1 sm=1 tr=0 ts=6a58eed2 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=yUS1d6AIqEqXcYuy1NoA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: OYlbd8DbQo6zmJo8eIpyns5XF3R6Wx0d X-Proofpoint-ORIG-GUID: OYlbd8DbQo6zmJo8eIpyns5XF3R6Wx0d X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE2MDE1MSBTYWx0ZWRfX+9lcID68uDh6 8XIs7fQwIVVYDGZ/yhoPRGZ3amRfDinPUfV07u1y5I9YAciDE4vI1nNwq6sErX7JLWfyKZHk/lN 29jdRScYhreWxFHEiJedCooC8ksO4f4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_05,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607160151 On 7/16/2026 1:31 PM, Krzysztof Kozlowski wrote: > On Wed, Jul 15, 2026 at 07:02:40PM +0530, Prasad Kumpatla wrote: >> Add a new clock ID, LPASS_HW_LPR_VOTE, to represent the LPASS low-power >> resource (LPR) vote through the PRM interface. >> >> The LPASS PRM supports a resource voting mechanism to control low-power >> states via PARAM_ID_RSC_CPU_LPR. Exposing this as a q6prm clock ID allows >> clients to request the LPR vote using the existing qcom,q6prm clock >> provider interface. >> >> This functionality is required on newer platforms (e.g. Hawi) where LPASS >> clients need to explicitly manage LPR resource voting via PRM. >> >> Also update Q6AFE_MAX_CLK_ID to account for the newly added clock ID. >> >> Reviewed-by: Bartosz Golaszewski >> Signed-off-by: Prasad Kumpatla >> --- >> include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h >> index 45850f2d4..06ca2c287 100644 >> --- a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h >> +++ b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h >> @@ -236,8 +236,9 @@ >> #define LPASS_HW_AVTIMER_VOTE 101 >> #define LPASS_HW_MACRO_VOTE 102 >> #define LPASS_HW_DCODEC_VOTE 103 >> +#define LPASS_HW_LPR_VOTE 104 >> >> -#define Q6AFE_MAX_CLK_ID 104 >> +#define Q6AFE_MAX_CLK_ID 105 > Nope, ABI break. You cannot change that and as stated many times already > - if you need it, then it is not a binding. Hi Krzysztof, Thanks for the review. LPASS_HW_LPR_VOTE is intended to be consumed via the DT clock specifier, similar to LPASS_HW_MACRO_VOTE and LPASS_HW_DCODEC_VOTE. My intention was therefore to add a new DT-visible clock ID. Regarding the ABI concern, would assigning LPASS_HW_LPR_VOTE from the currently unused range (for example 100) and keeping Q6AFE_MAX_CLK_ID unchanged address the issue, or is the concern that LPASS_HW_LPR_VOTE should not be exposed as a DT binding at all? If not, could you please advise the appropriate place/example for defining this CLK ID? Thanks, Prasad > > > Best regards, > Krzysztof >