From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A3A02D5922 for ; Sat, 14 Feb 2026 18:36:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771094176; cv=none; b=HbBb1z45WMawBONtD/7FwoFGEKNEPZk4BVgm023gFyIuzkB78leLzkxv3inJ/n2xwo8ExQmnSVISWoyrf6DazvxZLTggyHZHXjIWbqN0bDIPI8QH9HrdK7i3mNfTY7D2Ly6X9gSXwrvymaXyBbl9VozL1DoHvzcGZ0lElxFgJTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771094176; c=relaxed/simple; bh=x8Yj7Q0c68ZMZ3ZvqB26h8g0lDn4W5MGUUK7ijQtFCo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iLUUyDYoDwq+hQqVGxRUda+H2cL5l2nVv6ipS5lMobfKQv65DcIR2HsPyLe+LfYJc6eZR8zYoTAqZM0rS5cvhU4VaPhXfCXgyujnhrkm8ns/jz9M5ByICyACVmGppJj5P5dk+8VwtBAT8V5pjwCleTDDPAYd22jpZiMo29pnOWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=CPz2SDrK; arc=none smtp.client-ip=209.85.160.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="CPz2SDrK" Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-40ea611d1a4so653776fac.2 for ; Sat, 14 Feb 2026 10:36:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1771094174; x=1771698974; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xp/G6UxSOewPZ/dZenFt7c0qcaCzMyXcTcB/83ucCM0=; b=CPz2SDrKTJc5nZdhm9H7K/yb8RpljaC+tRsxKMnPJTV7m06ifuj/SmLZdelISBNlsw 9QRGPV+aEehs4Y9j6gel4t/uOH1lkfPMB6urHMUeoKq17WCgbkDCLmj6ZSXhDBh5JcWO 1KQxLjdICT5yRtSoPLMMMwElu1BK6NUKmtAzQ2GeABv4LBQrvhHt2otZ2eGp7naKM1Mg qMogZOAsreEsTvziUjUJTmTiE6jpRb1ID+LHDNRn1jdct8YEErFL8TjI0IW3g8/NlYUz iVSgkU/VHc764NvbP49HxHcKlxZ7LV4tSHxBQwbnhnqArdkliUmP+Yhm34543Iul778A 65bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771094174; x=1771698974; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xp/G6UxSOewPZ/dZenFt7c0qcaCzMyXcTcB/83ucCM0=; b=NcQ6LQE55HaJLGTnKJgOpIb1lPDK+SQkDJxrAEZuYJMvYhNyP5+O8VQBARg2nWNseL kYkzyBOeLkF3IYfkOE4IkM7IwAN4W8+ftOAhgDONkjUFCabfnOvKZ0blDhY3oFq6q0Vk 3d5NOWJUaNDQHtkqFFBudwWlQw/A/h8f92tCYato/OumqkOs75hl5bqGjkfV3bC5aJv7 zk3TvYOrmRk5TmN6W5T3ofhWI/XkPjeY5MxlcXdq9t98y4YxmFcrzfZ8CfsxQxyIWD6j lEkdeNTr3Mhve2c2pEIqTofMB+E1bXIC2jAHXQj5nhTQjVxrjk0Oy3GVYBkSxORbu8pu 19mg== X-Forwarded-Encrypted: i=1; AJvYcCVahLGOjS0XVP16I2Ey3s3LfKEYpGZe9Iw710KIgsyZzPj87NwnM7Qj8TLSGZcdbAs0WvCsQZrdF9K8r1M=@vger.kernel.org X-Gm-Message-State: AOJu0YxO1t2RJADtYWydjeT1xOw7N37SIsVnWdgJju/T9paTxzg6zg5Q UhSKqGnBjmVX25y7ocdWT81l5bY/fNz28h48Q+2ZzVus8WeAr/NHJwofvl4a3UlNDSg= X-Gm-Gg: AZuq6aLf69L6C6rMJbIWXIn3yjVDNEpOJs84GY1F2DrxelSkqKOHqpiFDGhsxSnVZRJ IRqb8Y7OJwfYlDhRaMOkyCA0VZN/2NlhBGf9EBNalxw49KS3Kj1C0Kfsp03adXMg0vQFwt/7YEm WiRkGo4YZLnjwaSr3xtV/Lr+sX2VXmUaVyBVM0exuzKHk+mHUGM+CRq2CbgxFrS5YGh7TYuRHAD rqHXIDFE3q85roYNtRhD73AUwusEcRvHFG+hV+3nb1yyQIcAessgGm4p9dxifYyi1O+mEiDen1N o72JYB+nLjj7vsD662wU+Z6ccQKP9YSygvK/0Hl3YbH0CCvtrqkwvWaUVXDxg6tKTp2iKUwrprZ M8+3BxWv6d0Im18ZUqgAIdSUOe+4KxjEg2hxth7SZHzWR1Boum44YYjq+StvtL9ImlZz787tTLZ z/xd/OUpIIsorNO/iKcHxOdLlsXnPWijL40t1lsg2zzmDVf5ZgwM1Wu4Nrd/wqo+EtPUJUMw== X-Received: by 2002:a05:6871:28b:b0:3ec:a08c:9707 with SMTP id 586e51a60fabf-40f0d8b9548mr1662215fac.42.1771094174364; Sat, 14 Feb 2026 10:36:14 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:109:393c:254e:962e? ([2600:8803:e7e4:500:109:393c:254e:962e]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-40eaeeab492sm10045095fac.5.2026.02.14.10.36.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Feb 2026 10:36:13 -0800 (PST) Message-ID: Date: Sat, 14 Feb 2026 12:36:12 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: dac: max5522: use devm_regulator_get_enable_read_voltage() To: Andy Shevchenko , Jonathan Cameron Cc: Antoniu Miclaus , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260210175137.44178-1-antoniu.miclaus@analog.com> <20260214182052.14c6f8ee@jic23-huawei> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/14/26 12:31 PM, Andy Shevchenko wrote: > On Sat, Feb 14, 2026 at 06:20:52PM +0000, Jonathan Cameron wrote: >> On Tue, 10 Feb 2026 21:35:26 +0200 >> Andy Shevchenko wrote: >>> On Tue, Feb 10, 2026 at 07:51:27PM +0200, Antoniu Miclaus wrote: > > ... > >>>> + state->vref_mv = ret / 1000; >>> >>> "1000" --> "(MICRO / MILLI)" ? >>> (yes, this way with the parentheses). >> >> I know I've argued against proliferation of the X_PER_Y macros >> but this one does seem to be very common. Maybe it's time to bring in >> >> MICROVOLTS_PER_MILLIVOLT even if it's longer than the open coded version? >> >> Andy, what do you think? I do worry that people will see it as fine >> to add many many others if we start with this one though. So maybe not. > > IIRC (sorry, if I am wrong) it was you who objected in the first place > and I proposed that from day 1 discussing the "(MICRO / MILLI)" approach > a year (?) or so ago. Answering to the Q: I am in favour of having that > definition. > >> Anyhow, doesn't need to be in this series. > > True. > How about MICRO_PER_MILLI? Then we won't have to add a new one for every different type of unit.