From: Hans de Goede <hdegoede@redhat.com>
To: Sebastian Reichel <sre@kernel.org>, Carlo Caione <carlo@caione.org>
Cc: linux@endlessm.com, rjw@rjwysocki.net, lenb@kernel.org,
wens@csie.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Carlo Caione <carlo@endlessm.com>
Subject: Re: [PATCH v2 3/3] power: supply: axp288_fuel_gauge: Do not register FG on ECS EF20EA
Date: Mon, 19 Feb 2018 10:48:27 +0100 [thread overview]
Message-ID: <ea75cd5f-9937-8b95-d96a-761fcd091594@redhat.com> (raw)
In-Reply-To: <20180216142655.heommid67q3g22qt@earth.universe>
Hi,
On 16-02-18 15:26, Sebastian Reichel wrote:
> Hi,
>
> On Fri, Feb 16, 2018 at 08:26:16AM +0000, Carlo Caione wrote:
>> From: Carlo Caione <carlo@endlessm.com>
>>
>> The ECS EF20EA laptop ships an AXP288 but it is actually using a
>> different, separate FG chip for AC and battery monitoring. On this
>> laptop we need to keep using the regular ACPI driver and disable the
>> AXP288 FG to avoid reporting two batteries to userspace.
>>
>> Signed-off-by: Carlo Caione <carlo@endlessm.com>
>> ---
>
> It looks like this could be applied independently of the ACPI
> patches to the power-supply tree?
Yes this can be applied independently.
Regards,
Hans
>
> -- Sebastian
>
>> drivers/power/supply/axp288_fuel_gauge.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
>> index 4cc6e038dfdd..903891a9bcf0 100644
>> --- a/drivers/power/supply/axp288_fuel_gauge.c
>> +++ b/drivers/power/supply/axp288_fuel_gauge.c
>> @@ -708,6 +708,12 @@ static const struct dmi_system_id axp288_fuel_gauge_blacklist[] = {
>> DMI_MATCH(DMI_BOARD_VERSION, "V1.1"),
>> },
>> },
>> + {
>> + /* ECS EF20EA */
>> + .matches = {
>> + DMI_MATCH(DMI_PRODUCT_NAME, "EF20EA"),
>> + },
>> + },
>> {}
>> };
>>
>> --
>> 2.14.1
>>
next prev parent reply other threads:[~2018-02-19 9:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 8:26 [PATCH v2 0/3] power: supply: Fix AXP288 fallback when not needed Carlo Caione
2018-02-16 8:26 ` [PATCH v2 1/3] ACPI: AC/battery: Add quirk to avoid using PMIC Carlo Caione
2018-02-16 8:40 ` Rafael J. Wysocki
2018-02-16 8:26 ` [PATCH v2 2/3] ACPI: AC/battery: Add quirks for ECS EF20EA Carlo Caione
2018-02-16 8:26 ` [PATCH v2 3/3] power: supply: axp288_fuel_gauge: Do not register FG on " Carlo Caione
2018-02-16 14:26 ` Sebastian Reichel
2018-02-19 9:48 ` Hans de Goede [this message]
2018-02-16 8:41 ` [PATCH v2 0/3] power: supply: Fix AXP288 fallback when not needed Hans de Goede
2018-02-16 8:51 ` Rafael J. Wysocki
2018-02-16 8:52 ` Hans de Goede
2018-02-16 8:58 ` Carlo Caione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea75cd5f-9937-8b95-d96a-761fcd091594@redhat.com \
--to=hdegoede@redhat.com \
--cc=carlo@caione.org \
--cc=carlo@endlessm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=rjw@rjwysocki.net \
--cc=sre@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®