From: Paolo Bonzini <pbonzini@redhat.com>
To: Qian Cai <cai@lca.pw>
Cc: joe@perches.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: "KVM: x86: enable -Werror" breaks W=1 compilation
Date: Thu, 13 Feb 2020 18:23:55 +0100 [thread overview]
Message-ID: <ea7614c3-b917-a646-7e9f-27022062c9d7@redhat.com> (raw)
In-Reply-To: <1581601803.7365.57.camel@lca.pw>
On 13/02/20 14:50, Qian Cai wrote:
> People have been running W=1 to catch additional compilation warnings with an
> expectation that not all of warnings will be fixed, but the linux-next commit
> ead68df94d24 ("KVM: x86: enable -Werror") breaks the build for them.
>
> arch/x86/kvm/../../../virt/kvm/kvm_main.c:663:12: error: no previous prototype
> for ‘kvm_arch_post_init_vm’ [-Werror=missing-prototypes]
> int __weak kvm_arch_post_init_vm(struct kvm *kvm)
> ^~~~~~~~~~~~~~~~~~~~~
> arch/x86/kvm/../../../virt/kvm/kvm_main.c:672:13: error: no previous prototype
> for ‘kvm_arch_pre_destroy_vm’ [-Werror=missing-prototypes]
> void __weak kvm_arch_pre_destroy_vm(struct kvm *kvm)
Thanks, we already found two bugs, one of them real (it's from
-Wtype-limits). But I'll leave out this commit for now from the pull
request, of course.
Paolo
prev parent reply other threads:[~2020-02-13 17:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 13:50 Qian Cai
2020-02-13 17:23 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea7614c3-b917-a646-7e9f-27022062c9d7@redhat.com \
--to=pbonzini@redhat.com \
--cc=cai@lca.pw \
--cc=joe@perches.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®