From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B47CA242D72 for ; Wed, 20 Aug 2025 11:48:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755690540; cv=none; b=B6m8eAuFYGhU551dXwv0ZV6PBhN48C2PElmSVnLoVNeRxjeD7BJaIx2r8lQUrqiLdhc2Zw5Fcw/PIRuXb6FQk6+SPI0YQ+ZiCcjlojlxl7IwHj84JGgaRUbKffKlzlwm94sr4yfTx7rN3NI+ZxxGOJrFoqHsZ24QJMRW+C9NKyY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755690540; c=relaxed/simple; bh=Ur2PtnEjdCO2AWANEKmeCnsoDNWQXX7toc/InpKT2ZA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fp0nm3DQB6vsTXQLwVCByTP4arME6J36TnU8evpMUf3eT9a6OncXwy6dRqajtew4bnHsbWBp/EBGz2cxCZBK+LnsPYDMpcfnIOJjrvZDGLs/u3z70vVAqKhnvaBF6DBcvP1r0ruVVTRUxPmc7YqurQvfXb04IVarS4PqAxP5/3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MRVfdeCK; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MRVfdeCK" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-6197efa570eso8122040a12.1 for ; Wed, 20 Aug 2025 04:48:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755690537; x=1756295337; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oKQnyKTUV8fZ2I7ZjE3MCBFAplyOUWR7CQ7FlJCIiqU=; b=MRVfdeCKamu6EMesETZ0rQSHRAhD9jmR4V/00Bv6XubgMO7jv1C8aj0PuGF8HVV6Jq HXcnAlrzD6FK0YhKAmTyaRzGshi/RHbxSszYn8IXjG3Ofej5JmBt4kUmxWlor81eprj3 i4Q7yrWSaQwdlu0W93PoYj6Np8QkRkQ9dSWp6SNjQjgTPfxInesc+ltW+mdH6Q3yV9NO Bs8SH6VJE7ntcZ+DgL5WLLjuu8HbS70IpovxYqF8+8f9nw9S+39qmIREoXdQNVK5rwVr Z9wqU5vwII4+cp9slCq8w/qzyK0zde3x1FlrkNOCLh89Bcn/vrUz15hOhVFX7r1zV45y zh2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755690537; x=1756295337; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oKQnyKTUV8fZ2I7ZjE3MCBFAplyOUWR7CQ7FlJCIiqU=; b=rg7/mFAyRYjOclO4/Ay5h3WMsACBBVnEHKH+hnMn9seQ6KYWo36JlNB3cohY8fO3dB 4mK44fDKlNPSKhLyVxtWuLsC+aTdnEqMGQU43hppstZIn3/vLQbUli+Xy1BMW0sWoqYo m6+Zr91wtTr+hTwveRZYPy4E8yLg01FlMEsFoPChrEQC7SokMZLUNkxSMC/47yXV45Gt Roh9EgSQrzC8kVeEpdUBPbghyRGdmN02ADZgivlEBDCCQ7YfTCRsXwI9dVUn9iBEYlgS fEDX5+qlnH+GjHCfCsUoIF3ahadZT5xJ/X4qXeljmnne/jkLbHxMXAkA7IC5bSE66s1W VDgw== X-Forwarded-Encrypted: i=1; AJvYcCXGRr8CD01UOi9yRGkwgAFSfEXKF3dT71KSaCMvH0ngM83NvBAtNz6YkmFG3Asvajcyt3YXHhzFVV7FIsA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4hu58Bfr/xnfUsZS65d6LVymYh6WX4HFnURa/jwTdFJMILG8U wN70+P16K0W7c58S6qNJMOI1hrE+fecEPx188kHeoBLQvLcYn5jOnkjgKDVkzfmDbl0= X-Gm-Gg: ASbGncvgs4nke+MLSnhM4mEAEHqMVJJn1R3FTSQrnrffirRGd2lxnjyXRU/hMZgysJw lqBXR/brnYPbQclQ9vnWTzvP1jiIysL+GAy1SB01rzknxLNrbywwsXBDUy83tCJbDN7IiJSvMRo AtparrM8Dokmt5a+jnA9Too6t4h5sEjWm3ofsA4ZlXp6tcrDrCeq3sTdQ+D52B34BFQjexY2TJM D5dncXnOqj2BcvtPTVFmiRwjaVE6Gc4kCAFvh5YSc7u61pHVpqJ9dqNToWVeeTUd8j3sb5nLFCK uWmA9W08DSp1YvTQjIQKhkdTPilPoVwYh6UZJDcIkhZw8yFvNXLcljUTun1UVj+AH81GJmdVABP rYUjxRBc10hs5iRXEOh50mEI8o5KN8jn+48CCySIheWq/Z2tZfc/F4Q87xZ6IDwU= X-Google-Smtp-Source: AGHT+IFXB9ifQgnia7Vr9YjH5EEe9FNqq1rPflzG82G56ljPGXhRGo0c75JH6Cotm/rGzsChagXmHw== X-Received: by 2002:a05:6402:34d3:b0:615:ac6c:7ea6 with SMTP id 4fb4d7f45d1cf-61a97624cc1mr2109562a12.24.1755690536980; Wed, 20 Aug 2025 04:48:56 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-61a7579f799sm3299893a12.47.2025.08.20.04.48.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Aug 2025 04:48:56 -0700 (PDT) Message-ID: Date: Wed, 20 Aug 2025 12:48:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/11] soc: qcom: mdtloader: Add context aware qcom_mdt_pas_load() helper To: Mukesh Ojha , Bjorn Andersson , Konrad Dybcio , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Mathieu Poirier Cc: Abhinav Kumar , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, linux-remoteproc@vger.kernel.org References: <20250819165447.4149674-1-mukesh.ojha@oss.qualcomm.com> <20250819165447.4149674-3-mukesh.ojha@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20250819165447.4149674-3-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19/08/2025 17:54, Mukesh Ojha wrote: > Currently, remoteproc and non-remoteproc subsystems use different > variants of the MDT loader helper API, primarily due to the handling of > the metadata context. Remoteproc subsystems retain this context until > authentication and reset, while non-remoteproc subsystems (e.g., video, > graphics) do not require it. > > Add context aware qcom_mdt_pas_load() function which uses context > returned from qcom_scm_pas_ctx_init() and use it till subsystems > is out of set. This will also help in unifying the API used by > remoteproc and non-remoteproc subsystems drivers. > > Signed-off-by: Mukesh Ojha > --- > If this approach is preferred, will convert all subsystem drivers to use the > same set of API's using context and completely get away with qcom_mdt_load() > > -Mukesh > > drivers/remoteproc/qcom_q6v5_pas.c | 53 ++++++++++++++--------------- > drivers/soc/qcom/mdt_loader.c | 26 ++++++++++---- > include/linux/soc/qcom/mdt_loader.h | 22 ++++++------ > 3 files changed, 56 insertions(+), 45 deletions(-) > > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c > index 55a7da801183..e376c0338576 100644 > --- a/drivers/remoteproc/qcom_q6v5_pas.c > +++ b/drivers/remoteproc/qcom_q6v5_pas.c > @@ -115,8 +115,8 @@ struct qcom_pas { > struct qcom_rproc_ssr ssr_subdev; > struct qcom_sysmon *sysmon; > > - struct qcom_scm_pas_metadata pas_metadata; > - struct qcom_scm_pas_metadata dtb_pas_metadata; > + struct qcom_scm_pas_ctx *pas_ctx; > + struct qcom_scm_pas_ctx *dtb_pas_ctx; > }; > > static void qcom_pas_segment_dump(struct rproc *rproc, > @@ -209,9 +209,9 @@ static int qcom_pas_unprepare(struct rproc *rproc) > * auth_and_reset() was successful, but in other cases clean it up > * here. > */ > - qcom_scm_pas_metadata_release(&pas->pas_metadata); > + qcom_scm_pas_metadata_release(pas->pas_ctx->metadata); > if (pas->dtb_pas_id) > - qcom_scm_pas_metadata_release(&pas->dtb_pas_metadata); > + qcom_scm_pas_metadata_release(pas->dtb_pas_ctx->metadata); > > return 0; > } > @@ -235,15 +235,8 @@ static int qcom_pas_load(struct rproc *rproc, const struct firmware *fw) > return ret; > } > > - ret = qcom_mdt_pas_init(pas->dev, pas->dtb_firmware, pas->dtb_firmware_name, > - pas->dtb_pas_id, pas->dtb_mem_phys, > - &pas->dtb_pas_metadata); > - if (ret) > - goto release_dtb_firmware; > - > - ret = qcom_mdt_load_no_init(pas->dev, pas->dtb_firmware, pas->dtb_firmware_name, > - pas->dtb_mem_region, pas->dtb_mem_phys, > - pas->dtb_mem_size, &pas->dtb_mem_reloc); > + ret = qcom_mdt_pas_load(pas->dtb_pas_ctx, pas->dtb_firmware, pas->dtb_firmware_name, > + pas->dtb_mem_region, &pas->dtb_mem_reloc); > if (ret) > goto release_dtb_metadata; > } > @@ -251,9 +244,7 @@ static int qcom_pas_load(struct rproc *rproc, const struct firmware *fw) > return 0; > > release_dtb_metadata: > - qcom_scm_pas_metadata_release(&pas->dtb_pas_metadata); > - > -release_dtb_firmware: > + qcom_scm_pas_metadata_release(pas->dtb_pas_ctx->metadata); > release_firmware(pas->dtb_firmware); > > return ret; > @@ -301,14 +292,8 @@ static int qcom_pas_start(struct rproc *rproc) > } > } > > - ret = qcom_mdt_pas_init(pas->dev, pas->firmware, rproc->firmware, pas->pas_id, > - pas->mem_phys, &pas->pas_metadata); > - if (ret) > - goto disable_px_supply; > - > - ret = qcom_mdt_load_no_init(pas->dev, pas->firmware, rproc->firmware, > - pas->mem_region, pas->mem_phys, pas->mem_size, > - &pas->mem_reloc); > + ret = qcom_mdt_pas_load(pas->pas_ctx, pas->firmware, rproc->firmware, > + pas->mem_region, &pas->dtb_mem_reloc); > if (ret) > goto release_pas_metadata; > > @@ -328,9 +313,9 @@ static int qcom_pas_start(struct rproc *rproc) > goto release_pas_metadata; > } > > - qcom_scm_pas_metadata_release(&pas->pas_metadata); > + qcom_scm_pas_metadata_release(pas->pas_ctx->metadata); > if (pas->dtb_pas_id) > - qcom_scm_pas_metadata_release(&pas->dtb_pas_metadata); > + qcom_scm_pas_metadata_release(pas->dtb_pas_ctx->metadata); > > /* firmware is used to pass reference from qcom_pas_start(), drop it now */ > pas->firmware = NULL; > @@ -338,9 +323,9 @@ static int qcom_pas_start(struct rproc *rproc) > return 0; > > release_pas_metadata: > - qcom_scm_pas_metadata_release(&pas->pas_metadata); > + qcom_scm_pas_metadata_release(pas->pas_ctx->metadata); > if (pas->dtb_pas_id) > - qcom_scm_pas_metadata_release(&pas->dtb_pas_metadata); > + qcom_scm_pas_metadata_release(pas->dtb_pas_ctx->metadata); > disable_px_supply: > if (pas->px_supply) > regulator_disable(pas->px_supply); > @@ -774,6 +759,18 @@ static int qcom_pas_probe(struct platform_device *pdev) > } > > qcom_add_ssr_subdev(rproc, &pas->ssr_subdev, desc->ssr_name); > + > + pas->pas_ctx = qcom_scm_pas_ctx_init(pas->dev, pas->pas_id, pas->mem_phys, > + pas->mem_size, true); > + if (!pas->pas_ctx) > + goto remove_ssr_sysmon; this function already returns -ENOMEM you don't set ret to any particular value so if qcom_scm_pas_ctx_init() returned NULL, you would exit your probe function here "error out" with returning ret = 0 Please ERR_PTR() in qcom_scm_pas_ctx_init() and return the error up the call stack via your remove_ssr_sysmon jump label. --- bod