From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757522AbdJLWzw (ORCPT ); Thu, 12 Oct 2017 18:55:52 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:54419 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753789AbdJLWzu (ORCPT ); Thu, 12 Oct 2017 18:55:50 -0400 X-Google-Smtp-Source: ABhQp+Rat9504LejbcfMny3Ydh10hS4alJwrH18UUDGlMOqP6dhjonJEc0f5QTlEaUILK41UrTzZ/w== Subject: Re: [PATCH net-next 2/5] net: dsa: add slave notify helper To: Vivien Didelot , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn References: <20171012225156.20758-1-vivien.didelot@savoirfairelinux.com> <20171012225156.20758-3-vivien.didelot@savoirfairelinux.com> From: Florian Fainelli Message-ID: Date: Thu, 12 Oct 2017 15:55:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171012225156.20758-3-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/2017 03:51 PM, Vivien Didelot wrote: > Both DSA slave create and destroy functions call call_dsa_notifiers with > respectively DSA_PORT_REGISTER and DSA_PORT_UNREGISTER and the same > dsa_notifier_register_info structure. > > Wrap this in a dsa_slave_notify helper so prevent cluttering these > functions. > > Signed-off-by: Vivien Didelot Much nicer, thanks! Reviewed-by: Florian Fainelli -- Florian