From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33E04C77B7C for ; Sun, 21 May 2023 06:42:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229805AbjEUGmR (ORCPT ); Sun, 21 May 2023 02:42:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbjEUGmQ (ORCPT ); Sun, 21 May 2023 02:42:16 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D79C8FE; Sat, 20 May 2023 23:42:14 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 43B9A5C00A9; Sun, 21 May 2023 02:42:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 21 May 2023 02:42:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1684651334; x=1684737734; bh=gPrys0vkcHlGP tYBYK6F1sl19b9RAU8HqVL8+AFxLlo=; b=VWqKkBivBtd2iP7BGLrKU5gLDxY98 MGwWLvrkkjzbsf6HJPJa5e9DEShpcoDjUoAn0NW+k5shcZranVkXkKqxUUSqM2v3 E/MPWeAiaqIxPmjSj0vFXLSXYzeEnJmseRZN9jzsbtfMsZjfdfJl9Xv+P4MP8uFZ vanWQzdRAeUMF/KB/2frT1EtQbf/sd0NGgmtH1FRDtGNfMlvbWaEvaDVaxUfa1qz 1tM6ZiMSwkF39V6gAcqgXPHQpbSrxgGWBbAsvTKSe40Ky3g7WHd90zk2BU8EixFE 0D/oMtiUE28Ga01+vzwx6XuD/iyUAvYSYFZPXPdn16SMdnelFoldMzTPA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeikedguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefujgfkfhggtgesthdtredttddtvdenucfhrhhomhephfhinhhn ucfvhhgrihhnuceofhhthhgrihhnsehlihhnuhigqdhmieekkhdrohhrgheqnecuggftrf grthhtvghrnhepfeeiheejvdetgfeitddutefhkeeilefhveehgfdvtdekkedvkeehffdt keevvdeunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehfthhhrghinheslhhinhhugidqmhei kehkrdhorhhg X-ME-Proxy: Feedback-ID: i58a146ae:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 21 May 2023 02:42:10 -0400 (EDT) Date: Sun, 21 May 2023 16:42:15 +1000 (AEST) From: Finn Thain To: Tejun Heo cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org, kernel-team@meta.com, Michael Schmitz , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: Re: [PATCH RESEND 01/13] scsi: ncr53c8xx: Use default @max_active for hostdata->work_q In-Reply-To: Message-ID: References: <20230509015032.3768622-1-tj@kernel.org> <20230509015032.3768622-2-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 20 May 2023, Tejun Heo wrote: > From: Tejun Heo > Subject: scsi: ncr53c8xx: Use default @max_active for hostdata->work_q > This driver is normally referred to as ncr5380 or NCR5380. (It doesn't support any other member of the 538x family.) > hostdata->work_q only hosts a single work item, hostdata->main_task, and > thus doesn't need explicit concurrency limit. Let's use the default > @max_active. This doesn't cost anything and clearly expresses that > @max_active doesn't matter. > > Signed-off-by: Tejun Heo Acked-by: Finn Thain > Cc: Finn Thain > Cc: Michael Schmitz > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" > Cc: linux-scsi@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > Hello, > > Resending because I screwed up the cc list in the original posting. The > whole series can be viewed at: > > http://lkml.kernel.org/r/20230509015032.3768622-1-tj@kernel.org > > It's not a must but it'd be great if I can route this through the > workqueue tree so that it can go together with other related and > followup cleanups. > > Thanks. > No objection from me. I guess it's Martin's call?