From: Adrian Hunter <adrian.hunter@intel.com>
To: Donglin Peng <dolinux.peng@gmail.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
peterz@infradead.org
Subject: Re: [PATCH] perf tools: exclude the include/perf/ directory
Date: Thu, 3 Nov 2022 09:08:32 +0200 [thread overview]
Message-ID: <ea7fba87-6132-5f05-6c1c-7afc8d576b89@intel.com> (raw)
In-Reply-To: <20221103040321.56233-1-dolinux.peng@gmail.com>
On 3/11/22 06:03, Donglin Peng wrote:
> Commit 3af1dfdd51e0 ("perf build: Move perf_dlfilters.h in the
> source tree") moved perf_dlfilters.h to the include/perf/ directory
> without updating the .gitignore file, causing new files in the
> include/perf/ directory will be ignored.
Note:
include/perf is ignored because it has 'perf' in the name
Can check:
Before:
$ touch tools/perf/include/perf/junk
$ git status | grep junk
$ git check-ignore -v tools/perf/include/perf/junk
tools/perf/.gitignore:6:perf tools/perf/include/perf/junk
After:
$ git status | grep junk
tools/perf/include/perf/junk
$ git check-ignore -v tools/perf/include/perf/junk
>
> Add !include/perf/ to perf's .gitignore file.
>
> Signed-off-by: Donglin Peng <dolinux.peng@gmail.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore
> index a653311d9693..fd7a6ff9e7aa 100644
> --- a/tools/perf/.gitignore
> +++ b/tools/perf/.gitignore
> @@ -4,6 +4,7 @@ PERF-GUI-VARS
> PERF-VERSION-FILE
> FEATURE-DUMP
> perf
> +!include/perf/
> perf-read-vdso32
> perf-read-vdsox32
> perf-help
next prev parent reply other threads:[~2022-11-03 7:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 4:03 Donglin Peng
2022-11-03 7:08 ` Adrian Hunter [this message]
2022-11-03 8:07 ` Donglin Peng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea7fba87-6132-5f05-6c1c-7afc8d576b89@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=dolinux.peng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®