From: "Yanchao Yang (杨彦超)" <Yanchao.Yang@mediatek.com>
To: "kuba@kernel.org" <kuba@kernel.org>
Cc: "Chris Feng (冯保林)" <Chris.Feng@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Mingliang Xu (徐明亮)" <mingliang.xu@mediatek.com>,
"Min Dong (董敏)" <min.dong@mediatek.com>,
"linuxwwan@intel.com" <linuxwwan@intel.com>,
"m.chetan.kumar@intel.com" <m.chetan.kumar@intel.com>,
"Liang Lu (吕亮)" <liang.lu@mediatek.com>,
"Haijun Liu (刘海军)" <haijun.liu@mediatek.com>,
"Haozhe Chang (常浩哲)" <Haozhe.Chang@mediatek.com>,
"Hua Yang (杨华)" <Hua.Yang@mediatek.com>,
"ryazanov.s.a@gmail.com" <ryazanov.s.a@gmail.com>,
"Xiayu Zhang (张夏宇)" <Xiayu.Zhang@mediatek.com>,
"loic.poulain@linaro.org" <loic.poulain@linaro.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"Ting Wang (王挺)" <ting.wang@mediatek.com>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Aiden Wang (王咏麒)" <Aiden.Wang@mediatek.com>,
"Felix Chen (陈非)" <Felix.Chen@mediatek.com>,
"Lambert Wang (王伟)" <Lambert.Wang@mediatek.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"Mingchuang Qiao (乔明闯)" <Mingchuang.Qiao@mediatek.com>,
"Guohao Zhang (张国豪)" <Guohao.Zhang@mediatek.com>
Subject: Re: [PATCH net-next v2 08/12] net: wwan: tmi: Add data plane transaction layer
Date: Sun, 29 Jan 2023 08:51:00 +0000 [thread overview]
Message-ID: <ea8001238622a81bfb89dbdc35a6604914a4d052.camel@mediatek.com> (raw)
In-Reply-To: <20230119195210.03537a93@kernel.org>
Hi Jakub,
sorry for late response, please check following reply.
On Thu, 2023-01-19 at 19:52 -0800, Jakub Kicinski wrote:
> On Wed, 18 Jan 2023 19:38:55 +0800 Yanchao Yang wrote:
> > drivers/net/wwan/mediatek/mtk_dpmaif.c | 4005
> > ++++++++++++++++++++
>
> clang detects out-of-bound memcpy/strcpy or such somewhere in this
> file.
> Please fix that.
Ok, we will check and fix it.
>
> Please try to make the series smaller than 17,770 :/
> Strip stuff down to minimal working version.
> I don't think anyone can review 17kLoC in one sitting :/
Thank your suggestion. I agree with you. Considering both the control
plane and data plane are the minimal function for TMI driver, other
functions can be removed and submitted after the initial version is
approved. The whole patch can be reduced about 2k lines. Is it ok? Or
do you have any more suggestions? Please help share it.
Many thanks.
yanchao.yang
next prev parent reply other threads:[~2023-01-29 8:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 11:38 [PATCH net-next v2 00/12] net: wwan: tmi: PCIe driver for MediaTek M.2 modem Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 01/12] net: wwan: tmi: Add PCIe core Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 02/12] net: wwan: tmi: Add control plane transaction layer Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 03/12] net: wwan: tmi: Add control DMA interface Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 04/12] net: wwan: tmi: Add control port Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 05/12] net: wwan: tmi: Add FSM thread Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 06/12] net: wwan: tmi: Add AT & MBIM WWAN ports Yanchao Yang
2023-01-21 21:46 ` kernel test robot
2023-01-18 11:38 ` [PATCH net-next v2 07/12] net: wwan: tmi: Introduce data plane hardware interface Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 08/12] net: wwan: tmi: Add data plane transaction layer Yanchao Yang
2023-01-20 3:52 ` Jakub Kicinski
2023-01-29 8:51 ` Yanchao Yang (杨彦超) [this message]
[not found] ` <20230130120540.6ef059a3@kernel.org>
2023-02-11 8:49 ` Yanchao Yang (杨彦超)
2023-01-18 11:38 ` [PATCH net-next v2 09/12] net: wwan: tmi: Introduce WWAN interface Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 10/12] net: wwan: tmi: Add exception handling service Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 11/12] net: wwan: tmi: Add power management support Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 12/12] net: wwan: tmi: Add maintainers and documentation Yanchao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea8001238622a81bfb89dbdc35a6604914a4d052.camel@mediatek.com \
--to=yanchao.yang@mediatek.com \
--cc=Aiden.Wang@mediatek.com \
--cc=Chris.Feng@mediatek.com \
--cc=Felix.Chen@mediatek.com \
--cc=Guohao.Zhang@mediatek.com \
--cc=Haozhe.Chang@mediatek.com \
--cc=Hua.Yang@mediatek.com \
--cc=Lambert.Wang@mediatek.com \
--cc=Mingchuang.Qiao@mediatek.com \
--cc=Xiayu.Zhang@mediatek.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haijun.liu@mediatek.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=liang.lu@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linuxwwan@intel.com \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@intel.com \
--cc=min.dong@mediatek.com \
--cc=mingliang.xu@mediatek.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryazanov.s.a@gmail.com \
--cc=ting.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®