From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Kiryl Shutsemau <kirill@shutemov.name>,
Andrew Morton <akpm@linux-foundation.org>,
"David Hildenbrand (Arm)" <david@kernel.org>,
"Lorenzo Stoakes (ARM)" <ljs@kernel.org>,
Mike Rapoport <rppt@kernel.org>
Cc: "Kiryl Shutsemau (Meta)" <kas@kernel.org>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Muhammad Usama Anjum <usama.anjum@arm.com>,
Usama Arif <usama.arif@linux.dev>,
"Nico Pache (Red Hat)" <nico.pache@linux.dev>,
Zi Yan <ziy@nvidia.com>, Barry Song <baohua@kernel.org>,
Dev Jain <dev.jain@arm.com>, Hugh Dickins <hughd@google.com>,
Lance Yang <lance.yang@linux.dev>,
"Liam R. Howlett" <liam@infradead.org>,
Michal Hocko <mhocko@suse.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Shuah Khan <shuah@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
"Vlastimil Babka (SUSE)" <vbabka@kernel.org>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
kernel-team@meta.com
Subject: Re: [PATCH v6 12/19] selftests/mm: parameterize the mixed-source collapse case by source order
Date: Wed, 23 Sep 2026 14:55:39 +0800 [thread overview]
Message-ID: <ea81ccb2-d316-47fe-93ae-ef32af2a7330@linux.alibaba.com> (raw)
In-Reply-To: <20260919002451.496763-13-kirill@shutemov.name>
On 9/19/26 8:24 AM, Kiryl Shutsemau wrote:
> From: "Kiryl Shutsemau (Meta)" <kas@kernel.org>
>
> collapse_order_mixed_sources() faults its region as order-2 folios and
> collapses them to the -c target. Order 2 is below the contpte size on
> every arm64 page size, so nothing in this suite collapses a contpte-mapped
> source on purpose.
>
> Let -s name the source order alongside -c. The case then faults at that
> order, keeping order 2 when -s is absent, and the source order has to be a
> supported mTHP order below the target. The other mTHP cases are
> unaffected: mthp_push_target_order() enables only the target order.
>
> A -c at or below -s is refused before any case runs: the sources would
> already be the size being asked for. Without the check the generic cases
> fail on that one by one instead of saying why.
>
> "-s 5 -c 7" on arm64/64K then collapses contpte-mapped sources into a
> larger mTHP.
>
> Assisted-by: LLM
> Acked-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> Tested-by: Muhammad Usama Anjum <usama.anjum@arm.com>
> Signed-off-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
> ---
LGTM.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Tested-by: Baolin Wang <baolin.wang@linux.alibaba.com>
next prev parent reply other threads:[~2026-09-23 6:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 0:24 [PATCH v6 00/19] selftests/mm: improve khugepaged coverage Kiryl Shutsemau
2026-09-19 0:24 ` [PATCH v6 01/19] selftests/mm: raise the khugepaged test-case cap Kiryl Shutsemau
2026-09-19 0:24 ` [PATCH v6 02/19] selftests/mm: skip collapse_compound_extreme() where the PMD is too large Kiryl Shutsemau
2026-09-19 0:24 ` [PATCH v6 03/19] selftests/mm: scale khugepaged's collapse wait with the PMD size Kiryl Shutsemau
2026-09-19 0:24 ` [PATCH v6 04/19] selftests/mm: skip khugepaged page cache cases without a PMD folio Kiryl Shutsemau
2026-09-19 0:24 ` [PATCH v6 05/19] selftests/mm: make the swap cases' swapout reliable Kiryl Shutsemau
2026-09-19 0:24 ` [PATCH v6 06/19] selftests/mm: stop khugepaged during the MADV_COLLAPSE cases Kiryl Shutsemau
2026-09-23 6:25 ` Baolin Wang
2026-09-19 0:24 ` [PATCH v6 07/19] selftests/mm: move is_backed_by_folio() into vm_util Kiryl Shutsemau
2026-09-19 0:24 ` [PATCH v6 08/19] selftests/mm: add folio-order check for address ranges Kiryl Shutsemau
2026-09-19 0:24 ` [PATCH v6 09/19] selftests/mm: add folio-order detection self-check Kiryl Shutsemau
2026-09-19 0:24 ` [PATCH v6 10/19] selftests/mm: add khugepaged completion barrier helper Kiryl Shutsemau
2026-09-19 0:24 ` [PATCH v6 11/19] selftests/mm: add order-parameterized khugepaged collapse cases Kiryl Shutsemau
2026-09-23 6:50 ` Baolin Wang
2026-09-19 0:24 ` [PATCH v6 12/19] selftests/mm: parameterize the mixed-source collapse case by source order Kiryl Shutsemau
2026-09-23 6:55 ` Baolin Wang [this message]
2026-09-19 0:24 ` [PATCH v6 13/19] selftests/mm: cover a shared-source collapse write race Kiryl Shutsemau
2026-09-19 0:24 ` [PATCH v6 14/19] selftests/mm: run every supported collapse order by default Kiryl Shutsemau
2026-09-19 0:24 ` [PATCH v6 15/19] selftests/mm: check that one khugepaged pass collapses one window Kiryl Shutsemau
2026-09-19 0:24 ` [PATCH v6 16/19] selftests/mm: add khugepaged race harness Kiryl Shutsemau
2026-09-19 0:24 ` [PATCH v6 17/19] selftests/mm: race the collapse of windows with holes Kiryl Shutsemau
2026-09-19 0:24 ` [PATCH v6 18/19] selftests/mm: add memory-pressure threads to the khugepaged race harness Kiryl Shutsemau
2026-09-19 0:24 ` [PATCH v6 19/19] selftests/mm: zap whole PTE tables in " Kiryl Shutsemau
2026-09-20 23:54 ` [PATCH v6 00/19] selftests/mm: improve khugepaged coverage Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea81ccb2-d316-47fe-93ae-ef32af2a7330@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=jgg@ziepe.ca \
--cc=kas@kernel.org \
--cc=kernel-team@meta.com \
--cc=kirill@shutemov.name \
--cc=lance.yang@linux.dev \
--cc=leon@kernel.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=nico.pache@linux.dev \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=usama.anjum@arm.com \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®