From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756236AbcHBHNY (ORCPT ); Tue, 2 Aug 2016 03:13:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:56947 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755447AbcHBHNR (ORCPT ); Tue, 2 Aug 2016 03:13:17 -0400 Subject: Re: [Xen-devel] [PATCH v2] xen: Make VPMU init message look less scary To: Jan Beulich References: <1470120213-16683-1-git-send-email-jgross@suse.com> <57A0636A0200007800101998@suse.com> Cc: david.vrabel@citrix.com, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org From: Juergen Gross Message-ID: Date: Tue, 2 Aug 2016 09:12:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <57A0636A0200007800101998@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/16 09:10, Jan Beulich wrote: >>>> On 02.08.16 at 08:43, wrote: >> --- a/arch/x86/xen/pmu.c >> +++ b/arch/x86/xen/pmu.c >> @@ -547,8 +547,11 @@ void xen_pmu_init(int cpu) >> return; >> >> fail: >> - pr_info_once("Could not initialize VPMU for cpu %d, error %d\n", >> - cpu, err); >> + if (err == -EOPNOTSUPP) >> + pr_info_once("VPMU disabled by hypervisor.\n"); >> + else >> + pr_info_once("Could not initialize VPMU for cpu %d, error %d\n", >> + cpu, err); > > I'm sorry for not already having thought about this for v1, but > what about older hypervisors, where the hypercall would return > -ENOSYS? I wasn't aware of that possibility. It should be covered, of course! V3 will be sent soon... Thanks for noticing now, Juergen