From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: "Christian König" <christian.koenig@amd.com>,
jie1zhan <jesse.zhang@amd.com>,
broonie@kernel.org, dri-devel-bounces@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Cc: Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, ajitkumar.pandey@amd.com,
lucas.demarchi@intel.com, nirmoy.das@linux.intel.com,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] drm/syncobj: Fix sync syncobj issue
Date: Tue, 12 Jul 2022 17:22:03 +0300 [thread overview]
Message-ID: <ea892ffc-4a03-7772-6d99-85a356a3738b@intel.com> (raw)
In-Reply-To: <22a21338-305d-bdf7-0079-df67fb030fc7@amd.com>
I'll let Lucas comment. I've only looked a little at it.
From what I remember just enabling sw_signaling was enough to fix the
issue.
-Lionel
On 12/07/2022 13:26, Christian König wrote:
> Ping to the Intel guys here. Especially Lucas/Nirmoy/Lionel.
>
> IIRC you stumbled over that problem as well, have you found any solution?
>
> Regards,
> Christian.
>
> Am 07.07.22 um 12:29 schrieb jie1zhan:
>> enable signaling after flatten dma_fence_chains on transfer
>>
>> Signed-off-by: jie1zhan <jesse.zhang@amd.com>
>> ---
>> drivers/gpu/drm/drm_syncobj.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/drm_syncobj.c
>> b/drivers/gpu/drm/drm_syncobj.c
>> index 7e48dcd1bee4..0d9d3577325f 100644
>> --- a/drivers/gpu/drm/drm_syncobj.c
>> +++ b/drivers/gpu/drm/drm_syncobj.c
>> @@ -920,6 +920,7 @@ static int
>> drm_syncobj_transfer_to_timeline(struct drm_file *file_private,
>> if (ret)
>> goto err_free_fence;
>> + dma_fence_enable_sw_signaling(fence);
>> chain = dma_fence_chain_alloc();
>> if (!chain) {
>> ret = -ENOMEM;
>
next prev parent reply other threads:[~2022-07-12 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 10:29 jie1zhan
2022-07-12 10:26 ` Christian König
2022-07-12 14:22 ` Lionel Landwerlin [this message]
2022-07-12 14:57 ` Christian König
2022-07-13 8:42 ` Das, Nirmoy
2022-07-13 9:15 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea892ffc-4a03-7772-6d99-85a356a3738b@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=airlied@linux.ie \
--cc=ajitkumar.pandey@amd.com \
--cc=broonie@kernel.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel-bounces@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesse.zhang@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nirmoy.das@linux.intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®