mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sander Vanheule <sander@svanheule.net>
To: "Rob Herring (Arm)" <robh@kernel.org>,
	Wim Van Sebroeck	 <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	 Gregory Clement <gregory.clement@bootlin.com>
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: watchdog: Convert marvell,orion-wdt to DT schema
Date: Tue, 14 Oct 2025 22:22:08 +0200	[thread overview]
Message-ID: <ea8a57e4464f832d4cce1101d763b56674a1bf6d.camel@svanheule.net> (raw)
In-Reply-To: <20251013213146.695195-1-robh@kernel.org>

Hi Rob,

On Mon, 2025-10-13 at 16:31 -0500, Rob Herring (Arm) wrote:
> -Clocks required for compatibles = "marvell,orion-wdt",
> -				  "marvell,armada-370-wdt":
> -- clocks : Must contain a single entry describing the clock input
> -
> -Clocks required for compatibles = "marvell,armada-xp-wdt"
> -				  "marvell,armada-375-wdt"
> -				  "marvell,armada-380-wdt":
> -- clocks : Must contain an entry for each entry in clock-names.
> -- clock-names : Must include the following entries:
> -  "nbclk" (L2/coherency fabric clock),
> -  "fixed" (Reference 25 MHz fixed-clock).

> +  clocks:
> +    minItems: 1
> +    items:
> +      - description: Reference 25 MHz fixed-clock supply.
> +      - description: L2/coherency fabric clock input ("nbclk").
> +
> +  clock-names:
> +    minItems: 1
> +    items:
> +      - const: nbclk
> +      - const: fixed

Shouldn't the "clock-names" items be in the same order as the "clocks" items?
(With nbclk first)

Best,
Sander

  parent reply	other threads:[~2025-10-14 20:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13 21:31 Rob Herring (Arm)
2025-10-14  9:45 ` Gregory CLEMENT
2025-10-14 11:21   ` Rob Herring
2025-10-14 12:39     ` Gregory CLEMENT
2025-10-14 14:56 ` Guenter Roeck
2025-10-14 20:22 ` Sander Vanheule [this message]
2025-10-14 22:33   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea8a57e4464f832d4cce1101d763b56674a1bf6d.camel@svanheule.net \
    --to=sander@svanheule.net \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®