mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jyri Sarha <jyri.sarha@iki.fi>
To: Dario Binacchi <dariobin@libero.it>
Cc: linux-kernel@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
	David Airlie <airlied@linux.ie>,
	Tomi Valkeinen <tomba@kernel.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 0/3] drm/tilcdc: fix LCD pixel clock setting
Date: Tue, 23 Mar 2021 14:05:59 +0200	[thread overview]
Message-ID: <ea8c24d101444baf61cdaae62a320d9e@iki.fi> (raw)
In-Reply-To: <20210322213337.26667-1-dariobin@libero.it>

Thanks,

Reviewed-by: Jyri Sarha <jyri.sarha@iki.fi>
for the series.

I'll merge these later today.

Best regards,
Jyri

On 2021-03-22 23:33, Dario Binacchi wrote:
> The series was born from a patch to fix the LCD pixel clock setting.
> Two additional patches have been added to this. One renames a 
> misleading
> variable name that was probably the cause of the bug and the other 
> fixes
> a warning message.
> 
> 
> Changes in v3:
> - Replace calculated with requested in the warning message.
> - Swap the positions of the real_pclk_rate, and pclk_rate parameters
>   in the warning message.
> 
> Changes in v2:
> - The patch has been added in version 2.
> - Rename clk_div_rate to real_pclk_rate.
> - Provide pixel clock rate to tilcdc_pclk_diff().
> - The patch has been added in version 2.
> 
> Dario Binacchi (3):
>   drm/tilcdc: rename req_rate to pclk_rate
>   drm/tilcdc: fix LCD pixel clock setting
>   drm/tilcdc: fix pixel clock setting warning message
> 
>  drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)

      parent reply	other threads:[~2021-03-23 12:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 21:33 Dario Binacchi
2021-03-22 21:33 ` [PATCH v3 1/3] drm/tilcdc: rename req_rate to pclk_rate Dario Binacchi
2021-03-22 21:33 ` [PATCH v3 2/3] drm/tilcdc: fix LCD pixel clock setting Dario Binacchi
2021-03-22 21:33 ` [PATCH v3 3/3] drm/tilcdc: fix pixel clock setting warning message Dario Binacchi
2021-03-23 12:05 ` Jyri Sarha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea8c24d101444baf61cdaae62a320d9e@iki.fi \
    --to=jyri.sarha@iki.fi \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dariobin@libero.it \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomba@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®