mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Moritz Fischer <mdf@kernel.org>, linux-kernel@vger.kernel.org
Cc: dmaengine@vger.kernel.org, vinod.koul@intel.com,
	dan.j.williams@intel.com
Subject: Re: [PATCH 2/2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
Date: Thu, 26 Apr 2018 18:27:00 +0200	[thread overview]
Message-ID: <ea8d2aaf-c627-9c6e-55f3-57acbfd09498@metafoo.de> (raw)
In-Reply-To: <20180426161239.15234-2-mdf@kernel.org>

On 04/26/2018 06:12 PM, Moritz Fischer wrote:
> Request IRQ with IRQF_SHARED flag. This works since the interrupt
> handler already checks if there is an actual IRQ pending and returns
> IRQ_NONE otherwise.
> 
> Signed-off-by: Moritz Fischer <mdf@kernel.org>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks.

> ---
>  drivers/dma/dma-axi-dmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index 75ccedaa96d2..2bd195532882 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -688,7 +688,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
>  		goto err_unregister_device;
>  
>  	ret = devm_request_irq(&pdev->dev, dmac->irq,
> -			       axi_dmac_interrupt_handler, 0,
> +			       axi_dmac_interrupt_handler, IRQF_SHARED,
>  			       dev_name(&pdev->dev), dmac);
>  	if (ret)
>  		goto err_unregister_of;
> 

  reply	other threads:[~2018-04-26 16:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26 16:12 [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq() Moritz Fischer
2018-04-26 16:12 ` [PATCH 2/2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED Moritz Fischer
2018-04-26 16:27   ` Lars-Peter Clausen [this message]
2018-04-26 16:26 ` [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq() Lars-Peter Clausen
2018-04-26 16:43   ` Moritz Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea8d2aaf-c627-9c6e-55f3-57acbfd09498@metafoo.de \
    --to=lars@metafoo.de \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®