From: "Marcin Obara" <marcin_obara@users.sourceforge.net>
To: Valdis.Kletnieks@vt.edu
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
"Marcel Selhorst" <tpm@selhorst.net>,
"Kylene Jo Hall" <kjhall@us.ibm.com>,
tpmdd-devel@lists.sourceforge.net
Subject: Re: [PATCH] 2.6.26-mmotm tpm-correct-tpm-timeouts-to-jiffies-conversion-d820-fix.patch
Date: Sat, 26 Jul 2008 20:27:33 +0100 [thread overview]
Message-ID: <ea8d860a0807261227w66e29978uecd12cf1fcb915d1@mail.gmail.com> (raw)
In-Reply-To: <15114.1217045033@turing-police.cc.vt.edu>
2008/7/26 <Valdis.Kletnieks@vt.edu>:
> + if (chip->vendor.duration[TPM_SHORT] == 1)
> + chip->vendor.duration[TPM_SHORT] *= 1000;
> +
> chip->vendor.duration[TPM_MEDIUM] =
> usecs_to_jiffies(be32_to_cpu
> (*((__be32 *) (data +
Value in chip->vendor.duration[TPM_SHORT] is in jiffies not in milliseconds.
(As I know it's not the same. Jiffy is in range 1-10 ms.)
I know the result may be the same, but it is unclear.
Maybe... value should be compared (to 1000) before conversion?
or...
If after conversion, there should be something like this:
if (chip->vendor.duration[TPM_SHORT] < (HZ/100)) /* less
than 10ms ? */
chip->vendor.duration[TPM_SHORT] = HZ;
What do you think?
Regards
Marcin
next prev parent reply other threads:[~2008-07-26 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080725164614.044a526e.akpm@linux-foundation.org>
[not found] ` <50684.1217035060@turing-police.cc.vt.edu>
[not found] ` <20080725185115.5d1a107d.akpm@linux-foundation.org>
2008-07-26 4:03 ` Valdis.Kletnieks
2008-07-26 19:27 ` Marcin Obara [this message]
2008-08-11 20:44 ` Andrew Morton
2008-08-15 9:39 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea8d860a0807261227w66e29978uecd12cf1fcb915d1@mail.gmail.com \
--to=marcin_obara@users.sourceforge.net \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tpm@selhorst.net \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®