mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Crt Mori <cmo@melexis.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: iio: temperature: add MLX90635 device bindings
Date: Wed, 22 Nov 2023 13:35:19 +0100	[thread overview]
Message-ID: <ea997987-6a84-445c-a806-527d766569b1@kernel.org> (raw)
In-Reply-To: <CAKv63uv87srZ3gJxFASuGWV6cULXkN=gYi_L=BCcd3dgOFQEfw@mail.gmail.com>

On 22/11/2023 13:28, Crt Mori wrote:
>>> +  Since measured object emissivity effects Infra Red energy emitted,
>>> +  emissivity should be set before requesting the object temperature.
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: melexis,mlx90635
>>
>> It's the same as mlx90632. Add it there (as enum).
>>
> 
> Properties are the same, but then you can't have much differences for
> a temperature sensor. It has a bit worse relative measurement error
> outside of the human body range and overall different DSP, register
> map, even physical size - it's 1.8x1.8 mm compared to 90632 3x3 mm. I
> was not sure how it qualifies for adding it as another enum, but I
> went with the feeling that if it can reuse the driver, then it is an
> enum, otherwise it is a new file. And I could not reuse anything from
> 90632.
> 
> Thanks for quick feedback and best regards,

Driver is independent choice. There is no need for new binding file if
everything is the same from bindings point of view.

Best regards,
Krzysztof


  reply	other threads:[~2023-11-22 12:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-22 10:20 [PATCH 0/2] iio: temperature: mlx90635 Driver for MLX90635 IR temperature sensor Crt Mori
2023-11-22 10:24 ` [PATCH 1/2] iio: temperature: mlx90635 MLX90635 IR Temperature sensor Crt Mori
2023-11-24 14:39   ` kernel test robot
2023-11-25 17:53   ` Jonathan Cameron
2023-11-25 21:26     ` Crt Mori
2023-11-26 16:01       ` Jonathan Cameron
2023-11-26 19:38         ` Crt Mori
2023-11-22 10:27 ` [PATCH 2/2] dt-bindings: iio: temperature: add MLX90635 device bindings Crt Mori
2023-11-22 11:52   ` Krzysztof Kozlowski
2023-11-22 12:28     ` Crt Mori
2023-11-22 12:35       ` Krzysztof Kozlowski [this message]
2023-11-25 17:27         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea997987-6a84-445c-a806-527d766569b1@kernel.org \
    --to=krzk@kernel.org \
    --cc=cmo@melexis.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®