From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAEA7C77B72 for ; Mon, 17 Apr 2023 07:25:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230094AbjDQHZw (ORCPT ); Mon, 17 Apr 2023 03:25:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230041AbjDQHZs (ORCPT ); Mon, 17 Apr 2023 03:25:48 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC0104207 for ; Mon, 17 Apr 2023 00:25:44 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id n43-20020a05600c502b00b003f17466a9c1so640030wmr.2 for ; Mon, 17 Apr 2023 00:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681716343; x=1684308343; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=n0rYTVHyfzk+AA90RB4PaE12jLu1c91LlkhqdOS7gNE=; b=Kp/WSvkWKkwRp+/+SYbAsGFQuhyJPQc3J386vLUGGqbwLRTDFaDd25Dnte13hGoJmF CUlrlbuy/kKMaRjEIlhVd7aCO3OzVd33KvSjOuI7gsJLvCayCRIq1FcHgHlHwRqpiZ6u /KI1myVLSWo4DsPGPEkFxToNi8vg+/pjmkwQgDY5awRepMFwO3r4w7qN2brAhEhF/p7o lIosi4UaAbbxzWMsbnzVkUr2Y1nInKPNNANjahgIxyJn5zZWwAIqJPB1xzw7NFHpt8Mx +St0bVgNPpyymuU+TeF0ixlp0iNXEvOq4oicav9+5FDrX6oLUzRAiPXSqR+MIkYes5Dx dmVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681716343; x=1684308343; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n0rYTVHyfzk+AA90RB4PaE12jLu1c91LlkhqdOS7gNE=; b=gmk9OckgO1gny4pponbmW1OfDAITathuWGocJcHhYMiJ3nGAzKCVhbtiMpQkJQXi98 xrguD3VFpAPph74Erw+KVuBH4efAUIKKQqQ8EjVB6ZnrpayWpEg7sK0Ly87romCf4lLD aNdVIrnOx0J8aFAVHJ6H/KNeTt2DqnUZCVbpN6bk5cwOhUlOioAcmQUbdlLSc4bBv5m4 MIG4jyvJhgz4B1kWMx+DOEWegqTdJriQEGt+35F0KyHWaP26tIJUYyH0rIKZhX4Q45Px Yv9JLLG4DD/+l+kIMTn/BYufAmtSULX7A3sDV5p2HcGbmVrmGUW6BMonKgHlChe1Y+xe epjA== X-Gm-Message-State: AAQBX9fbkGFGvz3CWMpBIzieCIZ8Ikgtxe1vbRDi5VZNhHfKn9sIVxoq VuSXXFRY7t23cDV8dGo5IFac7yNT+UYAmXDvmROSlg== X-Google-Smtp-Source: AKy350YCTkjsvhIS77+h9VbIlJpno1ZUgjI0eD3gJS4kb3pm0Yr4qV5xUKScfdJ4ESLvXfQxOOlMlw== X-Received: by 2002:a05:600c:2904:b0:3ee:3df6:e411 with SMTP id i4-20020a05600c290400b003ee3df6e411mr9570199wmd.28.1681716343086; Mon, 17 Apr 2023 00:25:43 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:a1e1:81a8:1acc:2b91? ([2a01:e0a:982:cbb0:a1e1:81a8:1acc:2b91]) by smtp.gmail.com with ESMTPSA id c8-20020a7bc848000000b003f173419e7asm2778180wml.43.2023.04.17.00.25.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 00:25:42 -0700 (PDT) Message-ID: Date: Mon, 17 Apr 2023 09:25:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH] drm/panel: novatek-nt35950: Improve error handling Content-Language: en-US To: Konrad Dybcio , Sam Ravnborg , David Airlie , Daniel Vetter , AngeloGioacchino Del Regno , AngeloGioacchino Del Regno Cc: Marijn Suijten , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230415-konrad-longbois-next-v1-1-ce695dc9df84@linaro.org> Organization: Linaro Developer Services In-Reply-To: <20230415-konrad-longbois-next-v1-1-ce695dc9df84@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/04/2023 13:00, Konrad Dybcio wrote: > In a very peculiar case when probing and registering with the secondary > DSI host succeeds, but the OF backlight or DSI attachment fails, the > primary DSI device is automatically cleaned up, but the secondary one > is not, leading to -EEXIST when the driver core tries to handle > -EPROBE_DEFER. > > Unregister the DSI1 device manually on failure to prevent that. > > Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels") > Signed-off-by: Konrad Dybcio > --- > drivers/gpu/drm/panel/panel-novatek-nt35950.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35950.c b/drivers/gpu/drm/panel/panel-novatek-nt35950.c > index abf752b36a52..7498fc6258bb 100644 > --- a/drivers/gpu/drm/panel/panel-novatek-nt35950.c > +++ b/drivers/gpu/drm/panel/panel-novatek-nt35950.c > @@ -585,8 +585,11 @@ static int nt35950_probe(struct mipi_dsi_device *dsi) > DRM_MODE_CONNECTOR_DSI); > > ret = drm_panel_of_backlight(&nt->panel); > - if (ret) > + if (ret) { > + mipi_dsi_device_unregister(nt->dsi[1]); > + > return dev_err_probe(dev, ret, "Failed to get backlight\n"); > + } > > drm_panel_add(&nt->panel); > > @@ -602,6 +605,9 @@ static int nt35950_probe(struct mipi_dsi_device *dsi) > > ret = mipi_dsi_attach(nt->dsi[i]); > if (ret < 0) { > + /* If we fail to attach to either host, we're done */ > + mipi_dsi_device_unregister(nt->dsi[1]); > + > return dev_err_probe(dev, ret, > "Cannot attach to DSI%d host.\n", i); > } > > --- > base-commit: 035ba5f9cf511b9299fd9c9d0688ef930d33c886 > change-id: 20230415-konrad-longbois-next-847d57abb4d2 > > Best regards, Reviewed-by: Neil Armstrong