From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754652AbeAOImx (ORCPT + 1 other); Mon, 15 Jan 2018 03:42:53 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:43883 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754441AbeAOImv (ORCPT ); Mon, 15 Jan 2018 03:42:51 -0500 X-Google-Smtp-Source: ACJfBovjgFclGuyLCgGWpqAnY60uoHWALBp3X2fAKJnm4XWqxgQ5UkH/tU+T5CJ2MDHThVRlbH3xwg== Subject: Re: [PATCH] ACPI / LPSS: Do not instiate a platform_dev for devs without a mmio resource To: "Rafael J. Wysocki" Cc: "Rafael J . Wysocki" , Len Brown , Andy Shevchenko , Mika Westerberg , MyungJoo Ham , Chanwoo Choi , Chen-Yu Tsai , Thierry Reding , Linux PWM List , ACPI Devel Maling List , Linux Kernel Mailing List References: <20180114200148.11771-1-hdegoede@redhat.com> From: Hans de Goede Message-ID: Date: Mon, 15 Jan 2018 09:42:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi, On 15-01-18 00:36, Rafael J. Wysocki wrote: > On Sun, Jan 14, 2018 at 9:01 PM, Hans de Goede wrote: >> acpi_lpss_create_device() skips handling LPSS devices which do not have >> a mmio resources in their resource list (typically these devices are >> disabled by the firmware). But since the LPSS code does not bind to the >> device, acpi_bus_attach() ends up still creating a platform device for >> it and the regular platform_driver for the ACPI HID still tries to bind >> to it. >> >> This happens e.g. on some boards which do not use the pwm-controller >> and have an empty or invalid resource-table for it. Currently this causes >> these error messages to get logged: >> [ 3.281966] pwm-lpss 80862288:00: invalid resource >> [ 3.287098] pwm-lpss: probe of 80862288:00 failed with error -22 >> >> This commit stops the undesirable creation of a platform_device for >> disabled LPSS devices by setting pnp.type.platform_id to 0. Note that >> acpi_scan_attach_handler() also sets pnp.type.platform_id to 0 when there >> is a matching handler for the device and that handler has no attach >> callback, so we simply behave as a handler without an attach function >> in this case. >> >> Signed-off-by: Hans de Goede > > Does this fix new behavior or is it an old issue? The problem this addresses is likely caused by the acpi_always_present entry for the CHT 80862288 PWM devices in drivers/acpi/x86/utils.c. The problem is that under Windows the Intel GPU driver has hardcoded addresses for the PWM LPSS bits (or so I believe), rather then having it as a separate device with a separate driver, so the CHT LPSS PWM device's _STA returns 0 on all x86 devices which ship with Windows. On most CHT laptops / tablets it is used to control the backlight brightness so we do need the device under Linux, where we've a separate PWM driver and we don't want to be hardcoding stuff like this. So we really cannot do without the acpi_always_present entry, and thus need this extra check for devices where the pwm is actually unused and disabled by the firmware. Regards, Hans >> --- >> drivers/acpi/acpi_lpss.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c >> index 9cfe6b71078b..166a8e582d96 100644 >> --- a/drivers/acpi/acpi_lpss.c >> +++ b/drivers/acpi/acpi_lpss.c >> @@ -610,6 +610,8 @@ static int acpi_lpss_create_device(struct acpi_device *adev, >> acpi_dev_free_resource_list(&resource_list); >> >> if (!pdata->mmio_base) { >> + /* Avoid acpi_bus_attach() instantiating a pdev for this dev. */ >> + adev->pnp.type.platform_id = 0; >> /* Skip the device, but continue the namespace scan. */ >> ret = 0; >> goto err_out; >> -- >> 2.14.3 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html