From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06A2D327BE3 for ; Thu, 18 Dec 2025 13:27:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766064462; cv=none; b=Ni8jTqGXzjbJvVKWfTrWcdgaCGFba0dKIHQVctCYH/dX8hl5BETaICsHXNry5bIEE13Ej9/M6dKF4ffrm7yPsR58GuEVU6OcevaFdLpj7kYW2lraTjP7wWUv9Wux1uAO+q3x6e2A18vwknPd76wXDgOPAyTiZQ4yZT5/BPoom+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766064462; c=relaxed/simple; bh=/lRnz8+u+j+rBYfHNu1KVlPrB2Z2ceq3jn5n4Rgnv3Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gBzZSYwB63Yb11qNztF0g7G9z9+f6jSTgnv4YJ3XkTapPx+4KziLA927Hq5MA/ONbyOzX63syDHTrYlldscCfBG0P/Y3aIg8mgxvudXJ4o/FcjUMXPtHaCxCcp3cmcNID2VwNYiND1VFs5YCO3HVadhcHToQHeIimqheWlruHNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fNebZFqb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZsGxBJk2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fNebZFqb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZsGxBJk2" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BI8rBPx3447056 for ; Thu, 18 Dec 2025 13:27:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Y2VgE7DkNfWinDjeUMXmmkRgDppNoAsJS/kjybLUmDk=; b=fNebZFqb3qBu7dtE CEwLSJNqZznSPXn0vfqRA7Gs+JWiVTznVCpD3Jieob7vTR7wtoS2yQZmQZZQ5JWn h/pwLtLW2MnO9Ym2XWGk0KtXqnHm8LspLWeZGb7t+zCcN6M7Rg8Z1Yqh8M2cgAec yiJKKCufb4sIiALajN8nzvFztN9lpOH4yJhYMIBEnZ29tTwtlMcc09fWRESuS2x0 F8lasQUBpfx5A5la2Nat4g79k1tepvvYsh0dDQdgLQRtlePCGHVCzDucu+aevrgZ FHZagSoS7Ev9xN7JNTW9ajCdr5GApSBPeZRCMw91MEiXRTIatqI3ZR+sC0bB5XAg utwVRw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4egb8xnv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 18 Dec 2025 13:27:40 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4f1e17aa706so3209461cf.2 for ; Thu, 18 Dec 2025 05:27:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766064459; x=1766669259; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y2VgE7DkNfWinDjeUMXmmkRgDppNoAsJS/kjybLUmDk=; b=ZsGxBJk28tyX47ORoghNxSawkhL6ExSG92oTL76pPeauMCK0er1RwAM+wXl6BnRoca kRfQBJHQPRugI7gYAOzDm4dorwGmr3m3G9VsvbRlYDuAVWAvcA/N4s3KKobsPr8OZmjB gdy/Xyp1CFdcoJ4qdKCfk5UkVpJvs2mbCEmcyjF/T86ycPzd68dH8h9ZSxO1n4U+cwRt o/UiKKMqmYvwTLlBo00WrptFoI/FuEM0L8ANpWCI5hJX9q+Mowph4TqwSHQ77OrFoP07 UunVEUCI26WIwu7Xu/oB4Zd8tV+yln73J3UeMlaHtEZgiC1D9GP3hagiD6JsD/CG4BAm lquA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766064459; x=1766669259; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y2VgE7DkNfWinDjeUMXmmkRgDppNoAsJS/kjybLUmDk=; b=cqrkP7Uz1ryzoEI3Btx5D0vWs5K2BNVt5zFf45ooBVi8el3nUfoMhtZLgTz0RNkJ2p 2u8XNWYGCTQvXFxz2Vr7eZbNjJ7l1GhNfxIKlATrcB1RT2p9EHAsJOPWlU5WdVnnnW+p kHPbk7lZSfuuh/nknOjIdO7jJV1VGD943CVPwh3RIwcy700kAXYHjucYR7J0GtFgfWuV jqGvJgDy9VmlECb2xLSIa7/dC2V84T0G7V2Q7aoCtrEOWUEDh/ZG6HS3CbKNyRwmkCTG 8i9ahVItCI+hFbwpW0xULEBFNEmbupFhewVYqq1/5giND+8B0p7dueJqoTdtCFMb9X7x c4sg== X-Forwarded-Encrypted: i=1; AJvYcCVG/9HCbWmQLmJNWpbm7xrN6Hzt8qRmm8XInw01I8VQYxb5ozIE+auyurFsUx9g+VxMKQ28upxm+L2lLu0=@vger.kernel.org X-Gm-Message-State: AOJu0YyIYgbha1ew0+kDVcGJwyesummkDyuhMsV6vTY4w3Izz9AU3wyN xmLg3TxVyV8DuYRNHCoT51wRaNE4uSSSBR9y6ZpKvV/6b1L56jjFAgEbNcFCQ2DupuCWZvpQDF6 8NgdBRV+AxNA7OwjuO2bWiytfQvRTo/o120RgFWCTaFzioBR8B0jjrLSbJ11LNK4XqnE= X-Gm-Gg: AY/fxX5FI3s9+Lrm58YQfdSkqTqhURdScBmW6ttDcobCUju35wkahp7e6rf6LvsiNVD w8/Y7IPSFugdsLJrXG9NGA1Z1t4FDG5sGfzjgGQPK01FNy1x4cRPtz024bmWcIK3V2w7gMtSENk xiyalAlAdCXkUj/RjsEWEzhJx1cnJk+dQV0hkb2bPgiCbVYjdB1xRZyIeO+F4N+0ge/7xXwwb2E QNs+Nw16ixue/4mqfwaF30X/vT1HMffab6Po5pMqZ3w6wWrlPybaKdGLeCCvrXFnblo0EyzXuhD 9hhNPm7FoVDpwBGVtwuuU4/6BSTwSkn59Pnbd8K5yagTTnEUkZZqCDImlunoYY25rteyWSEpd7i FdtRQpd3kH+METhMD94JN8UWf7pSjGONVZSYWXabxOuFe2hHDJqRIdJdcpaGTgkYINg== X-Received: by 2002:a05:622a:590:b0:4f1:840a:c90f with SMTP id d75a77b69052e-4f36108cf01mr20140271cf.2.1766064459209; Thu, 18 Dec 2025 05:27:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IE4gtdmb9Sxx7cRjVZudUJ33+JiUORZDis5z0fWPdz1thnpNoxOCKTymn8JNQmvw4u/c2ogrw== X-Received: by 2002:a05:622a:590:b0:4f1:840a:c90f with SMTP id d75a77b69052e-4f36108cf01mr20139981cf.2.1766064458633; Thu, 18 Dec 2025 05:27:38 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b802346446asm229074466b.44.2025.12.18.05.27.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Dec 2025 05:27:38 -0800 (PST) Message-ID: Date: Thu, 18 Dec 2025 14:27:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] regulator: qcom_smd: change MP5496 supply names To: Gabor Juhos , Liam Girdwood , Mark Brown , Varadarajan Narayanan , Devi Priya , Praveenkumar I , Konrad Dybcio , Kathiravan T Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251216-qcom_smd-mp5496-supply-fix-v1-1-f9b5e70536de@gmail.com> <680d3b17-7983-4522-89b9-13ad67f4bfe4@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE4MDExMCBTYWx0ZWRfX+4yu1PvbOmEJ t1gKBeyk1tXAEoxjKmiE5bnxC2CCqQGHZpo/n2Bs+QX/aBmJtywd04N9KGNBOl4ebQLt295Kej/ AdaT159+we5MREvRUvlZDbrn+hhGsLr/3eVcXGNj0x2dnMdIKREklu+yA9MSqvKuVjxaeOoF8Jb nqGQynWxGB7myPdX8myRDA6/DOjr1QCiozfxNcC4M0zUZn00IAljN0m4d3iOq04+8BayyPH75k7 5Egq7Sbg7ADF3UV7fXKHZsBllO8le1vzT531yiRl1Pu9ZBZAsj5bqfAfCi84Rb1d2M3d+KTwx3/ 0CuPK28iHPw6amipxgdlM7NejDp1KJ9URi22NyJEDVPnDOjZpOOmyoxh9TbNyt4u65stCEHch9n AQN8xumN1HlJ7XOuWHMU/SJSpJXAbw== X-Authority-Analysis: v=2.4 cv=M9tA6iws c=1 sm=1 tr=0 ts=6944014c cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=g8XaxAed5rD453rOH4kA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: bcjhe9-GkhRfJ6E2jrXVBEOF5VaddupF X-Proofpoint-ORIG-GUID: bcjhe9-GkhRfJ6E2jrXVBEOF5VaddupF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-18_02,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 clxscore=1015 suspectscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512180110 On 12/17/25 9:32 PM, Gabor Juhos wrote: > Hi Konrad, > > 2025. 12. 17. 11:30 keltezéssel, Konrad Dybcio írta: >> On 12/16/25 7:38 PM, Gabor Juhos wrote: >>> In case of the MP5496 regulators, the driver uses the same name both for >>> the regulator and for its supply. Due to this, in some cases the supply >>> gets resolved to the regulator itself, and the regulator core code throwns >>> an error message. >>> >>> For example, booting the kernel with the 'ipq9574-rdp433' device tree, >>> results in the following message in the log: >>> >>> [ 1.710392] qcom_rpm_smd_regulator remoteproc:glink-edge:rpm-requests:regulators: Supply for s1 (s1) resolved to itself >>> >>> Additionally, the driver uses different supply names for the 's2' and for >>> the 'l2' regulators which is incorrect. Here is the supply map based on the >>> datasheet of the MP5496: >>> >>> VIN1 -> Buck1 >>> VIN2 -> Buck2, LDO2, LDO3 >>> VIN3 -> Buck3 >>> VIN4 -> Buck4 >>> VIN5 -> LDO4, LDO5 >> >> One thing this reveals is that there's an LDO3 and an LDO4 which >> we don't describe today.. > > The same is true for Buck3 and Buck4 too. > >> are they managed as power-domains, or are there other other reasons? > > Unfortunately, I don't know the exact reason. OK, so the bucks are all managed by RPM as power domains indeed L[2345] are all defined *but* I don't quite know how this is all mapped - it may be that LDO2 is mapped as "l1", but I'm really not sure Konrad > > I have no detailed hardware information about the reference boards, but it seems > that it depends on what is supported by the actual RPM firmware on the board. > > For example, currently I have this RPM version on my IPQ9574 based board: > > # cat /sys/kernel/debug/qcom_socinfo/rpm/name > 03:RPM.BF.2.4.1-00116 > # cat /sys/kernel/debug/qcom_socinfo/rpm/oem > CRM > # cat /sys/kernel/debug/qcom_socinfo/rpm/variant > CAAAANAAR > > This version does not even support LDO5. At least, trying to use that results in > the following error: > > [ 2.120281] l5: Bringing 0uV into 1800000-1800000uV > [ 2.127721] l5: failed to enable: -ENXIO > > In this special case, the -ENXIO error code comes from qcom_smd_rpm_callback() > and it means that the resource does not exists. > > So my guess is that the undescribed regulators are simply not used on the boards > supported currently. > > Regards, > Gabor