From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E9CD397682; Wed, 10 Jun 2026 08:27:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781080028; cv=none; b=W78DiddnFexEnkhfVuPQ1xePD0tOKhmX2WnFYn3k/5tcvLfNc4vSAOXNTog/8x9gZxpCMmiHiIvD+ILOtSRQHPUWGnbYkzwZ42GPCWAQootMtEKemX449IYCnG1aOdeRqfvRgSVreh0uAjGpfJj0jYCwlLuH0JoeHt3qfcMwDXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781080028; c=relaxed/simple; bh=6xnEBD+qu7YLDUTxDEOXY/2rGV0YEc1qGNsJfrZkUN0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WC9MCYqF5SwvUE5BEe6XK7O5Xg1I3Y8YEu28f+6Xz4wCaHPYHXzdsRyyy02vysMT2bvVSPdb/w6qTnLWyN4fHIt1shMmqgunmYu8Xdi9fqS2pMuXayt4AWRL3zxvFjUEGBKlrCwUSjeG7i2y7TMJ8oRBJOhnYmZJXn79qO4pYkE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=1JqGYNOO; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="1JqGYNOO" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 86151C5146A; Wed, 10 Jun 2026 08:27:05 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 8A7325FFC9; Wed, 10 Jun 2026 08:27:03 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 81A4F106B9056; Wed, 10 Jun 2026 10:26:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1781080022; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=Whfl4QLl7rlDdWuJnD1FYGrTxAzK/P2e2aQDPSeDeSQ=; b=1JqGYNOOL1Pl5I9EUrbk8Gh6N8JpYRafqUk235S6QQUxecR7HLECmGB54SN7PPv4uNYCcf 0N503XbHO4hBTdwsh/tzzj5j7oLUxc8Wlt5VT0aBcomUHRwC44BrID/CP2VW4ZlcrIR/l7 wPrerAVivv5Dta96h0JcuCaS69Uul6GoEWqp+ilBENCM90FKwZ187AmYNy7K0Z5VNUKIFO KSaURLkQpn7Ml/WV93S/y4viL5xCmFxdk1GYve8IGrdpBGpgUdF5oGnAx1oB1X3ictlFE8 Ft7rQMA58/2cDT0y4WGvLyyQ8k5f3inDbfI6/9BvuK72Nzrb5G9RbANHO60Ibw== Message-ID: Date: Wed, 10 Jun 2026 10:26:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v8 3/6] net: stmmac: eic7700: make RGMII delay properties optional To: lizhi2@eswincomputing.com, devicetree@vger.kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, rmk+kernel@armlinux.org.uk, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com, pinkesh.vaghela@einfochips.com, pritesh.patel@einfochips.com, weishangjuan@eswincomputing.com, horms@kernel.org, lee@kernel.org References: <20260610012727.848-1-lizhi2@eswincomputing.com> <20260610012937.911-1-lizhi2@eswincomputing.com> Content-Language: en-US From: Maxime Chevallier In-Reply-To: <20260610012937.911-1-lizhi2@eswincomputing.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi, On 6/10/26 03:29, lizhi2@eswincomputing.com wrote: > From: Zhi Li > > Make rx-internal-delay-ps and tx-internal-delay-ps optional in the > EIC7700 DWMAC driver. > > The driver previously required both properties to be present and would > fail probe when they were missing. This restricts valid hardware > configurations where RGMII timing is instead provided by the PHY or > board design. > > Update the driver to treat missing delay properties as zero delay, > allowing systems without explicit MAC-side delay tuning to operate > correctly. > > This aligns the driver behavior with the updated device tree binding > and provides a safe default configuration when MAC-side delay > programming is not required. > > Signed-off-by: Zhi Li > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-eic7700.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-eic7700.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-eic7700.c > index 4ac979d874d6..ec99b597aeaf 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-eic7700.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-eic7700.c > @@ -165,9 +165,6 @@ static int eic7700_dwmac_probe(struct platform_device *pdev) > dwc_priv->eth_clk_dly_param &= ~EIC7700_ETH_RX_ADJ_DELAY; > dwc_priv->eth_clk_dly_param |= > FIELD_PREP(EIC7700_ETH_RX_ADJ_DELAY, val); > - } else { > - return dev_err_probe(&pdev->dev, -EINVAL, > - "missing required property rx-internal-delay-ps\n"); > } > > /* Read tx-internal-delay-ps and update tx_clk delay */ > @@ -187,9 +184,6 @@ static int eic7700_dwmac_probe(struct platform_device *pdev) > dwc_priv->eth_clk_dly_param &= ~EIC7700_ETH_TX_ADJ_DELAY; > dwc_priv->eth_clk_dly_param |= > FIELD_PREP(EIC7700_ETH_TX_ADJ_DELAY, val); > - } else { > - return dev_err_probe(&pdev->dev, -EINVAL, > - "missing required property tx-internal-delay-ps\n"); > } I think then you need to handle RGMII, RGMII_ID, RGMII_RXID and RGMII_TXID, by using default delays for these (usually around 2ns), as here all delays will be set to 0, regardless of the RGMII mode in use. Maxime > > dwc_priv->eic7700_hsp_regmap =