From: Maarten Zanders <maarten.zanders@mind.be>
To: Pavel Machek <pavel@ucw.cz>
Cc: Arne Staessen <a.staessen@televic.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: lp5523: fix out-of-bounds bug in lp5523_selftest()
Date: Wed, 2 Nov 2022 09:21:19 +0100 [thread overview]
Message-ID: <eaa66c56-de8b-ea8e-6907-41535c4c16ac@mind.be> (raw)
In-Reply-To: <20221028153457.GA14936@duo.ucw.cz>
Hi Pavel,
On 10/28/22 17:34, Pavel Machek wrote:
> I wonder, should we do these kind of actions on attribute _read_? I'd
> preffer some kind of write action to trigger this.
>
Yes I agree that doing these kind of things on a file read feels somehow
strange. Strictly speaking, I guess you would implement an IOCTL to
initiate the action and then perform a read to get the result. But that
would needlessly complicate things on both ends? I'll keep it in mind
and when I encounter similar interfaces in other drivers get back to
this if needed.
next prev parent reply other threads:[~2022-11-02 8:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 10:56 Maarten Zanders
2022-10-28 15:34 ` Pavel Machek
2022-11-02 8:21 ` Maarten Zanders [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-10-25 12:23 Maarten Zanders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaa66c56-de8b-ea8e-6907-41535c4c16ac@mind.be \
--to=maarten.zanders@mind.be \
--cc=a.staessen@televic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®