From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32B34C6FD1D for ; Tue, 21 Mar 2023 15:12:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231603AbjCUPMl (ORCPT ); Tue, 21 Mar 2023 11:12:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231593AbjCUPMd (ORCPT ); Tue, 21 Mar 2023 11:12:33 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5959EF9D for ; Tue, 21 Mar 2023 08:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679411495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YsalzkC56zpU2rDmbQ0VUjilQkDx+3Gh+sNLgCZQJM0=; b=a4wEXQNpOduu993AJB4GM/N1D9BOXnLhsypiBjF/se2RDXlTQeCe/LKMKFLrCN7yif3MLQ X1yATV3da/DxZWwLbSsch4RtxEopEsJtdIKFMNFK79q0TnBnL1KQxAx84bLJlbO++VN6zo H0EABe+eLSGpxL5704spLwwHvjjrJwc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-354-ecqY9WomN-KgJgvct2qxpQ-1; Tue, 21 Mar 2023 11:11:34 -0400 X-MC-Unique: ecqY9WomN-KgJgvct2qxpQ-1 Received: by mail-wm1-f72.google.com with SMTP id k18-20020a05600c1c9200b003ed2a3f101fso10137265wms.9 for ; Tue, 21 Mar 2023 08:11:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679411489; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YsalzkC56zpU2rDmbQ0VUjilQkDx+3Gh+sNLgCZQJM0=; b=ZKarflarlHIA3dZ4VTJfATstXXVeJBQzwfTS+VFDE41WAPaNx7mTdhQo6JqsYlW1s3 zYBdUfaRvRwi7/nkVtJ9sMoUcU/t/A98FGmFYP8uFSJrY2+SJi1Gkg0yoKGeETzIaQBA A+IM5e2Vt/Rd2+odNWR9MCSFYu3rL5WO1VKYYf+yEMwXTyPtfqY/rpRrqabCcTinWuwj BYXkL7l4WS3/rLVA3Qm8YB8Ti2wkb9euFQCVqlI5uZkIZtNOxI4V7mgk7ZFCGtuBim/y 6bVqQk5ziUM507rFWZ0eIZoow8knx6AZi3Oa4ACRO0TWgIrU28I6mIEsgWFwouUrn5fq NbeA== X-Gm-Message-State: AO0yUKX4IuFRKIkh+J0CilfHIopL0ZqrIjLSS3eOJqL/7IBiGrExuoqU eyv9MSjnPJMnVGvFK0HMyzuCZHt0+keTkWWRYC6DbrLpzoF1d8hfOuf4brlWY1EdK9vPsg4XLtw Vyn/pqjlDd5mVKPYZpSDgtKu4 X-Received: by 2002:a7b:c7cf:0:b0:3ed:5a7d:fcfe with SMTP id z15-20020a7bc7cf000000b003ed5a7dfcfemr2751333wmk.3.1679411489765; Tue, 21 Mar 2023 08:11:29 -0700 (PDT) X-Google-Smtp-Source: AK7set8c5q656St+C8eydyBRX4ly1NSD5lwVif694CoWt4z3/ARNNlS3mU+K2K0zfpCc8MVaWwcWxQ== X-Received: by 2002:a7b:c7cf:0:b0:3ed:5a7d:fcfe with SMTP id z15-20020a7bc7cf000000b003ed5a7dfcfemr2751310wmk.3.1679411489460; Tue, 21 Mar 2023 08:11:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:7f00:8245:d031:7f8b:e004? (p200300cbc7057f008245d0317f8be004.dip0.t-ipconnect.de. [2003:cb:c705:7f00:8245:d031:7f8b:e004]) by smtp.gmail.com with ESMTPSA id v26-20020a05600c215a00b003eafc47eb09sm13666500wml.43.2023.03.21.08.11.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Mar 2023 08:11:28 -0700 (PDT) Message-ID: Date: Tue, 21 Mar 2023 16:11:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC 00/12] module: avoid userspace pressure on unwanted allocations Content-Language: en-US To: Luis Chamberlain , Adam Manzanares Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, pmladek@suse.com, petr.pavlu@suse.com, prarit@redhat.com, christophe.leroy@csgroup.eu, song@kernel.org, torvalds@linux-foundation.org References: <3b25ed5c-8fb9-82d3-2296-fadbbb4db7e4@redhat.com> <2bd995a7-5b7f-59a1-751e-c56e76a7d592@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.03.23 22:23, Luis Chamberlain wrote: > On Mon, Mar 20, 2023 at 10:15:23PM +0100, David Hildenbrand wrote: >> On 20.03.23 22:09, Luis Chamberlain wrote: >>> On Mon, Mar 20, 2023 at 08:40:07PM +0100, David Hildenbrand wrote: >>>> On 20.03.23 10:38, David Hildenbrand wrote: >>>>> On 18.03.23 01:11, Luis Chamberlain wrote: >>>>>> On Thu, Mar 16, 2023 at 04:56:56PM -0700, Luis Chamberlain wrote: >>>>>>> On Thu, Mar 16, 2023 at 04:55:31PM -0700, Luis Chamberlain wrote: >>>>>>>> On Wed, Mar 15, 2023 at 05:41:53PM +0100, David Hildenbrand wrote: >>>>>>>>> I expect to have a machine (with a crazy number of CPUs/devices) available >>>>>>>>> in a couple of days (1-2), so no need to rush. >>>>>>>>> >>>>>>>>> The original machine I was able to reproduce with is blocked for a little >>>>>>>>> bit longer; so I hope the alternative I looked up will similarly trigger the >>>>>>>>> issue easily. >>>>>>>> >>>>>>>> OK give this a spin: >>>>>>>> >>>>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=20230316-module-alloc-opts >>>>>> >>>>>> Today I am up to here: >>>>>> >>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=20230317-module-alloc-opts >>>>>> >>>>>> The last patch really would have no justification yet at all unless it >>>>>> does help your case. >>>>> >>>>> Still waiting on the system (the replacement system I was able to grab >>>>> broke ...). >>>>> >>>>> I'll let you know once I succeeded in reproducing + testing your fixes. >>>> >>>> Okay, I have a system where I can reproduce. >>>> >>>> Should I give >>>> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=20230319-module-alloc-opts >>>> >>>> from yesterday a churn? >>> >>> Yes please give that a run. >> >> Reproduced with v6.3.0-rc1 (on 1st try) > > By reproduced, you mean it fails to boot? It boots but we get vmap allocation warnings, because the ~440 CPUs manage to completely exhaust the module vmap area due to KASAN. > >> Not able to reproduce with 20230319-module-alloc-opts so far (2 tries). > > Oh wow, so to clarify, it boots OK? It boots and I don't get the vmap allocation warnings. > >>> Please collect systemd-analyze given lack of any other tool to evaluate >>> any deltas. Can't think of anything else to gather other than seeing if >>> it booted. >> >> Issue is that some services (kdump, tuned) seem to take sometimes ages on >> that system to start for some reason, > > How about disabling that? It seems to be random services. On my debug kernel with KASAN everything is just super slow. I'll try to measure on a !debug kernel. -- Thanks, David / dhildenb