From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/8] dt-bindings: power: qcom-rpmpd: split RPMh domains definitions
Date: Fri, 18 Jul 2025 19:21:27 +0200 [thread overview]
Message-ID: <eaab7061-a02c-43fd-9a02-6ff9625401a8@oss.qualcomm.com> (raw)
In-Reply-To: <20250718-rework-rpmhpd-rpmpd-v1-1-eedca108e540@oss.qualcomm.com>
On 7/18/25 6:13 PM, Dmitry Baryshkov wrote:
> Historically both RPM and RPMh domain definitions were a part of the
> same, qcom-rpmpd.h header. Now as we have a separate header for RPMh
> definitions, qcom,rpmhpd.h, move all RPMh power domain definitions to
> that header.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
[...]
> -/* SC8280XP Power Domain Indexes */
> -#define SC8280XP_CX 0
> -#define SC8280XP_CX_AO 1
> -#define SC8280XP_DDR 2
> -#define SC8280XP_EBI 3
> -#define SC8280XP_GFX 4
> -#define SC8280XP_LCX 5
> -#define SC8280XP_LMX 6
> -#define SC8280XP_MMCX 7
> -#define SC8280XP_MMCX_AO 8
> -#define SC8280XP_MSS 9
> -#define SC8280XP_MX 10
> -#define SC8280XP_MXC 12
> -#define SC8280XP_MX_AO 11
> -#define SC8280XP_NSP 13
> -#define SC8280XP_QPHY 14
> -#define SC8280XP_XO 15
> -
> -/* SDM845 Power Domain performance levels */
I was never a fan of these comments but whatever, it's an include
if the dt folks don't object, this is good
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2025-07-18 17:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 16:13 [PATCH 0/8] pmdomain: qcom: sort out RPMh and RPM power domain indices Dmitry Baryshkov
2025-07-18 16:13 ` [PATCH 1/8] dt-bindings: power: qcom-rpmpd: split RPMh domains definitions Dmitry Baryshkov
2025-07-18 17:21 ` Konrad Dybcio [this message]
2025-07-29 16:00 ` Rob Herring (Arm)
2025-07-18 16:13 ` [PATCH 2/8] dt-bindings: power: qcom-rpmpd: sort out entries Dmitry Baryshkov
2025-07-29 16:00 ` Rob Herring (Arm)
2025-07-18 16:13 ` [PATCH 3/8] dt-bindings: power: qcom-rpmpd: add generic bindings for RPM power domains Dmitry Baryshkov
2025-07-29 16:00 ` Rob Herring (Arm)
2025-07-18 16:13 ` [PATCH 4/8] pmdomain: qcom: rpmpd: switch to RPMPD_* indices Dmitry Baryshkov
2025-07-18 16:13 ` [PATCH 5/8] arm64: dts: qcom: dts: " Dmitry Baryshkov
2025-07-20 3:36 ` Bjorn Andersson
2025-07-18 16:13 ` [PATCH 6/8] ARM: " Dmitry Baryshkov
2025-07-20 3:37 ` Bjorn Andersson
2025-07-18 16:13 ` [PATCH DO NOT MERGE 7/8] dt-bindings: power: qcom-rpmpd: drop compatibility defines Dmitry Baryshkov
2025-07-18 16:13 ` [PATCH DO NOT MERGE 8/8] dt-bindings: power: qcom,rpmhpd: drop duplicate defines Dmitry Baryshkov
2025-07-20 3:38 ` [PATCH 0/8] pmdomain: qcom: sort out RPMh and RPM power domain indices Bjorn Andersson
2025-08-19 12:26 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaab7061-a02c-43fd-9a02-6ff9625401a8@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®