mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>,
	"Arun Iyengar" <aiyengar1990@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Hans Verkuil <hverkuil@kernel.org>,
	Nicolas Dufresne <nicolas.dufresne@collabora.com>,
	Alex Bee <knaerzche@gmail.com>
Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: Add IEP2 deinterlacer to RK3588
Date: Tue, 17 Nov 2026 09:25:36 +0100	[thread overview]
Message-ID: <eaabb4ff-c748-4123-93b8-f49684600c71@kernel.org> (raw)
In-Reply-To: <yRxnTArhQFiS4u_tncJj-g@sntech.de>

On 16/11/2026 19:32, Heiko Stübner wrote:
> Am Montag, 16. November 2026, 13:35:28 Mitteleuropäische Normalzeit schrieb Krzysztof Kozlowski:
>> On Sun, Nov 15, 2026 at 08:47:44AM +0000, Arun Iyengar wrote:
>>> Add the IEP2 deinterlacer and its IOMMU to the RK3588 base dtsi. Both
>>> share GIC SPI 117 and sit in the VDPU power domain.
>>>
>>> Addresses, clocks, resets and the interrupt are taken from the Rockchip
>>> BSP rk3588s.dtsi (develop-6.1).
>>>
>>> Signed-off-by: Arun Iyengar <aiyengar1990@gmail.com>
>>> ---
>>>  arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 22 ++++++++++++++++++++++
>>>  1 file changed, 22 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
>>> index aa69fd3793fd..5297519bd251 100644
>>> --- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
>>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
>>> @@ -1397,6 +1397,28 @@ vepu121_3_mmu: iommu@fdbac800 {
>>>  		#iommu-cells = <0>;
>>>  	};
>>>  
>>> +	iep: deinterlace@fdbb0000 {
>>
>> Why all these are outside soc node? That's more of a question to
>> existing code...
> 
> Many years back, during the RK3288 addition I got the comment from the
> arm-soc maintainer to drop the soc node [0]:
> 
> "[...] this isn't how we tend to do it any more (unless all devices
> are physically on a bus, but then it should probably be named something else
> than 'soc')."
> 
> So since then we didn't have soc nodes. Except in time for the RK3576, the
> tune has changed, so socs from then on have a soc node again ;-) .
> 

I think the comment was misplaced and misunderstood. Indeed non-MMIO
nodes were not supposed to be in soc. But the MMIO node are under
MMIO-bus, which usually we call soc.

It's documented also writing-bindings, since 2019, though :)

Well, not a blocker for this patch and I leave it to you what to do with
existing and new DTSI.

Best regards,
Krzysztof

      reply	other threads:[~2026-11-17  8:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15  8:47 [PATCH v2 0/3] media: rockchip: Add the IEP2 deinterlacer of RK3568/RK3588 Arun Iyengar via B4 Relay
2026-11-15  8:47 ` [PATCH v2 1/3] media: dt-bindings: Add Rockchip IEP2 deinterlacer Arun Iyengar via B4 Relay
2026-11-16 12:33   ` Krzysztof Kozlowski
2026-11-15  8:47 ` [PATCH v2 2/3] media: rockchip: Add IEP2 deinterlacer driver Arun Iyengar via B4 Relay
2026-11-15  8:47 ` [PATCH v2 3/3] arm64: dts: rockchip: Add IEP2 deinterlacer to RK3588 Arun Iyengar via B4 Relay
2026-11-16 12:35   ` Krzysztof Kozlowski
2026-11-16 18:32     ` Heiko Stübner
2026-11-17  8:25       ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eaabb4ff-c748-4123-93b8-f49684600c71@kernel.org \
    --to=krzk@kernel.org \
    --cc=aiyengar1990@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=hverkuil@kernel.org \
    --cc=knaerzche@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=nicolas.dufresne@collabora.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®