From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D9CCC433F5 for ; Sat, 22 Jan 2022 07:37:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232869AbiAVHhg (ORCPT ); Sat, 22 Jan 2022 02:37:36 -0500 Received: from szxga03-in.huawei.com ([45.249.212.189]:31176 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230061AbiAVHhf (ORCPT ); Sat, 22 Jan 2022 02:37:35 -0500 Received: from dggpeml500022.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Jgp0w2JFGz8wQH; Sat, 22 Jan 2022 15:34:40 +0800 (CST) Received: from dggpeml500018.china.huawei.com (7.185.36.186) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sat, 22 Jan 2022 15:37:33 +0800 Received: from [10.67.111.186] (10.67.111.186) by dggpeml500018.china.huawei.com (7.185.36.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sat, 22 Jan 2022 15:37:32 +0800 Message-ID: Date: Sat, 22 Jan 2022 15:37:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH] cgroup/cpuset: Fix a race between cpuset_attach() and cpu hotplug To: =?UTF-8?Q?Michal_Koutn=c3=bd?= CC: , , , , , , , , , , References: <20220121101210.84926-1-zhangqiao22@huawei.com> <20220121155705.GA2394@blackbody.suse.cz> From: Zhang Qiao In-Reply-To: <20220121155705.GA2394@blackbody.suse.cz> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.111.186] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500018.china.huawei.com (7.185.36.186) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/1/21 23:57, Michal Koutný 写道: > On Fri, Jan 21, 2022 at 06:12:10PM +0800, Zhang Qiao wrote: >> Fixes: be367d099270 ("cgroups: let ss->can_attach and ss->attach do whole threadgroups at a time") > > What a deep stratigraphy (not sure if it's this one but anything else > would likely come from eras ago too). Yes, I checked again and this bug may have existed since the tag Linux-2.6.12-rc2. >> Reported-by: Zhao Gongyi >> Signed-off-by: Zhang Qiao >> --- >> kernel/cgroup/cpuset.c | 2 ++ >> 1 file changed, 2 insertions(+) > > Feel free to include > Reviewed-by: Michal Koutný > Thanks for your review! Regards, Qiao . > . >