From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Masami Hiramatsu" <mhiramat@kernel.org>,
"Kees Cook" <keescook@chromium.org>
Cc: linux-arm-kernel@lists.infradead.org,
"Russell King" <linux@armlinux.org.uk>,
labbott@redhat.com, mathieu.desnoyers@efficios.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: kprobes: Avoid fortify_panic() when copying optprobe template
Date: Tue, 19 May 2020 09:52:48 +0930 [thread overview]
Message-ID: <eab147a6-4bc6-491d-aaaf-61526c4df5ff@www.fastmail.com> (raw)
In-Reply-To: <20200518112059.c19899ffb17a4843bf4f74ab@kernel.org>
On Mon, 18 May 2020, at 11:50, Masami Hiramatsu wrote:
> On Sun, 17 May 2020 14:48:52 -0700
> Kees Cook <keescook@chromium.org> wrote:
>
> > On Mon, May 18, 2020 at 01:09:59AM +0930, Andrew Jeffery wrote:
> > > As mentioned, a couple of attempts have been made to address the issue
> > > by casting a pointer to optprobe_template_entry before providing it to
> > > memcpy(), however gccs such as Ubuntu 20.04's arm-linux-gnueabi-gcc
> > > 9.3.0 (Ubuntu 9.3.0-10ubuntu1) see through these efforts.
> >
> > Ah, dang. :P
> >
> > How about converting them all to unsized arrays, which would also allow
> > the code to drop the "&" everywhere, I think. This is untested:
> >
>
> This looks good to me since it uses same technique in sections.h.
>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
>
Kees,
Were you planning to send resend this, or were you looking for me to polish it
up?
Andrew
prev parent reply other threads:[~2020-05-19 0:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 15:39 Andrew Jeffery
2020-05-17 16:02 ` Russell King - ARM Linux admin
2020-05-18 8:10 ` Andrew Jeffery
2020-05-17 21:48 ` Kees Cook
2020-05-18 0:49 ` Andrew Jeffery
2020-05-18 2:20 ` Masami Hiramatsu
2020-05-19 0:22 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eab147a6-4bc6-491d-aaaf-61526c4df5ff@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=keescook@chromium.org \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®