mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Javier Martinez Canillas <javierm@redhat.com>
Subject: [PATCH v3 03/10] drm/client: Use actual bpp when allocating frame buffers
Date: Fri,  8 Jul 2022 20:20:48 +0200	[thread overview]
Message-ID: <eabcf4f298184dabe46823fcf5ceffa1da0ec7ef.1657294931.git.geert@linux-m68k.org> (raw)
In-Reply-To: <cover.1657294931.git.geert@linux-m68k.org>

When allocating a frame buffer, the number of bits per pixel needed is
derived from the deprecated drm_format_info.cpp[] field.  While this may
work for formats using less than 8 bits per pixel, it does lead to a
large overallocation.

Reduce memory consumption by using the actual number of bits per pixel
instead.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
---
v3:
  - Add Reviewed-by,

v2:
  - Add Acked-by.
---
 drivers/gpu/drm/drm_client.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
index af3b7395bf6932f7..2b230b4d69423752 100644
--- a/drivers/gpu/drm/drm_client.c
+++ b/drivers/gpu/drm/drm_client.c
@@ -264,7 +264,7 @@ drm_client_buffer_create(struct drm_client_dev *client, u32 width, u32 height, u
 
 	dumb_args.width = width;
 	dumb_args.height = height;
-	dumb_args.bpp = info->cpp[0] * 8;
+	dumb_args.bpp = drm_format_info_bpp(info, 0);
 	ret = drm_mode_create_dumb(dev, &dumb_args, client->file);
 	if (ret)
 		goto err_delete;
@@ -373,7 +373,7 @@ static int drm_client_buffer_addfb(struct drm_client_buffer *buffer,
 	int ret;
 
 	info = drm_format_info(format);
-	fb_req.bpp = info->cpp[0] * 8;
+	fb_req.bpp = drm_format_info_bpp(info, 0);
 	fb_req.depth = info->depth;
 	fb_req.width = width;
 	fb_req.height = height;
-- 
2.25.1


  parent reply	other threads:[~2022-07-08 18:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-08 18:20 [PATCH v3 00/10] drm: Add support for low-color frame buffer formats Geert Uytterhoeven
2022-07-08 18:20 ` [PATCH v3 01/10] drm/fourcc: Add drm_format_info_bpp() helper Geert Uytterhoeven
2022-08-10 15:59   ` Daniel Vetter
2022-08-11  7:59     ` Geert Uytterhoeven
2022-08-11 16:11       ` Daniel Vetter
2022-08-11 18:29         ` Sam Ravnborg
2022-08-11 18:49           ` Geert Uytterhoeven
2022-08-11 19:30             ` Sam Ravnborg
2022-07-08 18:20 ` [PATCH v3 02/10] drm/fourcc: Add drm_format_info.is_color_indexed flag Geert Uytterhoeven
2022-07-08 18:20 ` Geert Uytterhoeven [this message]
2022-07-08 18:20 ` [PATCH v3 04/10] drm/framebuffer: Use actual bpp for DRM_IOCTL_MODE_GETFB Geert Uytterhoeven
2022-07-08 18:20 ` [PATCH v3 05/10] drm/fourcc: Add DRM_FORMAT_C[124] Geert Uytterhoeven
2022-07-08 18:20 ` [PATCH v3 06/10] drm/fb-helper: Add support for DRM_FORMAT_C[124] Geert Uytterhoeven
2022-07-11  8:42   ` Thomas Zimmermann
2022-07-08 18:20 ` [PATCH v3 07/10] drm/gem-fb-helper: Use actual bpp for size calculations Geert Uytterhoeven
2022-07-08 18:20 ` [PATCH v3 08/10] drm/fourcc: Clarify the meaning of single-channel "red" Geert Uytterhoeven
2022-07-08 18:20 ` [PATCH/RFC v3 09/10] drm/fourcc: Add DRM_FORMAT_R[124] Geert Uytterhoeven
2022-07-08 18:20 ` [PATCH/RFC v3 10/10] drm/fourcc: Add DRM_FORMAT_D[1248] Geert Uytterhoeven
2022-07-09 13:38 ` [PATCH v3 00/10] drm: Add support for low-color frame buffer formats Sam Ravnborg
2022-07-11  8:50   ` Thomas Zimmermann
2022-07-11  9:12     ` Sam Ravnborg
2022-08-10 16:02       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eabcf4f298184dabe46823fcf5ceffa1da0ec7ef.1657294931.git.geert@linux-m68k.org \
    --to=geert@linux-m68k.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®